Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path

2025-05-05 Thread Jakub Kicinski
Functionally LGTM. But I'm not sure if the discussion with Paolo is resolved, so here's a couple more nit picks: On Tue, 29 Apr 2025 03:26:40 + Mina Almasry wrote: > + case SCM_DEVMEM_DMABUF: > + if (cmsg->cmsg_len != CMSG_LEN(sizeof(u32))) > + return -EINVA

Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path

2025-05-05 Thread Mina Almasry
On Mon, May 5, 2025 at 12:42 AM Paolo Abeni wrote: > > On 5/2/25 9:20 PM, Mina Almasry wrote: > > On Fri, May 2, 2025 at 4:47 AM Paolo Abeni wrote: > >>> @@ -1078,7 +1092,8 @@ int tcp_sendmsg_locked(struct sock *sk, struct > >>> msghdr *msg, size_t size) > >>> zc =

Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path

2025-05-05 Thread Paolo Abeni
On 5/2/25 9:20 PM, Mina Almasry wrote: > On Fri, May 2, 2025 at 4:47 AM Paolo Abeni wrote: >>> @@ -1078,7 +1092,8 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr >>> *msg, size_t size) >>> zc = MSG_ZEROCOPY; >>> } else if (sock_flag(sk, SOCK_ZE

Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path

2025-05-05 Thread Paolo Abeni
On 5/2/25 9:25 PM, Mina Almasry wrote: > On Fri, May 2, 2025 at 4:51 AM Paolo Abeni wrote: >> >> On 5/2/25 1:47 PM, Paolo Abeni wrote: >>> On 4/29/25 5:26 AM, Mina Almasry wrote: Augment dmabuf binding to be able to handle TX. Additional to all the RX binding, we also create tx_vec neede

Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path

2025-05-02 Thread Mina Almasry
On Fri, May 2, 2025 at 4:51 AM Paolo Abeni wrote: > > On 5/2/25 1:47 PM, Paolo Abeni wrote: > > On 4/29/25 5:26 AM, Mina Almasry wrote: > >> Augment dmabuf binding to be able to handle TX. Additional to all the RX > >> binding, we also create tx_vec needed for the TX path. > >> > >> Provide API fo

Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path

2025-05-02 Thread Mina Almasry
On Fri, May 2, 2025 at 4:47 AM Paolo Abeni wrote: > > Hi, > > On 4/29/25 5:26 AM, Mina Almasry wrote: > > Augment dmabuf binding to be able to handle TX. Additional to all the RX > > binding, we also create tx_vec needed for the TX path. > > > > Provide API for sendmsg to be able to send dmabufs b

Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path

2025-05-02 Thread Paolo Abeni
On 5/2/25 1:47 PM, Paolo Abeni wrote: > On 4/29/25 5:26 AM, Mina Almasry wrote: >> Augment dmabuf binding to be able to handle TX. Additional to all the RX >> binding, we also create tx_vec needed for the TX path. >> >> Provide API for sendmsg to be able to send dmabufs bound to this device: >> >>

Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path

2025-05-02 Thread Paolo Abeni
Hi, On 4/29/25 5:26 AM, Mina Almasry wrote: > Augment dmabuf binding to be able to handle TX. Additional to all the RX > binding, we also create tx_vec needed for the TX path. > > Provide API for sendmsg to be able to send dmabufs bound to this device: > > - Provide a new dmabuf_tx_cmsg which in

[PATCH net-next v13 4/9] net: devmem: Implement TX path

2025-04-28 Thread Mina Almasry
Augment dmabuf binding to be able to handle TX. Additional to all the RX binding, we also create tx_vec needed for the TX path. Provide API for sendmsg to be able to send dmabufs bound to this device: - Provide a new dmabuf_tx_cmsg which includes the dmabuf to send from. - MSG_ZEROCOPY with SCM_D