Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-14 Thread Andrew Lunn
> One more friendly request, I see net-next is closed today, but our downstream > kernel release deadline is 5.20, so I want to test and release the new v14 > today, > is it ok? 5.20? Didn't Linus run out of fingers and thumbs and went from 5.19 to 6.0? Anyway, this is your internal issue, since

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-14 Thread Jakub Kicinski
On Tue, 14 May 2024 10:08:15 +0800 Heng Qi wrote: > > We can't make lockdep dependent on NET. > > People working on other subsystems should be able to use LOCKDEP > > with minimal builds. > > Got it. Then I declare "DIMLIB depends on NET" and clean up other places. I'm not sure if there's any

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Heng Qi
On Mon, 13 May 2024 11:42:33 -0700, Jakub Kicinski wrote: > On Mon, 13 May 2024 23:39:04 +0800 Heng Qi wrote: > > config PROVE_LOCKING > > bool "Lock debugging: prove locking correctness" > > - depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT > > + depends on DEBUG_KERNEL &&

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Jakub Kicinski
On Mon, 13 May 2024 23:39:04 +0800 Heng Qi wrote: > config PROVE_LOCKING > bool "Lock debugging: prove locking correctness" > - depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT > + depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && NET We can't make lockdep dependent on NET

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Heng Qi
On Mon, 13 May 2024 08:24:12 -0700, Jakub Kicinski wrote: > On Mon, 13 May 2024 22:52:13 +0800 Heng Qi wrote: > > > > So I think we should declare "CONFIG_PROVE_LOCKING depends on > > > > CONFIG_NET". > > > > How do you think? > > > > > > Doesn't sound right, `can we instead make building lib/

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Jakub Kicinski
On Mon, 13 May 2024 22:52:13 +0800 Heng Qi wrote: > > > So I think we should declare "CONFIG_PROVE_LOCKING depends on CONFIG_NET". > > > How do you think? > > > > Doesn't sound right, `can we instead make building lib/dim/net_dim.c > > Why? IIUC, the reason is that if CONFIG_NET is not set to

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Heng Qi
On Mon, 13 May 2024 07:22:49 -0700, Jakub Kicinski wrote: > On Mon, 13 May 2024 00:36:58 +0800 Heng Qi wrote: > > This failed use case seems to come from this series triggering a problem > > that > > has not been triggered historically, namely lockdep_rtnl_is_held() is not > > called > > in an e

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-13 Thread Jakub Kicinski
On Mon, 13 May 2024 00:36:58 +0800 Heng Qi wrote: > This failed use case seems to come from this series triggering a problem that > has not been triggered historically, namely lockdep_rtnl_is_held() is not > called > in an environment where CONFIG_NET is not configured and CONFIG_PROVE_LOCKING >

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-12 Thread Heng Qi
acros-to-h-file/20240509-125007 > base: net-next/main > patch link: > https://lore.kernel.org/r/20240509044747.101237-3-hengqi%40linux.alibaba.com > patch subject: [PATCH net-next v13 2/4] ethtool: provide customized dim > profile management > config: arm-randconfig-002-20

Re: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-09 Thread kernel test robot
/20240509044747.101237-3-hengqi%40linux.alibaba.com patch subject: [PATCH net-next v13 2/4] ethtool: provide customized dim profile management config: arm-randconfig-002-20240510 (https://download.01.org/0day-ci/archive/20240510/202405100654.5pblqxnl-...@intel.com/config) compiler: clang version 19.0.0git

[PATCH net-next v13 2/4] ethtool: provide customized dim profile management

2024-05-08 Thread Heng Qi
The NetDIM library, currently leveraged by an array of NICs, delivers excellent acceleration benefits. Nevertheless, NICs vary significantly in their dim profile list prerequisites. Specifically, virtio-net backends may present diverse sw or hw device implementation, making a one-size-fits-all par