Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-05-03 Thread Heng Qi
On Fri, 3 May 2024 14:52:44 +0100, Simon Horman wrote: > On Wed, May 01, 2024 at 01:31:34AM +0800, Heng Qi wrote: > > ... > > > diff --git a/include/linux/dim.h b/include/linux/dim.h > > ... > > > @@ -198,6 +234,32 @@ enum dim_step_result { > > DIM_ON_EDGE, > > }; > > > > +/** > > + * n

Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-05-03 Thread Simon Horman
On Wed, May 01, 2024 at 01:31:34AM +0800, Heng Qi wrote: ... > diff --git a/include/linux/dim.h b/include/linux/dim.h ... > @@ -198,6 +234,32 @@ enum dim_step_result { > DIM_ON_EDGE, > }; > > +/** > + * net_dim_init_irq_moder - collect information to initialize irq moderation > + * @de

Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-05-01 Thread Heng Qi
On Wed, 1 May 2024 11:48:23 -0400, "Michael S. Tsirkin" wrote: > On Wed, May 01, 2024 at 11:11:47PM +0800, Heng Qi wrote: > > On Wed, 1 May 2024 07:44:20 -0700, Jakub Kicinski wrote: > > > On Wed, 1 May 2024 12:45:36 +0800 Heng Qi wrote: > > > > >net/ethtool/coalesce.c: At top level: > > >

Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-05-01 Thread Michael S. Tsirkin
On Wed, May 01, 2024 at 11:11:47PM +0800, Heng Qi wrote: > On Wed, 1 May 2024 07:44:20 -0700, Jakub Kicinski wrote: > > On Wed, 1 May 2024 12:45:36 +0800 Heng Qi wrote: > > > >net/ethtool/coalesce.c: At top level: > > > [...] > > > > 446 | static int ethnl_update_profile(struct net_d

Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-05-01 Thread Heng Qi
On Wed, 1 May 2024 07:44:20 -0700, Jakub Kicinski wrote: > On Wed, 1 May 2024 12:45:36 +0800 Heng Qi wrote: > > >net/ethtool/coalesce.c: At top level: > > [...] > > > 446 | static int ethnl_update_profile(struct net_device *dev, > > > |^~~~ > >

Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-05-01 Thread Jakub Kicinski
On Wed, 1 May 2024 12:45:36 +0800 Heng Qi wrote: > >net/ethtool/coalesce.c: At top level: > [...] > > 446 | static int ethnl_update_profile(struct net_device *dev, > > |^~~~ > [...] > > 151 | static int coalesce_put_profile(struct sk_buff

Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-05-01 Thread kernel test robot
/20240430173136.15807-3-hengqi%40linux.alibaba.com patch subject: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management config: um-allmodconfig (https://download.01.org/0day-ci/archive/20240501/202405011500.j5qsgquf-...@intel.com/config) compiler: clang version 19.0.0git (https

Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-05-01 Thread kernel test robot
/20240430173136.15807-3-hengqi%40linux.alibaba.com patch subject: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240501/202405011418.eyj7bgrd-...@intel.com/config) compiler: or1k-linux-gcc (GCC) 13.2.0

Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-04-30 Thread Michael S. Tsirkin
t; > url: > > https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/linux-dim-move-useful-macros-to-h-file/20240501-013413 > > base: net-next/main > > patch link: > > https://lore.kernel.org/r/20240430173136.15807-3-hengqi%40linux.alibaba.com > > patch sub

Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-04-30 Thread Heng Qi
-useful-macros-to-h-file/20240501-013413 > base: net-next/main > patch link: > https://lore.kernel.org/r/20240430173136.15807-3-hengqi%40linux.alibaba.com > patch subject: [PATCH net-next v11 2/4] ethtool: provide customized dim > profile management > config: openrisc-defconfig

Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-04-30 Thread kernel test robot
/20240430173136.15807-3-hengqi%40linux.alibaba.com patch subject: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240501/202405011004.rkw6irsl-...@intel.com/config) compiler: or1k-linux-gcc (GCC) 13.2.0

[PATCH net-next v11 2/4] ethtool: provide customized dim profile management

2024-04-30 Thread Heng Qi
The NetDIM library, currently leveraged by an array of NICs, delivers excellent acceleration benefits. Nevertheless, NICs vary significantly in their dim profile list prerequisites. Specifically, virtio-net backends may present diverse sw or hw device implementation, making a one-size-fits-all par