Re: [PATCH V5 3/8] misc/pvpanic: revmove unnecessary header file

2018-11-01 Thread Andy Shevchenko
On Thu, Nov 1, 2018 at 9:00 AM Peng Hao wrote: > > remove unnecessary header file init.h. > Same comments as per patch 1, on top of this is ordering issue. This patch should be 6/8. Also, address Mark's comments, please. Otherwise, Reviewed-by: Andy Shevchenko > Signed-off-by: Peng Hao > ---

Re: [PATCH V5 3/8] misc/pvpanic: revmove unnecessary header file

2018-11-01 Thread Mark Rutland
On Thu, Nov 01, 2018 at 11:34:29AM +, Mark Rutland wrote: > On Thu, Nov 01, 2018 at 11:09:57PM +0800, Peng Hao wrote: > > remove unnecessary header file init.h. > > > > Signed-off-by: Peng Hao > > Acked-by: Mark Rutland ... though please fix the title: s/revmove/remove/ Mark.

Re: [PATCH V5 3/8] misc/pvpanic: revmove unnecessary header file

2018-11-01 Thread Mark Rutland
On Thu, Nov 01, 2018 at 11:09:57PM +0800, Peng Hao wrote: > remove unnecessary header file init.h. > > Signed-off-by: Peng Hao Acked-by: Mark Rutland Mark. > --- > drivers/misc/pvpanic.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c

[PATCH V5 3/8] misc/pvpanic: revmove unnecessary header file

2018-11-01 Thread Peng Hao
remove unnecessary header file init.h. Signed-off-by: Peng Hao --- drivers/misc/pvpanic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c index 059005c..66534d4 100644 --- a/drivers/misc/pvpanic.c +++ b/drivers/misc/pvpanic.c @@ -22,7 +22,6 @@