Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-08-16 Thread Rafał Miłecki
On 29 July 2016 at 09:09, Rafał Miłecki wrote: > HI Rob, > > I got problems following your objections, so it took me some time to > go back to this. > > On 21 July 2016 at 22:42, Rob Herring wrote: >> On Wed, Jul 20, 2016 at 10:06:23AM +0200, Rafał Miłecki wrote: >>> On 20 July 2016 at 03:02, Rob

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-29 Thread Rafał Miłecki
HI Rob, I got problems following your objections, so it took me some time to go back to this. On 21 July 2016 at 22:42, Rob Herring wrote: > On Wed, Jul 20, 2016 at 10:06:23AM +0200, Rafał Miłecki wrote: >> On 20 July 2016 at 03:02, Rob Herring wrote: >> > On Fri, Jul 15, 2016 at 11:10:45PM +02

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-21 Thread Rob Herring
On Wed, Jul 20, 2016 at 10:06:23AM +0200, Rafał Miłecki wrote: > On 20 July 2016 at 03:02, Rob Herring wrote: > > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: > >> This commit adds a new trigger that can turn on LED when USB device gets > >> connected to the USB port. This can be

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-20 Thread Pavel Machek
On Mon 2016-07-18 08:55:52, Rafał Miłecki wrote: > On 18 July 2016 at 07:53, Peter Chen wrote: > > On Mon, Jul 18, 2016 at 07:57:34AM +0200, Rafał Miłecki wrote: > >> On 18 July 2016 at 07:40, Peter Chen wrote: > >> > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: > >> >> On 18 Ju

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-20 Thread Rafał Miłecki
On 20 July 2016 at 03:02, Rob Herring wrote: > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: >> This commit adds a new trigger that can turn on LED when USB device gets >> connected to the USB port. This can be useful for various home routers >> that have USB port and a proper LED

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-20 Thread Pavel Machek
Hi! > > @@ -0,0 +1,206 @@ > > +/* > > + * USB port LED trigger > > + * > > + * Copyright (C) 2016 Rafał Miłecki > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by > > + * the Free Softwa

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-19 Thread Rob Herring
On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: > This commit adds a new trigger that can turn on LED when USB device gets > connected to the USB port. This can be useful for various home routers > that have USB port and a proper LED telling user a device is connected. > > Right now

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Rafał Miłecki
On 18 July 2016 at 07:53, Peter Chen wrote: > On Mon, Jul 18, 2016 at 07:57:34AM +0200, Rafał Miłecki wrote: >> On 18 July 2016 at 07:40, Peter Chen wrote: >> > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: >> >> On 18 July 2016 at 04:31, Peter Chen wrote: >> >> > On Fri, Jul 15

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Peter Chen
On Mon, Jul 18, 2016 at 07:57:34AM +0200, Rafał Miłecki wrote: > On 18 July 2016 at 07:40, Peter Chen wrote: > > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: > >> On 18 July 2016 at 04:31, Peter Chen wrote: > >> > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: >

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Rafał Miłecki
On 18 July 2016 at 07:40, Peter Chen wrote: > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: >> On 18 July 2016 at 04:31, Peter Chen wrote: >> > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: >> >> + >> >> +usbport trigger: >> >> +- usb-ports : List of USB ports th

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Peter Chen
On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: > On 18 July 2016 at 04:31, Peter Chen wrote: > > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: > >> + > >> +usbport trigger: > >> +- usb-ports : List of USB ports that usbport should observed for turning > >> on a >

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Rafał Miłecki
On 18 July 2016 at 04:31, Peter Chen wrote: > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: >> + >> +usbport trigger: >> +- usb-ports : List of USB ports that usbport should observed for turning on >> a >> + given LED. >> + > > %s/should/should be Thanks. >> diff --g

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Peter Chen
On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: > + > +usbport trigger: > +- usb-ports : List of USB ports that usbport should observed for turning on a > + given LED. > + %s/should/should be > Examples: > > system-status { > @@ -58,6 +64,11 @@ system-status { >

[PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-15 Thread Rafał Miłecki
This commit adds a new trigger that can turn on LED when USB device gets connected to the USB port. This can be useful for various home routers that have USB port and a proper LED telling user a device is connected. Right now this trigger is usable with a proper DT only, there isn't a way to speci