Re: [PATCH RFC net] docs: netdev: document guidance on cleanup patches

2024-10-08 Thread Simon Horman
On Mon, Oct 07, 2024 at 09:54:12AM -0700, Jakub Kicinski wrote: > On Mon, 7 Oct 2024 17:15:01 +0100 Simon Horman wrote: > > > > We could merge or otherwise rearrange that section with the one > > > > proposed by > > > > this patch. But I didn't feel it was necessary last week. > > > > > > Somew

Re: [PATCH RFC net] docs: netdev: document guidance on cleanup patches

2024-10-07 Thread Jakub Kicinski
On Mon, 7 Oct 2024 17:15:01 +0100 Simon Horman wrote: > > > We could merge or otherwise rearrange that section with the one proposed > > > by > > > this patch. But I didn't feel it was necessary last week. > > > > Somewhat, we don't push back on correct use of device-managed APIs. > > But conve

Re: [PATCH RFC net] docs: netdev: document guidance on cleanup patches

2024-10-07 Thread Simon Horman
On Mon, Oct 07, 2024 at 09:08:28AM -0700, Jakub Kicinski wrote: > On Mon, 7 Oct 2024 16:55:21 +0100 Simon Horman wrote: > > > > +Netdev discourages patches which perform simple clean-ups, which are > > > > not in > > > > +the context of other work. For example addressing ``checkpatch.pl`` > > > >

Re: [PATCH RFC net] docs: netdev: document guidance on cleanup patches

2024-10-07 Thread Jakub Kicinski
On Mon, 7 Oct 2024 16:55:21 +0100 Simon Horman wrote: > > > +Netdev discourages patches which perform simple clean-ups, which are not > > > in > > > +the context of other work. For example addressing ``checkpatch.pl`` > > > +warnings, or :ref:`local variable ordering` issues. This is because > >

Re: [PATCH RFC net] docs: netdev: document guidance on cleanup patches

2024-10-07 Thread Simon Horman
On Mon, Oct 07, 2024 at 08:24:30AM -0700, Jakub Kicinski wrote: > On Fri, 04 Oct 2024 10:49:53 +0100 Simon Horman wrote: > > The purpose of this section is to document what is the current practice > > regarding clean-up patches which address checkpatch warnings and similar > > problems. I feel ther

Re: [PATCH RFC net] docs: netdev: document guidance on cleanup patches

2024-10-07 Thread Jakub Kicinski
On Fri, 04 Oct 2024 10:49:53 +0100 Simon Horman wrote: > The purpose of this section is to document what is the current practice > regarding clean-up patches which address checkpatch warnings and similar > problems. I feel there is a value in having this documented so others > can easily refer to i

[PATCH RFC net] docs: netdev: document guidance on cleanup patches

2024-10-04 Thread Simon Horman
The purpose of this section is to document what is the current practice regarding clean-up patches which address checkpatch warnings and similar problems. I feel there is a value in having this documented so others can easily refer to it. Clearly this topic is subjective. And to some extent the cu