Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

2018-05-23 Thread Guenter Roeck
On Wed, May 23, 2018 at 01:12:10PM +0100, Robin Murphy wrote: > On 22/05/18 20:31, Stefan Wahren wrote: > [...] > >+static int rpi_hwmon_probe(struct platform_device *pdev) > >+{ > >+struct device *dev = &pdev->dev; > >+struct rpi_hwmon_data *data; > >+in

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

2018-05-23 Thread Robin Murphy
On 22/05/18 20:31, Stefan Wahren wrote: [...] +static int rpi_hwmon_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct rpi_hwmon_data *data; + int ret; + + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); + if (!data) +

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

2018-05-22 Thread Stefan Wahren
> Guenter Roeck hat am 22. Mai 2018 um 16:10 geschrieben: > > > On 05/22/2018 06:51 AM, Stefan Wahren wrote: > > Hi Guenter, > > > >> Guenter Roeck hat am 22. Mai 2018 um 15:41 > >> geschrieben: > >> > >> > >> On 05/22/2018 04:21 AM, Stefan Wahren wrote: > >>> Currently there is no easy way

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

2018-05-22 Thread Guenter Roeck
On 05/22/2018 06:51 AM, Stefan Wahren wrote: Hi Guenter, Guenter Roeck hat am 22. Mai 2018 um 15:41 geschrieben: On 05/22/2018 04:21 AM, Stefan Wahren wrote: Currently there is no easy way to detect undervoltage conditions on a remote Raspberry Pi. This hwmon driver retrieves the state of t

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

2018-05-22 Thread Stefan Wahren
Hi Guenter, > Guenter Roeck hat am 22. Mai 2018 um 15:41 geschrieben: > > > On 05/22/2018 04:21 AM, Stefan Wahren wrote: > > Currently there is no easy way to detect undervoltage conditions on a > > remote Raspberry Pi. This hwmon driver retrieves the state of the > > undervoltage sensor via ma

Re: [PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

2018-05-22 Thread Guenter Roeck
On 05/22/2018 04:21 AM, Stefan Wahren wrote: Currently there is no easy way to detect undervoltage conditions on a remote Raspberry Pi. This hwmon driver retrieves the state of the undervoltage sensor via mailbox interface. The handling based on Noralf's modifications to the downstream firmware d

[PATCH RFC V2 2/6] hwmon: Add support for RPi voltage sensor

2018-05-22 Thread Stefan Wahren
Currently there is no easy way to detect undervoltage conditions on a remote Raspberry Pi. This hwmon driver retrieves the state of the undervoltage sensor via mailbox interface. The handling based on Noralf's modifications to the downstream firmware driver. In case of an undervoltage condition onl