Re: [PATCH 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-13 Thread Alan Cox
On Mon, 12 Jun 2017 20:26:13 +0300 Tal Shorer wrote: > The user can issue USB_F_GET_LINE_CODING to get the current line coding > as set by the host (or the default if unset yet). No this is not how to do it. We don't want weirdass ioctls for each different tty device type. There are two ways th

Re: [PATCH 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-12 Thread Tal Shorer
pply. I can resend a v2 if > necessary, but the correct patch is as follows: Actually, it shouldn't even be in this patch. I somehow meshed 5 and 6 together. The correct PATCH 6/8 is as follows: >From d7d56ceb8020f10623a04b4634f93e4cc678454d Mon Sep 17 00:00:00 2001 From: Tal Shorer

Re: [PATCH 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-12 Thread Tal Shorer
acm->port_line_coding.bDataBits = 8; > > return &acm->port.func; > } This hunk was messed up somehow and will not apply. I can resend a v2 if necessary, but the correct patch is as follows: From: Tal Shorer Subject: [PATCH 6/8] usb: gadget: f_acm: add an ioctl

[PATCH 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-12 Thread Tal Shorer
The user can issue USB_F_GET_LINE_CODING to get the current line coding as set by the host (or the default if unset yet). Signed-off-by: Tal Shorer --- Documentation/ioctl/ioctl-number.txt | 1 + drivers/usb/gadget/function/f_acm.c | 27 +++ include/uapi/linux/usb/f_acm