Re: [PATCH 3/5] rcu/tree: Add support for debug_objects debugging for kfree_rcu()

2019-08-28 Thread Paul E. McKenney
On Wed, Aug 28, 2019 at 05:43:20PM -0400, Joel Fernandes wrote: > On Wed, Aug 28, 2019 at 02:31:19PM -0700, Paul E. McKenney wrote: > > On Tue, Aug 27, 2019 at 03:01:57PM -0400, Joel Fernandes (Google) wrote: > > > Make use of RCU's debug_objects debugging support > > > (CONFIG_DEBUG_OBJECTS_RCU_HE

Re: [PATCH 3/5] rcu/tree: Add support for debug_objects debugging for kfree_rcu()

2019-08-28 Thread Joel Fernandes
On Wed, Aug 28, 2019 at 02:31:19PM -0700, Paul E. McKenney wrote: > On Tue, Aug 27, 2019 at 03:01:57PM -0400, Joel Fernandes (Google) wrote: > > Make use of RCU's debug_objects debugging support > > (CONFIG_DEBUG_OBJECTS_RCU_HEAD) similar to call_rcu() and other flavors. > > Other flavors? Ah, ca

Re: [PATCH 3/5] rcu/tree: Add support for debug_objects debugging for kfree_rcu()

2019-08-28 Thread Paul E. McKenney
On Tue, Aug 27, 2019 at 03:01:57PM -0400, Joel Fernandes (Google) wrote: > Make use of RCU's debug_objects debugging support > (CONFIG_DEBUG_OBJECTS_RCU_HEAD) similar to call_rcu() and other flavors. Other flavors? Ah, call_srcu(), rcu_barrier(), and srcu_barrier(), right? > We queue the object

[PATCH 3/5] rcu/tree: Add support for debug_objects debugging for kfree_rcu()

2019-08-27 Thread Joel Fernandes (Google)
Make use of RCU's debug_objects debugging support (CONFIG_DEBUG_OBJECTS_RCU_HEAD) similar to call_rcu() and other flavors. We queue the object during the kfree_rcu() call and dequeue it during reclaim. Tested that enabling CONFIG_DEBUG_OBJECTS_RCU_HEAD successfully detects double kfree_rcu() calls