Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

2017-09-19 Thread Prarit Bhargava
On 09/17/2017 06:46 AM, Sergey Senozhatsky wrote: > I'm a bit uncomfortable with the "breaks user space" part. since this > is a strictly debugging option, would it be sufficient to store those > extended timestamps as prefixes of every message? > see (sorry for "self-quoting"): > lkml.ker

Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

2017-09-17 Thread Sergey Senozhatsky
On (09/15/17 07:29), Mark Salyzyn wrote: > On 09/15/2017 06:28 AM, Petr Mladek wrote: > > I am still slightly nervous that external tools would need updating. > > Also they might have troubles to interpret the time stamps especially > > when the source is changed at runtime via > > /sys/module/prin

Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

2017-09-15 Thread Prarit Bhargava
On 09/15/2017 09:28 AM, Petr Mladek wrote: > > I am still slightly nervous that external tools would need updating. > Also they might have troubles to interpret the time stamps especially > when the source is changed at runtime via > /sys/module/printk/parameters/time. In earlier versions I had

Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

2017-09-15 Thread Mark Salyzyn
On 09/15/2017 06:28 AM, Petr Mladek wrote: I am still slightly nervous that external tools would need updating. Also they might have troubles to interpret the time stamps especially when the source is changed at runtime via /sys/module/printk/parameters/time. My comment below is a rehash/summary

Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

2017-09-15 Thread Petr Mladek
On Tue 2017-09-05 08:06:41, Prarit Bhargava wrote: > printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock > timestamp to printk messages. The local hardware clock loses time each > day making it difficult to determine exactly when an issue has occurred in > the kernel log, and

Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

2017-09-13 Thread Mark Salyzyn
On 09/05/2017 05:06 AM, Prarit Bhargava wrote: printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock timestamp to printk messages. The local hardware clock loses time each day making it difficult to determine exactly when an issue has occurred in the kernel log, and making it

[PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

2017-09-05 Thread Prarit Bhargava
printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock timestamp to printk messages. The local hardware clock loses time each day making it difficult to determine exactly when an issue has occurred in the kernel log, and making it difficult to determine how kernel and hardware i