Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-08 Thread Laxman Dewangan
On Wednesday 08 June 2016 08:34 PM, Andrew F. Davis wrote: On 06/07/2016 05:30 PM, Guenter Roeck wrote: On Fri, Jun 03, 2016 at 10:17:55AM -0500, Andrew F. Davis wrote: On 06/03/2016 09:14 AM, Laxman Dewangan wrote: On Friday 03 June 2016 06:59 PM, Guenter Roeck wrote: On 06/03/2016 03:06 AM

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-08 Thread Andrew F. Davis
On 06/07/2016 05:30 PM, Guenter Roeck wrote: > On Fri, Jun 03, 2016 at 10:17:55AM -0500, Andrew F. Davis wrote: >> On 06/03/2016 09:14 AM, Laxman Dewangan wrote: >>> >>> On Friday 03 June 2016 06:59 PM, Guenter Roeck wrote: On 06/03/2016 03:06 AM, Jonathan Cameron wrote: > On 01/06/16 13:3

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-07 Thread Guenter Roeck
On Fri, Jun 03, 2016 at 10:17:55AM -0500, Andrew F. Davis wrote: > On 06/03/2016 09:14 AM, Laxman Dewangan wrote: > > > > On Friday 03 June 2016 06:59 PM, Guenter Roeck wrote: > >> On 06/03/2016 03:06 AM, Jonathan Cameron wrote: > >>> On 01/06/16 13:34, Laxman Dewangan wrote: > The INA3221 is

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Andrew F. Davis
On 06/03/2016 09:14 AM, Laxman Dewangan wrote: > > On Friday 03 June 2016 06:59 PM, Guenter Roeck wrote: >> On 06/03/2016 03:06 AM, Jonathan Cameron wrote: >>> On 01/06/16 13:34, Laxman Dewangan wrote: The INA3221 is a three-channel, high-side current and bus voltage monitor with an

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Laxman Dewangan
On Friday 03 June 2016 06:59 PM, Guenter Roeck wrote: On 06/03/2016 03:06 AM, Jonathan Cameron wrote: On 01/06/16 13:34, Laxman Dewangan wrote: The INA3221 is a three-channel, high-side current and bus voltage monitor with an I2C interface from Texas Instruments. The INA3221 monitors both shu

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Guenter Roeck
On 06/03/2016 03:06 AM, Jonathan Cameron wrote: On 01/06/16 13:34, Laxman Dewangan wrote: The INA3221 is a three-channel, high-side current and bus voltage monitor with an I2C interface from Texas Instruments. The INA3221 monitors both shunt voltage drops and bus supply voltages in addition to h

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Laxman Dewangan
On Friday 03 June 2016 05:39 PM, Jonathan Cameron wrote: On 03/06/16 12:26, Laxman Dewangan wrote: On Friday 03 June 2016 03:36 PM, Jonathan Cameron wrote: I thought that all ADC or monitors are going to be part of IIO device framework. I saw the ina2xx which is same (single channel) which was

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Laxman Dewangan
On Friday 03 June 2016 05:34 PM, Jonathan Cameron wrote: On 03/06/16 12:31, Laxman Dewangan wrote: On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote: On 03/06/16 11:06, Jonathan Cameron wrote: Code looks good, bu these more fundamental bits need sorting. Another minor point - why do th

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Jonathan Cameron
On 03/06/16 12:26, Laxman Dewangan wrote: > > On Friday 03 June 2016 03:36 PM, Jonathan Cameron wrote: >> On 01/06/16 13:34, Laxman Dewangan wrote: >>> Add support for INA3221 SW driver via IIO ADC interface. The device is >>> register as iio-device and provides interface for voltage/current and p

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Jonathan Cameron
On 03/06/16 12:31, Laxman Dewangan wrote: > > On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote: >> On 03/06/16 11:06, Jonathan Cameron wrote: >>> >>> Code looks good, bu these more fundamental bits need sorting. >> Another minor point - why do the power calculations in driver? >> no hardwar

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Laxman Dewangan
On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote: On 03/06/16 11:06, Jonathan Cameron wrote: Code looks good, bu these more fundamental bits need sorting. Another minor point - why do the power calculations in driver? no hardware support for it, so why not just leave it to userspace?

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Laxman Dewangan
On Friday 03 June 2016 03:36 PM, Jonathan Cameron wrote: On 01/06/16 13:34, Laxman Dewangan wrote: Add support for INA3221 SW driver via IIO ADC interface. The device is register as iio-device and provides interface for voltage/current and power monitor. Also provide interface for setting onesh

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Jonathan Cameron
On 03/06/16 11:06, Jonathan Cameron wrote: > On 01/06/16 13:34, Laxman Dewangan wrote: >> The INA3221 is a three-channel, high-side current and bus voltage monitor >> with an I2C interface from Texas Instruments. The INA3221 monitors both >> shunt voltage drops and bus supply voltages in addition t

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-03 Thread Jonathan Cameron
On 01/06/16 13:34, Laxman Dewangan wrote: > The INA3221 is a three-channel, high-side current and bus voltage monitor > with an I2C interface from Texas Instruments. The INA3221 monitors both > shunt voltage drops and bus supply voltages in addition to having > programmable conversion times and ave

[PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-01 Thread Laxman Dewangan
The INA3221 is a three-channel, high-side current and bus voltage monitor with an I2C interface from Texas Instruments. The INA3221 monitors both shunt voltage drops and bus supply voltages in addition to having programmable conversion times and averaging modes for these signals. The INA3221 offers