Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-07 Thread Matthew Wilcox
On Wed, Nov 07, 2018 at 05:30:22PM +, vitor wrote: > Hi Matthew, > > > On 07/11/18 17:05, Matthew Wilcox wrote: > > On Mon, Oct 29, 2018 at 10:06:56AM +, Vitor soares wrote: > > > Add driver for Synopsys DesignWare I3C master IP > > The so-called "data sheet" (actually just an advertising

Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-07 Thread vitor
Hi Matthew, On 07/11/18 17:05, Matthew Wilcox wrote: On Mon, Oct 29, 2018 at 10:06:56AM +, Vitor soares wrote: Add driver for Synopsys DesignWare I3C master IP The so-called "data sheet" (actually just an advertising brochure) The datasheet is there to download. on your website clai

Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-07 Thread vitor
Hi Geert, On 07/11/18 15:34, Geert Uytterhoeven wrote: Hi Vitor, On Wed, Nov 7, 2018 at 4:15 PM vitor wrote: On 29/10/18 13:41, Matthew Wilcox wrote: On Mon, Oct 29, 2018 at 10:06:56AM +, Vitor soares wrote: +config DW_I3C_MASTER +tristate "Synospsys DesignWare I3C master driver" +

Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-07 Thread Matthew Wilcox
On Mon, Oct 29, 2018 at 10:06:56AM +, Vitor soares wrote: > Add driver for Synopsys DesignWare I3C master IP The so-called "data sheet" (actually just an advertising brochure) on your website claims DMA support. I don't see that support anywhere in this driver.

Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-07 Thread Geert Uytterhoeven
Hi Vitor, On Wed, Nov 7, 2018 at 4:15 PM vitor wrote: > On 29/10/18 13:41, Matthew Wilcox wrote: > > On Mon, Oct 29, 2018 at 10:06:56AM +, Vitor soares wrote: > >> +config DW_I3C_MASTER > >> +tristate "Synospsys DesignWare I3C master driver" > >> +depends on I3C > >> +depends on !

Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-07 Thread vitor
Hi Matthew, Thank for your feedback. On 29/10/18 13:41, Matthew Wilcox wrote: On Mon, Oct 29, 2018 at 10:06:56AM +, Vitor soares wrote: +config DW_I3C_MASTER + tristate "Synospsys DesignWare I3C master driver" + depends on I3C + depends on !(ALPHA || PARISC) why? Pleas

Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-10-29 Thread Matthew Wilcox
On Mon, Oct 29, 2018 at 10:06:56AM +, Vitor soares wrote: > +config DW_I3C_MASTER > + tristate "Synospsys DesignWare I3C master driver" > + depends on I3C > + depends on !(ALPHA || PARISC) why? > + help > + Support·for·Synopsys·DesignWare·MIPI·I3C·Controller. These str

[PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-10-29 Thread Vitor soares
Add driver for Synopsys DesignWare I3C master IP Signed-off-by: Vitor soares --- Change in v2: -Rename some variables -Remove dw_i3c_master_dev_set_info() -Ajust code to match the changes made of i3c subsystem -Use readsl/writesl() to populate TX/RX buffers drivers/i3c/master/Kconfig |