Re: [PATCH 1/3] hwmon: Add Texas Instruments TMP108 temperature sensor driver.

2016-11-28 Thread Guenter Roeck
On Mon, Nov 28, 2016 at 03:10:38PM -0800, John Muir wrote: > On Nov 28, 2016, at 2:19 PM, Guenter Roeck wrote: > > > > The tmp102 driver adds the timeout if the device was in shutdown mode > > (SD=1). > > > > if (tmp102->config_orig & TMP102_CONF_SD) { > > ... > > tm

Re: [PATCH 1/3] hwmon: Add Texas Instruments TMP108 temperature sensor driver.

2016-11-28 Thread John Muir
On Nov 28, 2016, at 2:19 PM, Guenter Roeck wrote: > > The tmp102 driver adds the timeout if the device was in shutdown mode (SD=1). > > if (tmp102->config_orig & TMP102_CONF_SD) { > ... > tmp102->ready_time += msecs_to_jiffies(CONVERSION_TIME_MS); > } > >

Re: [PATCH 1/3] hwmon: Add Texas Instruments TMP108 temperature sensor driver.

2016-11-28 Thread Guenter Roeck
On Mon, Nov 28, 2016 at 01:25:37PM -0800, John Muir wrote: > > > On Nov 28, 2016, at 11:58 AM, Guenter Roeck wrote: > > > > On Mon, Nov 28, 2016 at 11:40:42AM -0800, John Muir wrote: > +static void tmp108_update_ready_time(struct tmp108 *tmp108) > +{ > +tmp108->ready_time

Re: [PATCH 1/3] hwmon: Add Texas Instruments TMP108 temperature sensor driver.

2016-11-28 Thread John Muir
> On Nov 28, 2016, at 11:58 AM, Guenter Roeck wrote: > > On Mon, Nov 28, 2016 at 11:40:42AM -0800, John Muir wrote: +static void tmp108_update_ready_time(struct tmp108 *tmp108) +{ + tmp108->ready_time = jiffies; + if ((tmp108->config & TMP108_CONF_MODE_MASK) + ==

Re: [PATCH 1/3] hwmon: Add Texas Instruments TMP108 temperature sensor driver.

2016-11-28 Thread Guenter Roeck
On Mon, Nov 28, 2016 at 11:40:42AM -0800, John Muir wrote: > > > On Nov 27, 2016, at 4:19 AM, Guenter Roeck wrote: > > > > On 11/26/2016 09:15 PM, John Muir wrote: > >> Add support for the TI TMP108 temperature sensor with some device > >> configuration parameters. > >> +- ti,alert-active-high :

Re: [PATCH 1/3] hwmon: Add Texas Instruments TMP108 temperature sensor driver.

2016-11-28 Thread John Muir
> On Nov 27, 2016, at 4:19 AM, Guenter Roeck wrote: > > On 11/26/2016 09:15 PM, John Muir wrote: >> Add support for the TI TMP108 temperature sensor with some device >> configuration parameters. >> +- ti,alert-active-high : (boolean) make the alert pin active-high instead of >> + the defaul

Re: [PATCH 1/3] hwmon: Add Texas Instruments TMP108 temperature sensor driver.

2016-11-27 Thread Guenter Roeck
On 11/26/2016 09:15 PM, John Muir wrote: Add support for the TI TMP108 temperature sensor with some device configuration parameters. Signed-off-by: John Muir --- Documentation/devicetree/bindings/hwmon/tmp108.txt | 27 ++ Documentation/hwmon/tmp108 | 38 ++ drivers/hw

[PATCH 1/3] hwmon: Add Texas Instruments TMP108 temperature sensor driver.

2016-11-26 Thread John Muir
Add support for the TI TMP108 temperature sensor with some device configuration parameters. Signed-off-by: John Muir --- Documentation/devicetree/bindings/hwmon/tmp108.txt | 27 ++ Documentation/hwmon/tmp108 | 38 ++ drivers/hwmon/Kconfig |