Hi Guenter,
On Dec 1, 2016, at 2:08 PM, Guenter Roeck wrote:
>
>>
>> Should we be concerned about restoring the configuration here?
>>
> Interesting question. If the chip was really powered off, you would
> have to restore the entire configuration, not just the configuration
> register. Given
Hi John,
On Thu, Dec 01, 2016 at 01:50:22PM -0800, John Muir wrote:
> Hi Guenter,
>
[ ... ]
>
> >> +static int __maybe_unused tmp108_resume(struct device *dev)
> >> +{
> >> + struct tmp108 *tmp108 = dev_get_drvdata(dev);
> >> + int err;
> >> +
> >> + err = regmap_write(tmp108->regmap, TMP108_
Hi Guenter,
On Dec 1, 2016, at 7:19 AM, Guenter Roeck wrote:
>
>> +/* convert 12-bit TMP108 register value to milliCelsius */
>> +static inline int tmp108_temp_reg_to_mC(s16 val)
>> +{
>> +return (val & ~0x01) * 1000 / 256;
>
> Why ~0x01 and not ~0x0f ? The lower 4 bits are supposed to be 0
Hi John,
On 11/30/2016 12:36 PM, John Muir wrote:
Add support for the TI TMP108 temperature sensor with some device
configuration parameters.
Overall looks pretty good. Just a couple of nitpicks.
Thanks,
Guenter
Signed-off-by: John Muir
---
Documentation/hwmon/tmp108 | 38
drivers/
Add support for the TI TMP108 temperature sensor with some device
configuration parameters.
Signed-off-by: John Muir
---
Documentation/hwmon/tmp108 | 38
drivers/hwmon/Kconfig | 11 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/tmp108.c | 495 +++
