Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-23 Thread Julia Lawall
On Sun, 22 Jan 2017, Joe Perches wrote: > On Sun, 2017-01-22 at 22:43 -0800, Joe Perches wrote: > > Two questions for Julia Lawall: > > > > o is there a better way to do this than repeat the blocks > > one for each replacement > > o can struct device * dev be made an arbitrary identifier > > >

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-22 Thread Julia Lawall
On Sun, 22 Jan 2017, Guenter Roeck wrote: > On 01/22/2017 10:43 PM, Joe Perches wrote: > > On Sat, 2017-01-21 at 11:20 -0800, Florian Fainelli wrote: > > > We have a device reference, utilize it instead of pr_warn(). > > > > There is at least one more hwmon to convert in applesmc.c > > > > Perha

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-22 Thread Guenter Roeck
On 01/22/2017 10:43 PM, Joe Perches wrote: On Sat, 2017-01-21 at 11:20 -0800, Florian Fainelli wrote: We have a device reference, utilize it instead of pr_warn(). There is at least one more hwmon to convert in applesmc.c Perhaps a coccinelle script? Two questions for Julia Lawall: o is ther

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-22 Thread Joe Perches
On Sun, 2017-01-22 at 22:43 -0800, Joe Perches wrote: > Two questions for Julia Lawall: > > o is there a better way to do this than repeat the blocks > one for each replacement > o can struct device * dev be made an arbitrary identifier > > $ cat dev_printk.cocci > @@ > identifier fn; > type T;

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-22 Thread Joe Perches
On Sat, 2017-01-21 at 11:20 -0800, Florian Fainelli wrote: > We have a device reference, utilize it instead of pr_warn(). There is at least one more hwmon to convert in applesmc.c Perhaps a coccinelle script? Two questions for Julia Lawall: o is there a better way to do this than repeat the blo

Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-21 Thread Guenter Roeck
On 01/21/2017 11:20 AM, Florian Fainelli wrote: We have a device reference, utilize it instead of pr_warn(). Signed-off-by: Florian Fainelli --- Applied to -next. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vg

[PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

2017-01-21 Thread Florian Fainelli
We have a device reference, utilize it instead of pr_warn(). Signed-off-by: Florian Fainelli --- drivers/hwmon/lm70.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c index d6ecd1a4be59..52c5cdd00448 100644 --- a/drivers/hwmon/lm70