Re: [PATCH] nvmem: fix nvmem_cell_get_from_lookup()

2018-10-02 Thread Bartosz Golaszewski
wt., 2 paź 2018 o 11:42 Bartosz Golaszewski napisał(a): > > From: Bartosz Golaszewski > > We check if the pointer returned by __nvmem_device_get() is not NULL > while we should actually check if it is not IS_ERR(nvmem). Fix it. > > While we're at it: fix the next error path where we should assign

[PATCH] nvmem: fix nvmem_cell_get_from_lookup()

2018-10-02 Thread Bartosz Golaszewski
From: Bartosz Golaszewski We check if the pointer returned by __nvmem_device_get() is not NULL while we should actually check if it is not IS_ERR(nvmem). Fix it. While we're at it: fix the next error path where we should assign an error value to cell before returning. Signed-off-by: Bartosz Gol

Re: [PATCH] nvmem: fix nvmem_cell_get_from_lookup()

2018-10-01 Thread Bartosz Golaszewski
pon., 1 paź 2018 o 18:03 David Lechner napisał(a): > > On 10/01/2018 05:00 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > We check if the pointer returned by __nvmem_device_get() is not NULL > > while we should actually check if it is not IS_ERR(nvmem). Fix it. > > > > While

Re: [PATCH] nvmem: fix nvmem_cell_get_from_lookup()

2018-10-01 Thread David Lechner
On 10/01/2018 05:00 AM, Bartosz Golaszewski wrote: From: Bartosz Golaszewski We check if the pointer returned by __nvmem_device_get() is not NULL while we should actually check if it is not IS_ERR(nvmem). Fix it. While we're at it: fix the next error path where we should assign an error value

[PATCH] nvmem: fix nvmem_cell_get_from_lookup()

2018-10-01 Thread Bartosz Golaszewski
From: Bartosz Golaszewski We check if the pointer returned by __nvmem_device_get() is not NULL while we should actually check if it is not IS_ERR(nvmem). Fix it. While we're at it: fix the next error path where we should assign an error value to cell before returning. Signed-off-by: Bartosz Gol