Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-12-04 Thread Boris Brezillon
On Tue, 4 Dec 2018 00:34:20 + vitor wrote: > >>> What I call a slave controller would be something that lets you reply to > >>> SDR/DDR transactions or fill a generic regmap that would be exposed to > >>> other masters on the bus. This way we could implement generic slave > >>> drivers in L

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-12-03 Thread vitor
Hi Boris, Sorry for the delayed response. On 27/11/18 12:33, Boris Brezillon wrote: Hi Vitor, On Tue, 27 Nov 2018 11:50:53 + vitor wrote: Sorry for that and don't take me wrong... maybe I should rise this question early but this only came up now when I started splitting and thinking

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-27 Thread Boris Brezillon
Hi Vitor, On Tue, 27 Nov 2018 11:50:53 + vitor wrote: > Hi Boris > > On 26/11/18 21:33, Boris Brezillon wrote: > > On Mon, 26 Nov 2018 20:11:39 + > > vitor wrote: > > > > Look at the bus discovery mechanism, the notion of DCR (close to the > > concept of USB class), or the fact that ea

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-27 Thread vitor
Hi Boris On 26/11/18 21:33, Boris Brezillon wrote: On Mon, 26 Nov 2018 20:11:39 + vitor wrote: Look at the bus discovery mechanism, the notion of DCR (close to the concept of USB class), or the fact that each dev has a unique manufacturer+PID pair (which resemble the product/vendor ID conc

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread Boris Brezillon
On Mon, 26 Nov 2018 20:11:39 + vitor wrote: > >>> I prefer that we keep the driver as is until we actually need to split > >>> things up. > >> This is already done and will benefit everyone: > >> > >>     - for me is better do it now than the secondary master and slave > >> development.

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread vitor
On 26/11/18 18:56, Boris Brezillon wrote: On Mon, 26 Nov 2018 18:33:37 + vitor wrote: On 26/11/18 12:35, Boris Brezillon wrote: On Mon, 26 Nov 2018 12:06:24 + vitor wrote: Hi Boris, On 23/11/18 12:50, Boris Brezillon wrote: On Fri, 23 Nov 2018 12:39:31 + vitor wrote:

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread Boris Brezillon
On Mon, 26 Nov 2018 19:28:02 + vitor wrote: > On 26/11/18 19:08, Boris Brezillon wrote: > > On Mon, 26 Nov 2018 19:56:18 +0100 > > Boris Brezillon wrote: > > > >>>     - for the others it will easy the SoC integration avoiding > >>> duplicated work and doing things from scratch. > >

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread vitor
On 26/11/18 19:08, Boris Brezillon wrote: On Mon, 26 Nov 2018 19:56:18 +0100 Boris Brezillon wrote:     - for the others it will easy the SoC integration avoiding duplicated work and doing things from scratch. What would be duplicated? You want to support a new SoC, just add a new entry

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread Boris Brezillon
On Mon, 26 Nov 2018 19:56:18 +0100 Boris Brezillon wrote: > > > >     - for the others it will easy the SoC integration avoiding > > duplicated work and doing things from scratch. > > What would be duplicated? You want to support a new SoC, just add a new > entry in the of_match_table and

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread Boris Brezillon
On Mon, 26 Nov 2018 18:33:37 + vitor wrote: > On 26/11/18 12:35, Boris Brezillon wrote: > > On Mon, 26 Nov 2018 12:06:24 + > > vitor wrote: > > > >> Hi Boris, > >> > >> > >> On 23/11/18 12:50, Boris Brezillon wrote: > >>> On Fri, 23 Nov 2018 12:39:31 + > >>> vitor wrote: > >>>

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread vitor
On 26/11/18 12:35, Boris Brezillon wrote: On Mon, 26 Nov 2018 12:06:24 + vitor wrote: Hi Boris, On 23/11/18 12:50, Boris Brezillon wrote: On Fri, 23 Nov 2018 12:39:31 + vitor wrote: Hi Boris, On 22/11/18 20:02, Boris Brezillon wrote: On Thu, 22 Nov 2018 17:54:54 + Vito

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread Boris Brezillon
On Mon, 26 Nov 2018 12:06:24 + vitor wrote: > Hi Boris, > > > On 23/11/18 12:50, Boris Brezillon wrote: > > On Fri, 23 Nov 2018 12:39:31 + > > vitor wrote: > > > >> Hi Boris, > >> > >> > >> On 22/11/18 20:02, Boris Brezillon wrote: > >>> On Thu, 22 Nov 2018 17:54:54 + > >>> Vit

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-26 Thread vitor
Hi Boris, On 23/11/18 12:50, Boris Brezillon wrote: On Fri, 23 Nov 2018 12:39:31 + vitor wrote: Hi Boris, On 22/11/18 20:02, Boris Brezillon wrote: On Thu, 22 Nov 2018 17:54:54 + Vitor Soares wrote: From: Vitor Soares This patch slipts dw-i3c-master.c into three pieces:

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-23 Thread Boris Brezillon
On Fri, 23 Nov 2018 12:39:31 + vitor wrote: > Hi Boris, > > > On 22/11/18 20:02, Boris Brezillon wrote: > > On Thu, 22 Nov 2018 17:54:54 + > > Vitor Soares wrote: > > > >> From: Vitor Soares > >> > >> This patch slipts dw-i3c-master.c into three pieces: > >>dw-i3c-master.c - con

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-23 Thread vitor
Hi Boris, On 22/11/18 20:02, Boris Brezillon wrote: On Thu, 22 Nov 2018 17:54:54 + Vitor Soares wrote: From: Vitor Soares This patch slipts dw-i3c-master.c into three pieces: dw-i3c-master.c - contains the code that interacts directly with the core in master mode.

Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-22 Thread Boris Brezillon
On Thu, 22 Nov 2018 17:54:54 + Vitor Soares wrote: > From: Vitor Soares > > This patch slipts dw-i3c-master.c into three pieces: > dw-i3c-master.c - contains the code that interacts directly with the > core in master mode. > > dw-i3c-platdrv.c - contains the code specific

[PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts

2018-11-22 Thread Vitor Soares
From: Vitor Soares This patch slipts dw-i3c-master.c into three pieces: dw-i3c-master.c - contains the code that interacts directly with the core in master mode. dw-i3c-platdrv.c - contains the code specific to the platform driver. dw-i3c-core.h - contains the de