Re: [PATCH] Documentation/sphinx more portable version check

2016-12-23 Thread Markus Heiser
Am 19.12.2016 um 11:25 schrieb Jani Nikula : > On Mon, 19 Dec 2016, Mauro Carvalho Chehab wrote: >> It could be interesting to print some error message if someone tries >> to build with an older version or if the version can't be detected, >> asking the user to upgrade Sphinx. > > This will do

Re: [PATCH] Documentation/sphinx more portable version check

2016-12-19 Thread Jani Nikula
On Mon, 19 Dec 2016, Mauro Carvalho Chehab wrote: > It could be interesting to print some error message if someone tries > to build with an older version or if the version can't be detected, > asking the user to upgrade Sphinx. This will do it. BR, Jani. diff --git a/Documentation/conf.py b/Do

Re: [PATCH] Documentation/sphinx more portable version check

2016-12-19 Thread Mauro Carvalho Chehab
Em Mon, 19 Dec 2016 11:44:57 +0200 Jani Nikula escreveu: > On Fri, 16 Dec 2016, Robert Bragg wrote: > > The sphinx.__version__ string doesn't always include a patch version and > > so the previous tuple decomposition failed with to few elements. > > > > Since I hit the case with no patch version

Re: [PATCH] Documentation/sphinx more portable version check

2016-12-19 Thread Jani Nikula
On Fri, 16 Dec 2016, Robert Bragg wrote: > The sphinx.__version__ string doesn't always include a patch version and > so the previous tuple decomposition failed with to few elements. > > Since I hit the case with no patch version ("1.5"), I guess it's > possible a major release might elide the min

[PATCH] Documentation/sphinx more portable version check

2016-12-16 Thread Robert Bragg
The sphinx.__version__ string doesn't always include a patch version and so the previous tuple decomposition failed with to few elements. Since I hit the case with no patch version ("1.5"), I guess it's possible a major release might elide the minor version. Although there's an alternative sphinx