Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-07 Thread Jani Nikula
On Fri, 04 Jan 2019, Bart Van Assche wrote: > Regarding users having their own version of .dir-locals.el: why do you > think anyone would want to do that? Err, .dir-locals.el is not only for a project to enforce local variables on emacs users, it's also for the users to set local variables for th

Re: [PATCH] Documentation/CodingStyle: Use directory-local variables for emacs

2019-01-05 Thread Bart Van Assche
On 1/5/19 11:58 AM, Alison Chaiken wrote: On 2019-01-04 14:39, Bart Van Assche wrote: As a general comment, I personally think that it worth to mention the fact that the user can take this code (actually part of it) and put it in a .dir- locals.el file in the top-level directory. I'm not sur

Re: [PATCH] Documentation/CodingStyle: Use directory-local variables for emacs

2019-01-05 Thread Alison Chaiken
On 2019-01-04 14:39, Bart Van Assche wrote: As a general comment, I personally think that it worth to mention the fact that the user can take this code (actually part of it) and put it in a .dir- locals.el file in the top-level directory. I'm not sure we should recommend this. Settings in ~/.

Re: [PATCH] Documentation/CodingStyle: Use directory-local variables for emacs

2019-01-04 Thread Bart Van Assche
On Fri, 2019-01-04 at 23:10 +0100, Federico Vaga wrote: > On Friday, January 4, 2019 10:08:33 PM CET Bart Van Assche wrote: > > In emacs 23.1 support for directory-local variables was added (see also > > https://lists.gnu.org/archive/html/info-gnu-emacs/2009-07/msg0.html). > > Simplify the sett

Re: [PATCH] Documentation/CodingStyle: Use directory-local variables for emacs

2019-01-04 Thread Federico Vaga
On Friday, January 4, 2019 10:08:33 PM CET Bart Van Assche wrote: > In emacs 23.1 support for directory-local variables was added (see also > https://lists.gnu.org/archive/html/info-gnu-emacs/2009-07/msg0.html). > Simplify the settings in coding-style.rst by using that feature. > Additionally,

Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-04 Thread Bart Van Assche
On Fri, 2019-01-04 at 13:08 -0800, Bart Van Assche wrote: > For new kernel developers who use emacs it is tedious to follow the > instructions in Documentation/process/coding-style.rst for configuring > [ ... ] Please ignore this patch - this is the old version (v1). The other patch, the one this

[PATCH] Documentation/CodingStyle: Use directory-local variables for emacs

2019-01-04 Thread Bart Van Assche
In emacs 23.1 support for directory-local variables was added (see also https://lists.gnu.org/archive/html/info-gnu-emacs/2009-07/msg0.html). Simplify the settings in coding-style.rst by using that feature. Additionally, do not inherit any settings from emacs' linux coding style to minimize dep

[PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-04 Thread Bart Van Assche
For new kernel developers who use emacs it is tedious to follow the instructions in Documentation/process/coding-style.rst for configuring emacs. Make it easier for emacs users by moving these settings into the top-level .dir-locals.el file. Emacs supports directory-local variables since version 23

Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-04 Thread Joe Perches
On Fri, 2019-01-04 at 09:41 -0700, Jonathan Corbet wrote: > On Fri, 04 Jan 2019 08:32:38 -0800 > Bart Van Assche wrote: > > > Isn't it better if we collect such configuration files into a dedicated > > > directory (where exactly?) instead of putting them in the top-level one? > > > Then, > > >

Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-04 Thread Jonathan Corbet
On Fri, 04 Jan 2019 08:32:38 -0800 Bart Van Assche wrote: > > Isn't it better if we collect such configuration files into a dedicated > > directory (where exactly?) instead of putting them in the top-level one? > > Then, > > the developer has to copy/link the configuration file into the top-le

Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-04 Thread Bart Van Assche
On Fri, 2019-01-04 at 13:18 +0200, Jani Nikula wrote: > Also, you probably do not wish the file to change when you switch > branches with different upstream baselines. Or deal with possible emacs > version dependent changes. I do like having the example in the kernel > tree, but let the users deal

Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-04 Thread Bart Van Assche
On Fri, 2019-01-04 at 10:44 +0100, Federico Vaga wrote: > On Friday, January 4, 2019 1:39:57 AM CET Bart Van Assche wrote: > > For new kernel developers who use emacs it is tedious to follow the > > instructions in Documentation/process/coding-style.rst for configuring > > emacs. Make it easier for

Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-04 Thread Bart Van Assche
On Thu, 2019-01-03 at 18:12 -0800, Matthew Wilcox wrote: > On Thu, Jan 03, 2019 at 04:39:57PM -0800, Bart Van Assche wrote: > > @@ -571,50 +571,11 @@ item, explaining its use. > > 9) You've made a mess of it > > --- > > > > -That's OK, we all do. You've probably been to

Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-04 Thread Jani Nikula
On Fri, 04 Jan 2019, Federico Vaga wrote: > Isn't it better if we collect such configuration files into a > dedicated directory (where exactly?) instead of putting them in the > top-level one? Then, the developer has to copy/link the configuration > file into the top-level directory. > > If we acc

Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-04 Thread Federico Vaga
On Friday, January 4, 2019 1:39:57 AM CET Bart Van Assche wrote: > For new kernel developers who use emacs it is tedious to follow the > instructions in Documentation/process/coding-style.rst for configuring > emacs. Make it easier for emacs users by moving these settings into the > top-level .dir-

Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-03 Thread Matthew Wilcox
On Thu, Jan 03, 2019 at 04:39:57PM -0800, Bart Van Assche wrote: > @@ -571,50 +571,11 @@ item, explaining its use. > 9) You've made a mess of it > --- > > -That's OK, we all do. You've probably been told by your long-time Unix > -user helper that ``GNU emacs`` automatic

[PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

2019-01-03 Thread Bart Van Assche
For new kernel developers who use emacs it is tedious to follow the instructions in Documentation/process/coding-style.rst for configuring emacs. Make it easier for emacs users by moving these settings into the top-level .dir-locals.el file. Emacs supports directory-local variables since version 23

Re: [PATCH] Documentation/CodingStyle: Add an example for braces

2018-03-15 Thread Gary R Hook
On 03/15/2018 05:26 AM, Jani Nikula wrote: On Wed, 14 Mar 2018, Gary R Hook wrote: Add another example of required braces when using a compound statement in a loop. Signed-off-by: Gary R Hook --- Documentation/process/coding-style.rst |9 + 1 file changed, 9 insertions(+) diff

Re: [PATCH] Documentation/CodingStyle: Add an example for braces

2018-03-15 Thread Jani Nikula
On Wed, 14 Mar 2018, Gary R Hook wrote: > Add another example of required braces when using a compound statement in > a loop. > > Signed-off-by: Gary R Hook > --- > Documentation/process/coding-style.rst |9 + > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/process/c

[PATCH] Documentation/CodingStyle: Add an example for braces

2018-03-14 Thread Gary R Hook
Add another example of required braces when using a compound statement in a loop. Signed-off-by: Gary R Hook --- Documentation/process/coding-style.rst |9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst

Re: [PATCH] Documentation/CodingStyle

2016-09-06 Thread Jonathan Corbet
On Sat, 3 Sep 2016 08:13:13 +0200 Bruno Raoult wrote: > I am new here, so feel free to tell me if I am wrong. Welcome! > I am participating to Eulyptula challenge, and of course had a look on > Documentation/CodingStyle. > > As I use GNU/Emacs (yes, I know, Evil Tool, according to Linus :-), I

[PATCH] Documentation/CodingStyle

2016-09-02 Thread Bruno Raoult
Hi all, I am new here, so feel free to tell me if I am wrong. I am participating to Eulyptula challenge, and of course had a look on Documentation/CodingStyle. As I use GNU/Emacs (yes, I know, Evil Tool, according to Linus :-), I took the lines in Chapter 9, which are supposed to switch to kerne