Re: [PATCH] CodingStyle: Clarify and complete chapter 7

2016-08-14 Thread Jonathan Corbet
On Sun, 14 Aug 2016 13:12:33 -0700 Mark D Rustad wrote: > >> + err: > >>kfree(foo->bar); > >>kfree(foo); > >>return ret; > >> > >> The bug in this code is that on some exit paths "foo" is NULL. Normally > >> the > > > > ...except that kfree() can handle

Re: [PATCH] CodingStyle: Clarify and complete chapter 7

2016-08-14 Thread Mark D Rustad
Jonathan Corbet wrote: On Mon, 25 Jul 2016 14:29:06 +0200 Jean Delvare wrote: Chapter 7 (Centralized exiting of functions) of the coding style documentation is unclear at times, and lacks some information (such as the possibility to indent labels with a single space.) Clarify and complete it

Re: [PATCH] CodingStyle: Clarify and complete chapter 7

2016-08-14 Thread Jonathan Corbet
On Mon, 25 Jul 2016 14:29:06 +0200 Jean Delvare wrote: > Chapter 7 (Centralized exiting of functions) of the coding style > documentation is unclear at times, and lacks some information (such > as the possibility to indent labels with a single space.) Clarify and > complete it. OK, I've applied

[PATCH] CodingStyle: Clarify and complete chapter 7

2016-07-25 Thread Jean Delvare
Chapter 7 (Centralized exiting of functions) of the coding style documentation is unclear at times, and lacks some information (such as the possibility to indent labels with a single space.) Clarify and complete it. Signed-off-by: Jean Delvare Cc: Markus Elfring Cc: Jonathan Corbet --- Documen