Re: [PATCH] Add short author date to Fixes tag

2025-01-13 Thread Mark Brown
On Mon, Jan 13, 2025 at 09:51:01AM -0500, Steven Rostedt wrote: > Geert Uytterhoeven wrote: > > $ git help fixes > > 'fixes' is aliased to 'show --format='Fixes: %h ("%s")' -s' > Hmm, I've just been manually adding the Fixes tags ;-) That's because when > I add a fixes tag, I also do a more in d

Re: [PATCH] Add short author date to Fixes tag

2025-01-13 Thread Steven Rostedt
On Sun, 12 Jan 2025 11:54:21 +0100 Geert Uytterhoeven wrote: > FTR, while I do not support adding dates to Fixes-tags, I would just > need to make a small modification to my fixes alias: > > $ git help fixes > 'fixes' is aliased to 'show --format='Fixes: %h ("%s")' -s' Hmm, I've just been manua

Re: [PATCH] Add short author date to Fixes tag

2025-01-12 Thread Geert Uytterhoeven
Hi Steven, On Sat, Jan 11, 2025 at 6:08 PM Steven Rostedt wrote: > On Fri, 10 Jan 2025 16:21:35 -0800 > Jacob Keller wrote: > > > I personally find the date helpful as it can help place a commit without > > needing to take the extra time to do a lookup. > > I've never found dates to be meaningfu

Re: [PATCH] Add short author date to Fixes tag

2025-01-11 Thread Steven Rostedt
On Fri, 10 Jan 2025 16:21:35 -0800 Jacob Keller wrote: > I personally find the date helpful as it can help place a commit without > needing to take the extra time to do a lookup. I've never found dates to be meaningful. I'm always more concerned about when a commit was added to mainline. Thus th

Re: [PATCH] Add short author date to Fixes tag

2025-01-10 Thread Greg Kroah-Hartman
On Fri, Jan 10, 2025 at 04:21:35PM -0800, Jacob Keller wrote: > However, all of the existing tooling we have for the kernel does not > support the date, and I think its not worth trying to change it at this > point. It doesn't make sense to break all this tooling for information > which is accessib

Re: [PATCH] Add short author date to Fixes tag

2025-01-10 Thread Jacob Keller
On 1/10/2025 5:03 AM, Steven Rostedt wrote: > On Fri, 10 Jan 2025 12:20:09 + > yek...@red54.com wrote: > >> The old Fixes tag style is at least 10 years old. It lacks date >> information, which can lead to misjudgment. So I added short author date >> to avoid this. This make it clear at a g

Re: [PATCH] Add short author date to Fixes tag

2025-01-10 Thread Steven Rostedt
On Fri, 10 Jan 2025 12:20:09 + yek...@red54.com wrote: > The old Fixes tag style is at least 10 years old. It lacks date > information, which can lead to misjudgment. So I added short author date > to avoid this. This make it clear at a glance and reduce > misunderstandings. How can it lead t

Re: [PATCH] Add short author date to Fixes tag

2025-01-10 Thread Greg Kroah-Hartman
On Fri, Jan 10, 2025 at 12:20:09PM +, yek...@red54.com wrote: > From: 谢致邦 (XIE Zhibang) > > The old Fixes tag style is at least 10 years old. It lacks date > information, which can lead to misjudgment. So I added short author date > to avoid this. This make it clear at a glance and reduce > m

[PATCH] Add short author date to Fixes tag

2025-01-10 Thread Yeking
From: 谢致邦 (XIE Zhibang) The old Fixes tag style is at least 10 years old. It lacks date information, which can lead to misjudgment. So I added short author date to avoid this. This make it clear at a glance and reduce misunderstandings. For example: Old Fixes tag style: * Fixes: fd3040b9394c ("