Re: [PATCH] Add a target to check broken external links in the Documentation

2017-02-14 Thread Jonathan Corbet
On Tue, 14 Feb 2017 15:22:12 +0100 Remy Leone wrote: > I got another question. There is a lot of broken links. Should I do a big > commit to fix all of them at once? What would be the best workflow to fix > all those errors? I'd suggest starting small, since you're just getting going with all th

Re: [PATCH] Add a target to check broken external links in the Documentation

2017-02-14 Thread Jani Nikula
On Tue, 14 Feb 2017, Jonathan Corbet wrote: > On Tue, 14 Feb 2017 15:52:10 +0200 > Jani Nikula wrote: > >> On Tue, 14 Feb 2017, Remy Leone wrote: >> > I've got a question, when I receive review on a patch, is it better to >> > resubmit or to reply inside the same thread? >> >> Depends on the

Re: [PATCH] Add a target to check broken external links in the Documentation

2017-02-14 Thread Remy Leone
I got another question. There is a lot of broken links. Should I do a big commit to fix all of them at once? What would be the best workflow to fix all those errors? Best regards Rémy Le 14/02/2017 à 15:15, Jonathan Corbet a écrit : On Tue, 14 Feb 2017 15:52:10 +0200 Jani Nikula wrote: On

Re: [PATCH] Add a target to check broken external links in the Documentation

2017-02-14 Thread Jonathan Corbet
On Tue, 14 Feb 2017 15:52:10 +0200 Jani Nikula wrote: > On Tue, 14 Feb 2017, Remy Leone wrote: > > I've got a question, when I receive review on a patch, is it better to > > resubmit or to reply inside the same thread? > > Depends on the subsystem, maintainer, and the phase of the Moon. ;) >

Re: [PATCH] Add a target to check broken external links in the Documentation

2017-02-14 Thread Jani Nikula
On Tue, 14 Feb 2017, Remy Leone wrote: > I've got a question, when I receive review on a patch, is it better to > resubmit or to reply inside the same thread? Depends on the subsystem, maintainer, and the phase of the Moon. ;) I'm not the documentation maintainer, but personally I prefer sendin

Re: [PATCH] Add a target to check broken external links in the Documentation

2017-02-14 Thread Remy Leone
Hello Thanks for the quick answer. Le 14/02/2017 à 13:28, Jani Nikula a écrit : Hi Remy, I like what this does, and it'll be helpful in ensuring we don't have broken links. However, there are some issues. It's my first Linux kernel patch so this was expected :) Documentation/DocBook/Makefi

Re: [PATCH] Add a target to check broken external links in the Documentation

2017-02-14 Thread Jani Nikula
Hi Remy, I like what this does, and it'll be helpful in ensuring we don't have broken links. However, there are some issues. On Tue, 14 Feb 2017, Remy Leone wrote: > From: Rémy Léone This area here is for the commit message, describing what linkcheck does, why you think it's a good idea, and t

[PATCH] Add a target to check broken external links in the Documentation

2017-02-14 Thread Remy Leone
From: Rémy Léone Signed-off-by: Rémy Léone --- Documentation/Makefile.sphinx | 3 +++ Documentation/conf.py | 2 +- Makefile | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/Makefile.sphinx b/Documentation/Makefile.sphinx index 70