Re: [PATCH v5 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-07-16 Thread bsegall
Dave Chiluk writes: > It has been observed, that highly-threaded, non-cpu-bound applications > running under cpu.cfs_quota_us constraints can hit a high percentage of > periods throttled while simultaneously not consuming the allocated > amount of quota. This use case is typical of user-interacti

Re: [PATCH v5 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-07-12 Thread bsegall
Dave Chiluk writes: > So I spent some more time testing this new patch as is *(interrupts > disabled). I know I probably should have fixed the patch, but it's hard to > get time on big test hardware sometimes, and I was already well along my way > with testing. > > In regards to the quota usa

Re: [PATCH v5 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-07-12 Thread bsegall
Dave Chiluk writes: > So I spent some more time testing this new patch as is *(interrupts > disabled). I know I probably should have fixed the patch, but it's hard to > get time on big test hardware sometimes, and I was already well along my way > with testing. > > In regards to the quota usa

Re: [PATCH v5 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-07-11 Thread bsegall
Peter Zijlstra writes: > FWIW, good to see progress, still waiting for you guys to agree :-) > > On Mon, Jul 01, 2019 at 01:15:44PM -0700, bseg...@google.com wrote: > >> - Taking up-to-every rq->lock is bad and expensive and 5ms may be too >> short a delay for this. I haven't tried microbenchma

Re: [PATCH v5 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-07-01 Thread bsegall
Alright, this prototype of "maybe we should just 100% avoid stranding runtime for a full period" appears to fix the fibtest synthetic example, and seems like a theoretically-reasonable approach. Things that may want improvement or at least thought (but it's a holiday week in the US and I wanted an

Re: [PATCH v3 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-05-30 Thread bsegall
Dave Chiluk writes: > On Wed, May 29, 2019 at 02:05:55PM -0700, bseg...@google.com wrote: >> Dave Chiluk writes: >> >> Yeah, having run the test, stranding only 1 ms per cpu rather than 5 >> doesn't help if you only have 10 ms of quota and even 10 threads/cpus. >> The slack timer isn't important

Re: [PATCH v3 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-05-29 Thread bsegall
Dave Chiluk writes: > It has been observed, that highly-threaded, non-cpu-bound applications > running under cpu.cfs_quota_us constraints can hit a high percentage of > periods throttled while simultaneously not consuming the allocated > amount of quota. This use case is typical of user-interact

Re: [PATCH v3 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-05-29 Thread bsegall
Dave Chiluk writes: > It has been observed, that highly-threaded, non-cpu-bound applications > running under cpu.cfs_quota_us constraints can hit a high percentage of > periods throttled while simultaneously not consuming the allocated > amount of quota. This use case is typical of user-interact