[PATCH v4 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-06 Thread Wei Fang
Update the new concurrency rules of ->host_failed. Signed-off-by: Wei Fang --- Documentation/scsi/scsi_eh.txt |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/scsi/scsi_eh.txt b/Documentation/scsi/scsi_eh.txt index 8638f61..37eca00 100644 --

[PATCH v4 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-06 Thread Wei Fang
le, just remove the decrement in scsi_eh_finish_cmd() and zero ->host_busy after the strategy handle to fix this race. This fixes the problem introduced in commit 50824d6c5657 ("[SCSI] libsas: async ata-eh"). Reviewed-by: James Bottomley Signed-off-by: Wei Fang --- Changes v1->v2: - up

Re: [PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-06 Thread Wei Fang
On 2016/6/7 11:22, Martin K. Petersen wrote: >>>>>> "Wei" == Wei Fang writes: > > Wei, > > Wei> Update the new rules of ->host_failed. > > Are you going to incorporate the amendment from James? > Yes, I'll send the patch soon.

[PATCH v3 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-02 Thread Wei Fang
le, just remove the decrement in scsi_eh_finish_cmd() and zero ->host_busy after the strategy handle to fix this race. This fixes the problem introduced in commit 50824d6c5657 ("[SCSI] libsas: async ata-eh"). Signed-off-by: Wei Fang --- Changes v1->v2: - update Documentation/scsi/scsi_eh

Re: [PATCH 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-02 Thread Wei Fang
Forgot to add changes, please ignore it. On 2016/6/2 15:54, Wei Fang wrote: > sas_ata_strategy_handler() adds the works of the ata error handler > to system_unbound_wq. This workqueue asynchronously runs work items, > so the ata error handler will be performed concurrently on different &

[PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-02 Thread Wei Fang
Update the new rules of ->host_failed. Signed-off-by: Wei Fang --- Documentation/scsi/scsi_eh.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/scsi/scsi_eh.txt b/Documentation/scsi/scsi_eh.txt index 8638f61..9702c78 100644 --- a/Documentation/s

[PATCH 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-02 Thread Wei Fang
le, just remove the decrement in scsi_eh_finish_cmd() and zero ->host_busy after the strategy handle to fix this race. This fixes the problem introduced in commit 50824d6c5657 ("[SCSI] libsas: async ata-eh"). Signed-off-by: Wei Fang --- drivers/ata/libata-eh.c |2 +- drivers/scsi/s

[PATCH 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-02 Thread Wei Fang
Update the new rules of ->host_failed. Signed-off-by: Wei Fang --- Documentation/scsi/scsi_eh.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/scsi/scsi_eh.txt b/Documentation/scsi/scsi_eh.txt index 8638f61..9702c78 100644 --- a/Documentation/s

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Wei Fang
On 2016/6/2 10:37, Wei Fang wrote: > Hi, Kevin, > > On 2016/6/1 22:36, Kevin Groeneveld wrote: >>> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of >>> ->host_failed >> >> I wonder if this could be related to >> http:

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Wei Fang
Hi, Kevin, On 2016/6/1 22:36, Kevin Groeneveld wrote: >> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of >> ->host_failed > > I wonder if this could be related to > http://www.spinics.net/lists/linux-scsi/msg86808.html? > > I never did get to the bottom of that. If I

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Wei Fang
Hi, James, On 2016/6/1 22:06, James Bottomley wrote: > On Tue, 2016-05-31 at 16:38 +0800, Wei Fang wrote: >> sas_ata_strategy_handler() adds the works of the ata error handler >> to system_unbound_wq. This workqueue asynchronously runs work items, >> so the ata error hand

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-05-31 Thread Wei Fang
Hi, Tejun, On 2016/5/31 22:33, Tejun Heo wrote: > On Tue, May 31, 2016 at 04:38:17PM +0800, Wei Fang wrote: >> sas_ata_strategy_handler() adds the works of the ata error handler >> to system_unbound_wq. This workqueue asynchronously runs work items, > > Are there more th

[PATCH v2 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-05-31 Thread Wei Fang
Update the new concurrency rules of ->host_failed. Signed-off-by: Wei Fang --- Documentation/scsi/scsi_eh.txt |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/scsi/scsi_eh.txt b/Documentation/scsi/scsi_eh.txt index 8638f61..e6d0de2 100644 --

[PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-05-31 Thread Wei Fang
This fixes the problem introduced in commit 50824d6c5657 ("[SCSI] libsas: async ata-eh"). Reviewed-by: Christoph Hellwig Signed-off-by: Wei Fang --- drivers/ata/libata-eh.c |2 +- drivers/scsi/libsas/sas_scsi_host.c |5 +++-- drivers/scsi/scsi.c |

[PATCH] Documentation: update missing index files in block/00-INDEX

2016-03-21 Thread Wei Fang
Update missing index files in block/00-INDEX. Signed-off-by: Wei Fang --- Documentation/block/00-INDEX |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/Documentation/block/00-INDEX b/Documentation/block/00-INDEX index e840b47..e55103a 100644 --- a/Documentation/block