Re: [PATCH net-next v2 01/10] net: dsa: lan9303: Fixed MDIO interface

2017-07-26 Thread Vivien Didelot
Hi Egil, Egil Hjelmeland writes: >> I'd suggest you to split up this one commit in several *atomic* and easy >> to review patches and send them separately as on thread named "net: dsa: >> lan9303: fix MDIO interface" (also note that imperative is prefered for >> subject lines, see: https://chris

Re: [PATCH net-next v2 01/10] net: dsa: lan9303: Fixed MDIO interface

2017-07-25 Thread Vivien Didelot
Hi Egil, Egil Hjelmeland writes: > Fixes after testing on actual HW: > > - lan9303_mdio_write()/_read() must multiply register number > by 4 to get offset > > - Indirect access (PMI) to phy register only work in I2C mode. In > MDIO mode phy registers must be accessed directly. Introduced >