[PATCH] docs/licensing: Clarify wording about "GPL" and "Proprietary"

2024-11-15 Thread Uwe Kleine-König
sambiguate "GPL compatible" to "GPLv2 compatible". Signed-off-by: Uwe Kleine-König --- Hello, these are the locations that I found by a quick grep. If you spot a document that needs similar updating, please tell. The change in license-rules.rst looks bigger than it actuall

Re: [PATCH v2] printf: add support for printing symbolic error codes

2019-09-16 Thread Uwe Kleine-König
On 9/16/19 3:23 PM, Rasmus Villemoes wrote: > On 16/09/2019 14.23, Uwe Kleine-König wrote: >> Hello Rasmus, >> >> On 9/9/19 10:38 PM, Rasmus Villemoes wrote: >>> It has been suggested several times to extend vsnprintf() to be able >>> to convert the numeric

Re: [PATCH v2] printf: add support for printing symbolic error codes

2019-09-16 Thread Uwe Kleine-König
#x27; > > In the cases where some common aliasing exists > (e.g. EAGAIN=EWOULDBLOCK on all platforms, EDEADLOCK=EDEADLK on most), > I've moved the more popular one (in terms of 'git grep -w Efoo | wc) > to the bottom so that one takes precedence. > > Acked-by: Uwe Klein

Re: [PATCH v2] printf: add support for printing symbolic error codes

2019-09-11 Thread Uwe Kleine-König
On 9/11/19 8:43 AM, Rasmus Villemoes wrote: > On 11/09/2019 02.15, Joe Perches wrote: >> On Tue, 2019-09-10 at 18:26 +0300, Andy Shevchenko wrote: >>> On Mon, Sep 9, 2019 at 11:39 PM Rasmus Villemoes >>> wrote: > +#define E(err) [err + BUILD_BUG_ON_ZERO(err <= 0 || err > 300)] = #err +#

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-30 Thread Uwe Kleine-König
Hello Petr, On 8/30/19 11:06 AM, Petr Mladek wrote: > On Thu 2019-08-29 19:39:45, Uwe Kleine-König wrote: >> On 8/29/19 11:09 AM, Rasmus Villemoes wrote: >>> On 29/08/2019 10.27, Juergen Gross wrote: >>>> Hmm, what about already existing format strings conatining

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-29 Thread Uwe Kleine-König
On 8/29/19 11:09 AM, Rasmus Villemoes wrote: > On 29/08/2019 10.27, Juergen Gross wrote: >> On 29.08.19 10:12, Petr Mladek wrote: >>> On Wed 2019-08-28 21:18:37, Uwe Kleine-König  wrote: >>>> >>>> I'd like to postpone the discussion about

Re: [PATCH] [RFC] tty/serial: imx: make use of format specifier %dE

2019-08-29 Thread Uwe Kleine-König
On 8/29/19 3:43 PM, Andy Shevchenko wrote: > On Thu, Aug 29, 2019 at 7:40 AM Uwe Kleine-König > wrote: >> >> I created a patch that teaches printk et al to emit a symbolic error >> name for an error valued integer[1]. With that applied >> >> dev_er

[PATCH] [RFC] tty/serial: imx: make use of format specifier %dE

2019-08-28 Thread Uwe Kleine-König
I created a patch that teaches printk et al to emit a symbolic error name for an error valued integer[1]. With that applied dev_err(&pdev->dev, "failed to get ipg clk: %dE\n", ret); emits ... failed to get ipg clk: EPROBE_DEFER if ret is -EPROBE_DEFER. Petr Mladek (i.e. one of t

[PATCH] [RFC] i2c: imx: make use of format specifier %dE

2019-08-28 Thread Uwe Kleine-König
I created a patch that teaches printk et al to emit a symbolic error name for an error valued integer[1]. With that applied dev_err(&pdev->dev, "can't enable I2C clock, ret=%dE\n", ret); emits ... can't enable I2C clock, ret=EIO if ret is -EIO. Petr Mladek (i.e. one of the print

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-28 Thread Uwe Kleine-König
On 8/28/19 1:32 PM, Petr Mladek wrote: > On Tue 2019-08-27 23:12:44, Uwe Kleine-König wrote: >> I dropped the example conversion, I think the idea should be clear now >> even without an explicit example. > > Please, do the opposite. Add conversion of few subsystems into t

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-28 Thread Uwe Kleine-König
Hello Petr, On 8/28/19 1:32 PM, Petr Mladek wrote: > On Tue 2019-08-27 23:12:44, Uwe Kleine-König wrote: >> Petr Mladek had some concerns: >>> There are ideas to make the code even more tricky to reduce >>> the size, keep it fast. >> >> I think Enrico We

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-28 Thread Uwe Kleine-König
On 8/28/19 2:59 PM, Sergey Senozhatsky wrote: > On (08/28/19 14:49), Rasmus Villemoes wrote: >> On 28/08/2019 14.02, Sergey Senozhatsky wrote: >>> On (08/28/19 14:54), Jani Nikula wrote: >>> [..] > I personally think that this feature is not worth the code, data, > and bikeshedding. >>

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-27 Thread Uwe Kleine-König
Hello Joe, On 8/27/19 11:22 PM, Joe Perches wrote: > On Tue, 2019-08-27 at 23:12 +0200, Uwe Kleine-König wrote: >> The new format specifier %dE introduced with this patch pretty-prints >> the typical negative error values. So >> >> pr_info("probing fai

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-27 Thread Uwe Kleine-König
Hello, I fat-fingered Enrico Weigelt's e-mail address. Please when you reply to my patch fix that up (i.e. drop enr...@kleine-koenig.org and weig...@kleine-koenig.org). Thanks and sorry, Uwe signature.asc Description: OpenPGP digital signature

[PATCH v2] vsprintf: introduce %dE for error constants

2019-08-27 Thread Uwe Kleine-König
'^\s*(printk|(kv?as|sn?|vs(c?n)?)printf|(kvm|dev|pr)_(emerg|alert|crit|err|warn(ing)?|notice|info|cont|devel|debug|dbg))\(.*(\(%d\)|: %d)\\n' v5.3-rc5 | wc -l 9141 I expect there are some false negatives where the match is distributed over two or more lines and so isn't found. Si

Re: [PATCH v1 1/2] vsprintf: introduce %dE for error constants

2019-08-25 Thread Uwe Kleine-König
Hello Andrew, On Sat, Aug 24, 2019 at 04:58:29PM -0700, Andrew Morton wrote: > (cc printk maintainers). Ah, I wasn't aware there is something like them. Thanks > On Sun, 25 Aug 2019 01:37:23 +0200 Uwe Kleine-König > wrote: > > > pr_info("probing failed (%dE)\n

[PATCH v1 2/2] gpiolib: print an error name instead of a plain number in error string

2019-08-24 Thread Uwe Kleine-König
This is an example that makes use of the just introduced printk format %dE that prints (e.g.) "EIO" when the matching integer is -EIO (or EIO). Signed-off-by: Uwe Kleine-König --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/g

[PATCH v1 1/2] vsprintf: introduce %dE for error constants

2019-08-24 Thread Uwe Kleine-König
pr_info("probing failed (%dE)\n", ret); expands to probing failed (EIO) if ret holds -EIO (or EIO). This introduces an array of error codes. If the error code is missing, %dE falls back to %d and so prints the plain number. Signed-off-by: Uwe Kleine-König --- Hello

Re: [PATCH v8 1/6] pwm: extend PWM framework with PWM modes

2019-02-14 Thread Uwe Kleine-König
Hello, On Wed, Feb 13, 2019 at 03:38:46PM +, claudiu.bez...@microchip.com wrote: > On 06.02.2019 10:24, Uwe Kleine-König wrote: > > On Wed, Feb 06, 2019 at 12:01:26AM +0100, Thierry Reding wrote: > >> But I really don't see the point in having consumers jump through h

Re: [PATCH v8 1/6] pwm: extend PWM framework with PWM modes

2019-02-06 Thread Uwe Kleine-König
Hello Thierry, On Wed, Feb 06, 2019 at 12:01:26AM +0100, Thierry Reding wrote: > On Mon, Jan 07, 2019 at 11:10:40PM +0100, Uwe Kleine-König wrote: > > On Mon, Jan 07, 2019 at 09:30:55AM +, claudiu.bez...@microchip.com > > wrote: > > > On 05.01.2019 23:05, Uwe Kleine

Re: [PATCH v8 1/6] pwm: extend PWM framework with PWM modes

2019-01-08 Thread Uwe Kleine-König
On Tue, Jan 08, 2019 at 09:21:34AM +, claudiu.bez...@microchip.com wrote: > Hi Uwe, > > On 08.01.2019 00:10, Uwe Kleine-König wrote: > > Hello Claudiu, > > > > On Mon, Jan 07, 2019 at 09:30:55AM +, claudiu.bez...@microchip.com > > wrote: > >> O

Re: [PATCH v8 1/6] pwm: extend PWM framework with PWM modes

2019-01-07 Thread Uwe Kleine-König
Hello Claudiu, On Mon, Jan 07, 2019 at 09:30:55AM +, claudiu.bez...@microchip.com wrote: > On 05.01.2019 23:05, Uwe Kleine-König wrote: > > On Thu, Jan 03, 2019 at 01:29:44PM +, claudiu.bez...@microchip.com > > wrote: > >> From: Claudiu Beznea > >> >

Re: [PATCH v9 14/27] pwm: jz4740: Improve algorithm of clock calculation

2019-01-05 Thread Uwe Kleine-König
Hello Paul, On Sat, Jan 05, 2019 at 06:05:38PM -0300, Paul Cercueil wrote: > On Sat, Jan 5, 2019 at 4:57 PM, Uwe Kleine-König > wrote: > > You are assuming stuff here about the parent clk which isn't guaranteed > > (AFAICT) by the clk framework: If you call clk_round_rate(

Re: [PATCH v9 13/27] pwm: jz4740: Use clocks from TCU driver

2019-01-05 Thread Uwe Kleine-König
Hello Paul, On Sat, Jan 05, 2019 at 05:52:46PM -0300, Paul Cercueil wrote: > On Sat, Jan 5, 2019 at 4:45 PM, Uwe Kleine-König > wrote: > > On Thu, Dec 27, 2018 at 07:13:05PM +0100, Paul Cercueil wrote: > > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig >

Re: [PATCH v9 12/27] pwm: jz4740: Use regmap from TCU driver

2019-01-05 Thread Uwe Kleine-König
Hello Paul, On Sat, Jan 05, 2019 at 05:46:18PM -0300, Paul Cercueil wrote: > On Sat, Jan 5, 2019 at 4:42 PM, Uwe Kleine-König > wrote: > > On Thu, Dec 27, 2018 at 07:13:04PM +0100, Paul Cercueil wrote: > > > The ingenic-timer "TCU" driver provides us with a regma

Re: [PATCH v8 1/6] pwm: extend PWM framework with PWM modes

2019-01-05 Thread Uwe Kleine-König
num pwm_polarity polarity; > + unsigned long modebit; I fail to see the upside of storing the mode as 2^mode instead of a plain enum pwm_mode. Given that struct pwm_state is visible for pwm users a plain pwm_mode would at least be more intuitive. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH v8 2/6] pwm: add PWM modes

2019-01-05 Thread Uwe Kleine-König
Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH v9 14/27] pwm: jz4740: Improve algorithm of clock calculation

2019-01-05 Thread Uwe Kleine-König
this might well return rate even if the clock could run slower than rate. Wouldn't it make sense to start iterating with rate = 0x * 1e9 / period? Otherwise you get bad configurations if rate is considerable slower than necessary. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH v9 13/27] pwm: jz4740: Use clocks from TCU driver

2019-01-05 Thread Uwe Kleine-König
config PWM_JZ4740 > tristate "Ingenic JZ47xx PWM support" > depends on MACH_INGENIC > - select REGMAP > + depends on COMMON_CLK > + select INGENIC_TIMER Did you drop REGMAP on purpose? Best regards Uwe -- Pengutronix e.K. | Uwe

Re: [PATCH v9 12/27] pwm: jz4740: Use regmap from TCU driver

2019-01-05 Thread Uwe Kleine-König
TCU_TCSR_PWM_SD, TCU_TCSR_PWM_SD); I think I already pointed that out before: abrupt mode is wrong. If .apply is called with a new set of parameters the currently running period with the old values is expected to complete before the new values take effect. Best regards Uwe -- Pengutronix e.K

Re: [PATCH v8 15/26] pwm: jz4740: Add support for the JZ4725B

2018-12-20 Thread Uwe Kleine-König
On Thu, Dec 20, 2018 at 06:39:04PM +0100, Thierry Reding wrote: > On Mon, Dec 17, 2018 at 08:53:21AM +0100, Uwe Kleine-König wrote: > > On Sun, Dec 16, 2018 at 03:18:52PM +0100, Paul Cercueil wrote: > > > Hi, > > > > > > Le ven. 14 déc. 2018 à 15

Re: [PATCH v8 15/26] pwm: jz4740: Add support for the JZ4725B

2018-12-16 Thread Uwe Kleine-König
On Sun, Dec 16, 2018 at 03:18:52PM +0100, Paul Cercueil wrote: > Hi, > > Le ven. 14 déc. 2018 à 15:26, Uwe Kleine-König > a écrit : > > Hello, > > > > On Fri, Dec 14, 2018 at 02:50:20PM +0100, Linus Walleij wrote: > > > On Thu, Dec 13, 2018 a

Re: [PATCH v8 12/26] pwm: jz4740: Allow selection of PWM channels 0 and 1

2018-12-16 Thread Uwe Kleine-König
Hello Paul, On Sun, Dec 16, 2018 at 02:36:03PM +0100, Paul Cercueil wrote: > Le jeu. 13 déc. 2018 à 21:32, Uwe Kleine-König > a écrit : > > On Thu, Dec 13, 2018 at 02:58:31PM +0100, Paul Cercueil wrote: > > > Hi, > > > > > > Le jeu. 13 déc. 2018 à

Re: [PATCH v8 15/26] pwm: jz4740: Add support for the JZ4725B

2018-12-14 Thread Uwe Kleine-König
Hello, On Fri, Dec 14, 2018 at 02:50:20PM +0100, Linus Walleij wrote: > On Thu, Dec 13, 2018 at 9:42 PM Uwe Kleine-König > wrote: > > [Adding Linus Walleij to Cc:] > > On Thu, Dec 13, 2018 at 03:03:15PM +0100, Paul Cercueil wrote: > > > Le jeu. 13 déc. 2018 à 10:24

Re: [PATCH v8 15/26] pwm: jz4740: Add support for the JZ4725B

2018-12-13 Thread Uwe Kleine-König
[Adding Linus Walleij to Cc:] Hello, On Thu, Dec 13, 2018 at 03:03:15PM +0100, Paul Cercueil wrote: > Le jeu. 13 déc. 2018 à 10:24, Uwe Kleine-König > a écrit : > > On Wed, Dec 12, 2018 at 11:09:10PM +0100, Paul Cercueil wrote: > > > The PWM in the JZ4725B works the

Re: [PATCH v8 12/26] pwm: jz4740: Allow selection of PWM channels 0 and 1

2018-12-13 Thread Uwe Kleine-König
On Thu, Dec 13, 2018 at 02:58:31PM +0100, Paul Cercueil wrote: > Hi, > > Le jeu. 13 déc. 2018 à 10:18, Uwe Kleine-König > a écrit : > > On Wed, Dec 12, 2018 at 11:09:07PM +0100, Paul Cercueil wrote: > > > The TCU channels 0 and 1 were previously reserved for system t

Re: [PATCH v8 11/26] pwm: jz4740: Use regmap and clocks from TCU driver

2018-12-13 Thread Uwe Kleine-König
; + clk_set_rate(clk, rate); Maybe this could better live in a separate patch. If you split still further to have the conversion to regmap in a single patch, then the conversion to the clk_* functions and then improve the algorithm for the clk settings each of the patches is easier to r

Re: [PATCH v8 15/26] pwm: jz4740: Add support for the JZ4725B

2018-12-13 Thread Uwe Kleine-König
-- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH v8 12/26] pwm: jz4740: Allow selection of PWM channels 0 and 1

2018-12-13 Thread Uwe Kleine-König
ent_res) > + return -EINVAL; > + > jz4740->chip.dev = dev; > jz4740->chip.ops = &jz4740_pwm_ops; > jz4740->chip.npwm = NUM_PWM; Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [RESEND PATCH v5 0/9] extend PWM framework to support PWM modes

2018-10-26 Thread Uwe Kleine-König
Hello Claudiu, On Fri, Oct 26, 2018 at 10:44:43AM +, claudiu.bez...@microchip.com wrote: > Thank you for your inputs and sorry for the late response. Please see my > answers inline. No problems, I didn't held my breath :-) > On 22.10.2018 11:29, Uwe Kleine-König wrote: >

Re: [RESEND PATCH v5 0/9] extend PWM framework to support PWM modes

2018-10-22 Thread Uwe Kleine-König
displayed at read: > root@sama5d2-xplained:/sys/class/pwm/pwmchip0/pwm2# echo normal > mode > root@sama5d2-xplained:/sys/class/pwm/pwmchip0/pwm2# cat mode > [normal] complementary push-pull Getting a simple user of this into the kernel would be beneficial, too. In my discuss

Re: [RFC PATCH 1/2] Input: rotary-encoder- Add support for absolute encoder

2016-05-24 Thread Uwe Kleine-König
Hello, On Tue, May 24, 2016 at 10:39:26AM +0530, Vignesh R wrote: > On 05/23/2016 06:48 PM, Uwe Kleine-König wrote: > > On Mon, May 23, 2016 at 04:48:40PM +0530, R, Vignesh wrote: > >> On 5/22/2016 3:56 PM, Uwe Kleine-König wrote: > >>> On Thu, May 19, 2016 at 02:

Re: [RFC PATCH 1/2] Input: rotary-encoder- Add support for absolute encoder

2016-05-23 Thread Uwe Kleine-König
Hello, On Mon, May 23, 2016 at 04:48:40PM +0530, R, Vignesh wrote: > On 5/22/2016 3:56 PM, Uwe Kleine-König wrote: > > Hello, > > > > On Thu, May 19, 2016 at 02:34:00PM +0530, Vignesh R wrote: > >> There are rotary-encoders where GPIO lines reflect the actual posit

Re: [RFC PATCH 1/2] Input: rotary-encoder- Add support for absolute encoder

2016-05-22 Thread Uwe Kleine-König
} and support this with a v4 of http://thread.gmane.org/gmane.linux.kernel.input/48892 . Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To u

Re: [PATCH v7 0/9] watchdog: Add support for keepalives triggered by infrastructure

2016-01-26 Thread Uwe Kleine-König
ept as separate > patch on purpose, to enable dropping or reverting it easily if it causes > any problems. It should not cause any problems; this is just out of an > abundance of caution. Acked-by: Uwe Kleine-König for patches 1-5. Best regards Uwe -- Pengutronix e.K.

Re: [PATCH v7 4/9] watchdog: Add support for minimum time between heartbeats

2016-01-26 Thread Uwe Kleine-König
) { > + mod_delayed_work(watchdog_wq, &wd_data->work, > + earliest_keepalive - jiffies); > + return 0; > + } > + > + wd_data->last_hw_keepalive = jiffies; > + Do you need to undo this assignme