Re: [PATCH v2 6/6] module: Introduce hash-based integrity checking

2025-02-04 Thread Thomas Weißschuh
Hi Petr, On 2025-02-03 15:22:54+0100, Petr Pavlu wrote: > On 1/20/25 18:44, Thomas Weißschuh wrote: > > The current signature-based module integrity checking has some drawbacks > > in combination with reproducible builds: > > Either the module signing key is generated at bu

Re: [PATCH v2 0/6] module: Introduce hash-based integrity checking

2025-02-04 Thread Thomas Weißschuh
On 2025-02-03 14:14:41+0100, Christian Heusel wrote: > Hey Thomas, > > On 25/01/20 06:44PM, Thomas Weißschuh wrote: > > Thomas Weißschuh (6): > > kbuild: add stamp file for vmlinux BTF data > > module: Make module loading policy usable without MODULE

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Thomas Weißschuh
On 2025-01-21 15:55:28+0100, Roberto Sassu wrote: > On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: [..] > > > +typedef int (*callback)(void *callback_data, __u16 field, > > > + co

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Thomas Weißschuh
On 2025-01-21 14:48:09+0100, Roberto Sassu wrote: > On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > > Hi Robert, > > > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > > > From: Roberto Sassu > > > > > > Add a pa

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Thomas Weißschuh
Hi Robert, On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > From: Roberto Sassu > > Add a parser of a generic Type-Length-Value (TLV) format: > > +--+--+-++-+ > | field1 (u16) | len1 (u32) | value1 (u8 len1) | > +--++---

Re: [PATCH v2 0/6] module: Introduce hash-based integrity checking

2025-01-21 Thread Thomas Weißschuh
Hi Roberto, On 2025-01-21 11:26:29+0100, Roberto Sassu wrote: > On Mon, 2025-01-20 at 18:44 +0100, Thomas Weißschuh wrote: > > The current signature-based module integrity checking has some drawbacks > > in combination with reproducible builds: > > Either the module signin

[PATCH v2 6/6] module: Introduce hash-based integrity checking

2025-01-20 Thread Thomas Weißschuh
-by: Thomas Weißschuh --- .gitignore | 1 + Documentation/kbuild/reproducible-builds.rst | 5 ++- Makefile | 8 - include/asm-generic/vmlinux.lds.h| 11 ++ include/linux/module_hashes.h| 17

[PATCH v2 2/6] module: Make module loading policy usable without MODULE_SIG

2025-01-20 Thread Thomas Weißschuh
The loading policy functionality will also be used by the hash-based module validation. Split it out from CONFIG_MODULE_SIG so it is usable by both. Signed-off-by: Thomas Weißschuh --- include/linux/module.h | 8 kernel/module/Kconfig | 6 +- kernel/module/main.c| 26

[PATCH v2 4/6] module: Move lockdown check into generic module loader

2025-01-20 Thread Thomas Weißschuh
The lockdown check buried in module_sig_check() will not compose well with the introduction of hash-based module validation. Move it into module_integrity_check() which will work better. Signed-off-by: Thomas Weißschuh --- kernel/module/main.c| 6 +- kernel/module/signing.c | 3 +-- 2

[PATCH v2 0/6] module: Introduce hash-based integrity checking

2025-01-20 Thread Thomas Weißschuh
* UAPI for discovery? [0] https://lore.kernel.org/lkml/20241211-pahole-reproducible-v1-1-22feae19b...@weissschuh.net/ Signed-off-by: Thomas Weißschuh --- Changes in v2: - Drop RFC state - Mention interested parties in cover letter - Expand Kconfig description - Add compatibility with CONFIG_

[PATCH v2 3/6] module: Move integrity checks into dedicated function

2025-01-20 Thread Thomas Weißschuh
With the addition of hash-based integrity checking, the configuration matrix is easier to represent in a dedicated function and with explicit usage of IS_ENABLED(). Drop the now unnecessary stub for module_sig_check(). Signed-off-by: Thomas Weißschuh --- kernel/module/internal.h | 7

[PATCH v2 1/6] kbuild: add stamp file for vmlinux BTF data

2025-01-20 Thread Thomas Weißschuh
introducing a new target. Signed-off-by: Thomas Weißschuh --- scripts/Makefile.modfinal | 4 ++-- scripts/link-vmlinux.sh | 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.modfinal b/scripts/Makefile.modfinal index 542ba462ed3ec9607e0df10e26613a4c7ac318e8

[PATCH v2 5/6] lockdown: Make the relationship to MODULE_SIG a dependency

2025-01-20 Thread Thomas Weißschuh
The new hash-based module integrity checking will also be able to satisfy the requirements of lockdown. Such an alternative is not representable with "select", so use "depends on" instead. Signed-off-by: Thomas Weißschuh --- security/lockdown/Kconfig | 2 +- 1 file change

[PATCH] Docs: remove mentions of fdformat from util-linux

2023-12-19 Thread Thomas Weißschuh
likely to be present alternative. Also drop the reference to fdformat from the list of features of new versions of util-linux. Signed-off-by: Thomas Weißschuh --- Documentation/process/changes.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/process/changes.

Re: [PATCH 00/21] Initial cleanups for vCPU hotplug

2023-12-01 Thread Thomas Gleixner
On Fri, Dec 01 2023 at 12:28, Greg Kroah-Hartman wrote: > I can take them, will do so this weekend when I catch up on patches on a > 14+ hour flight... Thanks a lot!

Re: [PATCH 00/21] Initial cleanups for vCPU hotplug

2023-12-01 Thread Thomas Gleixner
he latter case: Reviewed-by: Thomas Gleixner Greg, Rafael? Thanks, tglx

Re: [PATCH 08/21] drivers: base: Implement weak arch_unregister_cpu()

2023-12-01 Thread Thomas Gleixner
On Tue, Nov 21 2023 at 13:44, Russell King wrote: > --- > An open question remains from the RFC v2 posting: should we provide a > __weak stub for !HOTPLUG_CPU as well, since in later patches ACPI may > reference this if the compiler doesn't optimise as we expect? You mean: extern void foo(void);

Re: [PATCH 01/21] arch_topology: Make register_cpu_capacity_sysctl() tolerant to late CPUs

2023-12-01 Thread Thomas Gleixner
On Tue, Nov 21 2023 at 13:43, Russell King wrote: > --- > If the offline CPUs thing is a problem for the tools that consume > this value, we'd need to move cpu_capacity to be part of cpu.c's > common_cpu_attr_groups. However, attempts to discuss this just end > up in a black hole, so this is a non-

Re: [PATCH 00/21] Initial cleanups for vCPU hotplug

2023-12-01 Thread Thomas Gleixner
On Tue, Nov 21 2023 at 13:43, Russell King wrote: > The majority of the other patches come from the vCPU hotplug RFC v3 > series I posted earlier, rebased on Linus' current tip, but with some > new patches adding arch_cpu_is_hotpluggable() as the remaining > arch_register_cpu() functions only diffe

Re: [PATCH v2 28/39] timekeeping: Fix a circular include dependency

2023-10-26 Thread Thomas Gleixner
On Thu, Oct 26 2023 at 18:33, Suren Baghdasaryan wrote: > On Wed, Oct 25, 2023 at 5:33 PM Thomas Gleixner wrote: >> > This avoids a circular header dependency in an upcoming patch by only >> > making hrtimer.h depend on percpu-defs.h >> >> What's the actual

Re: [PATCH v2 28/39] timekeeping: Fix a circular include dependency

2023-10-25 Thread Thomas Gleixner
On Tue, Oct 24 2023 at 06:46, Suren Baghdasaryan wrote: > From: Kent Overstreet > > This avoids a circular header dependency in an upcoming patch by only > making hrtimer.h depend on percpu-defs.h What's the actual dependency problem?

[PATCH v2] docs: submitting-patches: encourage direct notifications to commenters

2023-10-02 Thread Thomas Weißschuh
think their review got ignored or they have to dig up new versions from the archive manually. So encourage patch submitters to make sure that all commenters get notified also when no Reviewed-by was issued yet. Signed-off-by: Thomas Weißschuh --- Changes in v2: - s/reviewer/commenter/ to

Re: [PATCH] docs: submitting-patches: encourage direct notifications to reviewers

2023-10-02 Thread Thomas Weißschuh
On 2023-10-02 01:50:11-0700, Christoph Hellwig wrote: > On Mon, Oct 02, 2023 at 10:36:01AM +0300, Jani Nikula wrote: > > On Sun, 01 Oct 2023, Christoph Hellwig wrote: > > > On Fri, Sep 29, 2023 at 09:24:57AM +0200, Thomas Weißschuh wrote: > > >> > This does no

Re: [PATCH] docs: submitting-patches: encourage direct notifications to reviewers

2023-09-29 Thread Thomas Weißschuh
then that's not gonna work. Thomas

Re: [PATCH v11 35/37] x86/syscall: Split IDT syscall setup code into idt_syscall_init()

2023-09-28 Thread Thomas Gleixner
On Mon, Sep 25 2023 at 09:07, H. Peter Anvin wrote: > On September 23, 2023 2:42:10 AM PDT, Xin Li wrote: >>+/* May not be marked __init: used by software suspend */ >>+void syscall_init(void) >>+{ >>+ /* The default user and kernel segments */ >>+ wrmsr(MSR_STAR, 0, (__USER32_CS << 16) |

[PATCH] docs: submitting-patches: encourage direct notifications to reviewers

2023-09-27 Thread Thomas Weißschuh
think their review got ignored or they have to dig up new versions from the archive manually. So encourage patch submitters to make sure that all reviewers get notified also when no Reviewed-by was issued yet. Signed-off-by: Thomas Weißschuh --- Documentation/process/submitting-patches.rst | 2

RE: [PATCH v10 03/38] x86/msr: Add the WRMSRNS instruction support

2023-09-22 Thread Thomas Gleixner
On Fri, Sep 22 2023 at 08:16, Xin3 Li wrote: >> > > +static __always_inline void __wrmsrns(u32 msr, u32 low, u32 high) >> > >> > Shouldn't this be named wrmsrns_safe since it has exception handling, >> > similar >> to >> > the current wrmsrl_safe. >> > >> >> Both safe and unsafe versions have exc

Re: [PATCH v10 28/38] x86/fred: FRED entry/exit and dispatch code

2023-09-21 Thread Thomas Gleixner
On Thu, Sep 21 2023 at 12:48, Nikolay Borisov wrote: > On 14.09.23 г. 7:47 ч., Xin Li wrote: >> + >> +/* INT80 */ >> +case IA32_SYSCALL_VECTOR: >> +if (likely(IS_ENABLED(CONFIG_IA32_EMULATION))) { > > Since future kernels will support boottime toggling of whether 32bit > syscal

RE: [PATCH v10 36/38] x86/fred: Add fred_syscall_init()

2023-09-20 Thread Thomas Gleixner
On Wed, Sep 20 2023 at 04:33, Li, Xin3 wrote: >> > +static inline void fred_syscall_init(void) { >> > + /* >> > + * Per FRED spec 5.0, FRED uses the ring 3 FRED entrypoint for SYSCALL >> > + * and SYSENTER, and ERETU is the only legit instruction to return to >> > + * ring 3, as a result the

Re: [PATCH v10 36/38] x86/fred: Add fred_syscall_init()

2023-09-19 Thread Thomas Gleixner
On Wed, Sep 13 2023 at 21:48, Xin Li wrote: > +static inline void fred_syscall_init(void) > +{ > + /* > + * Per FRED spec 5.0, FRED uses the ring 3 FRED entrypoint for SYSCALL > + * and SYSENTER, and ERETU is the only legit instruction to return to > + * ring 3, as a result there

Re: [PATCH v10 08/38] x86/cpufeatures: Add the cpu feature bit for FRED

2023-09-14 Thread Thomas Gleixner
On Thu, Sep 14 2023 at 14:15, andrew wrote: > PV guests are never going to see FRED (or LKGS for that matter) because > it advertises too much stuff which simply traps because the kernel is in > CPL3. > > That said, the 64bit PV ABI is a whole lot closer to FRED than it is to > IDT delivery.  (Almo

Re: [PATCH v10 03/38] x86/msr: Add the WRMSRNS instruction support

2023-09-14 Thread Thomas Gleixner
On Fri, Sep 15 2023 at 00:46, andrew wrote: > On 15/09/2023 12:00 am, Thomas Gleixner wrote: > What I meant was "there should be the two top-level APIs, and under the > covers they DTRT".  Part of doing the right thing is to wire up paravirt > for configs where that is specif

Re: [PATCH v10 03/38] x86/msr: Add the WRMSRNS instruction support

2023-09-14 Thread Thomas Gleixner
On Fri, Sep 15 2023 at 00:46, andrew wrote: > On 15/09/2023 12:00 am, Thomas Gleixner wrote: >> So no. I'm fundamentally disagreeing with your recommendation. The way >> forward is: >> >> 1) Provide the native variant for wrmsrns(), i.e. rename the proposed >

Re: [PATCH v10 03/38] x86/msr: Add the WRMSRNS instruction support

2023-09-14 Thread Thomas Gleixner
Andrew! On Thu, Sep 14 2023 at 15:05, andrew wrote: > On 14/09/2023 5:47 am, Xin Li wrote: >> +static __always_inline void wrmsrns(u32 msr, u64 val) >> +{ >> +__wrmsrns(msr, val, val >> 32); >> +} > > This API works in terms of this series where every WRMSRNS is hidden > behind a FRED check, b

Re: [PATCH v10 4/6] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-17 Thread Thomas Bogendoerfer
On Wed, 16 Oct 2019 10:38:13 -0700 Jakub Kicinski wrote: > On Wed, 16 Oct 2019 19:23:21 +0200, Thomas Bogendoerfer wrote: > > On Tue, 15 Oct 2019 12:23:49 -0700 > > Jakub Kicinski wrote: > > > > > On Tue, 15 Oct 2019 14:09:49 +0200, Thomas Bogendoerfer wrot

[PATCH v3 1/1] drm: Add TODO item for fbdev driver conversion

2019-10-17 Thread Thomas Zimmermann
The DRM TODO list now contains an entry for converting fbdev drivers over to DRM. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/todo.rst | 27 +++ 1 file changed, 27 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index

[PATCH v3 0/1] DRM fbconv helpers for converting fbdev drivers

2019-10-17 Thread Thomas Zimmermann
ation Thomas Zimmermann (1): drm: Add TODO item for fbdev driver conversion Documentation/gpu/todo.rst | 27 +++ 1 file changed, 27 insertions(+) -- 2.23.0

Re: [PATCH v10 4/6] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-16 Thread Thomas Bogendoerfer
On Tue, 15 Oct 2019 12:23:49 -0700 Jakub Kicinski wrote: > On Tue, 15 Oct 2019 14:09:49 +0200, Thomas Bogendoerfer wrote: > > SGI IOC3 chip has integrated ethernet, keyboard and mouse interface. > > It also supports connecting a SuperIO chip for serial and parallel > > int

[PATCH v10 1/6] nvmem: core: add nvmem_device_find

2019-10-15 Thread Thomas Bogendoerfer
nvmem_device_find provides a way to search for nvmem devices with the help of a match function simlair to bus_find_device. Reviewed-by: Srinivas Kandagatla Acked-by: Srinivas Kandagatla Signed-off-by: Thomas Bogendoerfer --- Documentation/driver-api/nvmem.rst | 2 ++ drivers/nvmem/core.c

[PATCH v10 3/6] MIPS: PCI: Fix fake subdevice ID for IOC3

2019-10-15 Thread Thomas Bogendoerfer
Generation of fake subdevice ID had vendor and device ID swapped. Signed-off-by: Thomas Bogendoerfer --- arch/mips/pci/pci-xtalk-bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/pci/pci-xtalk-bridge.c b/arch/mips/pci/pci-xtalk-bridge.c index dcf6117a17c3

[PATCH v10 0/6] Use MFD framework for SGI IOC3 drivers

2019-10-15 Thread Thomas Bogendoerfer
sue in ioc3kbd.c reported by Dmitry Torokhov - merged IP27 RTC removal and 8250 serial driver addition into main MFD patch to keep patches bisectable Thomas Bogendoerfer (6): nvmem: core: add nvmem_device_find MIPS: PCI: use information from 1-wire PROM for IOC3 detection MIPS: PCI: Fix fak

[PATCH v10 6/6] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module

2019-10-15 Thread Thomas Bogendoerfer
PROM only enables ethernet PHY on first Origin 200 module, so we must do it ourselves for the second module. Signed-off-by: Thomas Bogendoerfer --- arch/mips/pci/pci-ip27.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/mips/pci/pci-ip27.c b/arch/mips/pci/pci

[PATCH v10 2/6] MIPS: PCI: use information from 1-wire PROM for IOC3 detection

2019-10-15 Thread Thomas Bogendoerfer
IOC3 chips in SGI system are conntected to a bridge ASIC, which has a 1-wire prom attached with part number information. This changeset uses this information to create PCI subsystem information, which the MFD driver uses for further platform device setup. Signed-off-by: Thomas Bogendoerfer

[PATCH v10 4/6] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-15 Thread Thomas Bogendoerfer
Jones Signed-off-by: Thomas Bogendoerfer --- arch/mips/sgi-ip27/ip27-timer.c | 20 -- drivers/mfd/Kconfig | 13 + drivers/mfd/Makefile| 1 + drivers/mfd/ioc3.c | 605 drivers/net/ethernet/sgi/Kconfig

[PATCH v10 5/6] MIPS: SGI-IP27: fix readb/writeb addressing

2019-10-15 Thread Thomas Bogendoerfer
different addresses for accesses to the SuperIO and local bus of the IOC3 chip. This is fixed by changing byte order in ioc3 and m48rtc_rtc structs. Acked-by: Alexandre Belloni Signed-off-by: Thomas Bogendoerfer --- arch/mips/include/asm/mach-ip27/mangle-port.h | 4 +-- arch/mips/include/asm/sn

Re: [PATCH v9 5/5] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module

2019-10-11 Thread Thomas Bogendoerfer
On Thu, 10 Oct 2019 19:37:15 +0300 Sergei Shtylyov wrote: > On 10/10/2019 05:59 PM, Thomas Bogendoerfer wrote: > > + /* enable ethernet PHY on IP29 systemboard */ > > + pci_read_config_dword(dev, PCI_SUBSYSTEM_VENDOR_ID, &sid); > > + if (sid ==

Re: [PATCH v9 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-11 Thread Thomas Bogendoerfer
On Thu, 10 Oct 2019 20:00:02 -0700 Jakub Kicinski wrote: > On Thu, 10 Oct 2019 16:59:49 +0200, Thomas Bogendoerfer wrote: > > dev = alloc_etherdev(sizeof(struct ioc3_private)); > > - if (!dev) { > > - err = -ENOMEM; > > - goto out_disable;

[PATCH v9 2/5] MIPS: PCI: use information from 1-wire PROM for IOC3 detection

2019-10-10 Thread Thomas Bogendoerfer
IOC3 chips in SGI system are conntected to a bridge ASIC, which has a 1-wire prom attached with part number information. This changeset uses this information to create PCI subsystem information, which the MFD driver uses for further platform device setup. Signed-off-by: Thomas Bogendoerfer

[PATCH v9 0/5] Use MFD framework for SGI IOC3 drivers

2019-10-10 Thread Thomas Bogendoerfer
al driver addition into main MFD patch to keep patches bisectable Thomas Bogendoerfer (5): nvmem: core: add nvmem_device_find MIPS: PCI: use information from 1-wire PROM for IOC3 detection mfd: ioc3: Add driver for SGI IOC3 chip MIPS: SGI-IP27: fix readb/writeb addressing MIPS: SGI-IP27: E

[PATCH v9 1/5] nvmem: core: add nvmem_device_find

2019-10-10 Thread Thomas Bogendoerfer
nvmem_device_find provides a way to search for nvmem devices with the help of a match function simlair to bus_find_device. Reviewed-by: Srinivas Kandagatla Acked-by: Srinivas Kandagatla Signed-off-by: Thomas Bogendoerfer --- Documentation/driver-api/nvmem.rst | 2 ++ drivers/nvmem/core.c

[PATCH v9 5/5] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module

2019-10-10 Thread Thomas Bogendoerfer
PROM only enables ethernet PHY on first Origin 200 module, so we must do it ourselves for the second module. Signed-off-by: Thomas Bogendoerfer --- arch/mips/pci/pci-ip27.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/mips/pci/pci-ip27.c b/arch/mips/pci/pci

[PATCH v9 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-10 Thread Thomas Bogendoerfer
Jones Signed-off-by: Thomas Bogendoerfer --- arch/mips/sgi-ip27/ip27-timer.c | 20 -- drivers/mfd/Kconfig | 13 + drivers/mfd/Makefile| 1 + drivers/mfd/ioc3.c | 605 drivers/net/ethernet/sgi/Kconfig

[PATCH v9 4/5] MIPS: SGI-IP27: fix readb/writeb addressing

2019-10-10 Thread Thomas Bogendoerfer
different addresses for accesses to the SuperIO and local bus of the IOC3 chip. This is fixed by changing byte order in ioc3 and m48rtc_rtc structs. Acked-by: Alexandre Belloni Signed-off-by: Thomas Bogendoerfer --- arch/mips/include/asm/mach-ip27/mangle-port.h | 4 +-- arch/mips/include/asm/sn

Re: [PATCH v8 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-10 Thread Thomas Bogendoerfer
On Wed, 9 Oct 2019 20:17:14 -0700 Jakub Kicinski wrote: > On Wed, 9 Oct 2019 12:17:10 +0200, Thomas Bogendoerfer wrote: > [...] > > +static int ioc3_cad_duo_setup(struct ioc3_priv_data *ipd) > > +{ > > + int ret; > > + > > + ret = ioc3_irq_domain_setup(i

[PATCH v8 1/5] nvmem: core: add nvmem_device_find

2019-10-09 Thread Thomas Bogendoerfer
nvmem_device_find provides a way to search for nvmem devices with the help of a match function simlair to bus_find_device. Reviewed-by: Srinivas Kandagatla Acked-by: Srinivas Kandagatla Signed-off-by: Thomas Bogendoerfer --- Documentation/driver-api/nvmem.rst | 2 ++ drivers/nvmem/core.c

[PATCH v8 4/5] MIPS: SGI-IP27: fix readb/writeb addressing

2019-10-09 Thread Thomas Bogendoerfer
different addresses for accesses to the SuperIO and local bus of the IOC3 chip. This is fixed by changing byte order in ioc3 and m48rtc_rtc structs. Acked-by: Alexandre Belloni Signed-off-by: Thomas Bogendoerfer --- arch/mips/include/asm/mach-ip27/mangle-port.h | 4 +-- arch/mips/include/asm/sn

[PATCH v7 0/5] Use MFD framework for SGI IOC3 drivers

2019-10-09 Thread Thomas Bogendoerfer
d by Dmitry Torokhov - merged IP27 RTC removal and 8250 serial driver addition into main MFD patch to keep patches bisectable Thomas Bogendoerfer (5): nvmem: core: add nvmem_device_find MIPS: PCI: use information from 1-wire PROM for IOC3 detection mfd: ioc3: Add driver for SGI IOC3 chip

[PATCH v8 2/5] MIPS: PCI: use information from 1-wire PROM for IOC3 detection

2019-10-09 Thread Thomas Bogendoerfer
IOC3 chips in SGI system are conntected to a bridge ASIC, which has a 1-wire prom attached with part number information. This changeset uses this information to create PCI subsystem information, which the MFD driver uses for further platform device setup. Signed-off-by: Thomas Bogendoerfer

[PATCH v8 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-09 Thread Thomas Bogendoerfer
Jones Signed-off-by: Thomas Bogendoerfer --- arch/mips/sgi-ip27/ip27-timer.c | 20 -- drivers/mfd/Kconfig | 13 + drivers/mfd/Makefile| 1 + drivers/mfd/ioc3.c | 588 drivers/net/ethernet/sgi/Kconfig

[PATCH v8 5/5] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module

2019-10-09 Thread Thomas Bogendoerfer
PROM only enables ethernet PHY on first Origin 200 module, so we must do it ourselves for the second module. Signed-off-by: Thomas Bogendoerfer --- arch/mips/pci/pci-ip27.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/mips/pci/pci-ip27.c b/arch/mips/pci/pci

Re: [PATCH v7 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-04 Thread Thomas Bogendoerfer
On Fri, 4 Oct 2019 15:44:53 +0100 Lee Jones wrote: > On Thu, 03 Oct 2019, Thomas Bogendoerfer wrote: > > + if (mask & BIT(IOC3_IRQ_ETH_DOMAIN)) > > + /* if eth irq is enabled we need to check in eth irq regs */ > > Nit: Comments should be expressive.

[PATCH v7 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-03 Thread Thomas Bogendoerfer
were implemented inside the network driver. This patchset moves out the not network related parts to a new MFD driver, which takes care of card detection, setup of platform devices and interrupt distribution for the subdevices. Serial portion: Acked-by: Greg Kroah-Hartman Signed-off-by: Thomas

[PATCH v7 0/5] Use MFD framework for SGI IOC3 drivers

2019-10-03 Thread Thomas Bogendoerfer
- merged IP27 RTC removal and 8250 serial driver addition into main MFD patch to keep patches bisectable Thomas Bogendoerfer (5): nvmem: core: add nvmem_device_find MIPS: PCI: use information from 1-wire PROM for IOC3 detection mfd: ioc3: Add driver for SGI IOC3 chip MIPS: SGI-IP27: fix

[PATCH v7 1/5] nvmem: core: add nvmem_device_find

2019-10-03 Thread Thomas Bogendoerfer
nvmem_device_find provides a way to search for nvmem devices with the help of a match function simlair to bus_find_device. Reviewed-by: Srinivas Kandagatla Acked-by: Srinivas Kandagatla Signed-off-by: Thomas Bogendoerfer --- Documentation/driver-api/nvmem.rst | 2 ++ drivers/nvmem/core.c

[PATCH v7 2/5] MIPS: PCI: use information from 1-wire PROM for IOC3 detection

2019-10-03 Thread Thomas Bogendoerfer
IOC3 chips in SGI system are conntected to a bridge ASIC, which has a 1-wire prom attached with part number information. This changeset uses this information to create PCI subsystem information, which the MFD driver uses for further platform device setup. Signed-off-by: Thomas Bogendoerfer

[PATCH v7 5/5] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module

2019-10-03 Thread Thomas Bogendoerfer
PROM only enables ethernet PHY on first Origin 200 module, so we must do it ourselves for the second module. Signed-off-by: Thomas Bogendoerfer --- arch/mips/pci/pci-ip27.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/mips/pci/pci-ip27.c b/arch/mips/pci/pci

[PATCH v7 4/5] MIPS: SGI-IP27: fix readb/writeb addressing

2019-10-03 Thread Thomas Bogendoerfer
different addresses for accesses to the SuperIO and local bus of the IOC3 chip. This is fixed by changing byte order in ioc3 and m48rtc_rtc structs. Acked-by: Alexandre Belloni Signed-off-by: Thomas Bogendoerfer --- arch/mips/include/asm/mach-ip27/mangle-port.h | 4 +-- arch/mips/include/asm/sn

Re: [PATCH v6 1/4] nvmem: core: add nvmem_device_find

2019-10-02 Thread Thomas Bogendoerfer
On Wed, 2 Oct 2019 18:33:28 + Paul Burton wrote: > Hello, > > On Tue, Oct 01, 2019 at 11:11:58AM +0100, Srinivas Kandagatla wrote: > > On 23/09/2019 12:46, Thomas Bogendoerfer wrote: > > > nvmem_device_find provides a way to search for nvmem devices with > >

[PATCH] Documentation/process: Clarify disclosure rules

2019-09-25 Thread Thomas Gleixner
developer who is not covered by an employer NDA needs to be brought in and disclosed. Explain the role of the contact list and the information policy along with an eventual conflict resolution better. Reported-by: Dave Hansen Signed-off-by: Thomas Gleixner --- Documentation/process/embargoed

[PATCH v6 1/4] nvmem: core: add nvmem_device_find

2019-09-23 Thread Thomas Bogendoerfer
nvmem_device_find provides a way to search for nvmem devices with the help of a match function simlair to bus_find_device. Signed-off-by: Thomas Bogendoerfer --- Documentation/driver-api/nvmem.rst | 2 ++ drivers/nvmem/core.c | 61 +- include

[PATCH v6 2/4] MIPS: PCI: use information from 1-wire PROM for IOC3 detection

2019-09-23 Thread Thomas Bogendoerfer
IOC3 chips in SGI system are conntected to a bridge ASIC, which has a 1-wire prom attached with part number information. This changeset uses this information to create PCI subsystem information, which the MFD driver uses for further platform device setup. Signed-off-by: Thomas Bogendoerfer

[PATCH v6 3/4] mfd: ioc3: Add driver for SGI IOC3 chip

2019-09-23 Thread Thomas Bogendoerfer
were implemented inside the network driver. This patchset moves out the not network related parts to a new MFD driver, which takes care of card detection, setup of platform devices and interrupt distribution for the subdevices. Serial portion: Acked-by: Greg Kroah-Hartman Signed-off-by: Thomas

[PATCH v6 0/4] Use MFD framework for SGI IOC3 drivers

2019-09-23 Thread Thomas Bogendoerfer
ded IP30 system board setup to MFD driver - mac address is now read from ioc3-eth driver with nvmem framework Changes in v2: - fixed issue in ioc3kbd.c reported by Dmitry Torokhov - merged IP27 RTC removal and 8250 serial driver addition into main MFD patch to keep patches bisectable Thomas B

[PATCH v6 4/4] MIPS: SGI-IP27: fix readb/writeb addressing

2019-09-23 Thread Thomas Bogendoerfer
different addresses for accesses to the SuperIO and local bus of the IOC3 chip. This is fixed by changing byte order in ioc3 and m48rtc_rtc structs. Acked-by: Alexandre Belloni Signed-off-by: Thomas Bogendoerfer --- arch/mips/include/asm/mach-ip27/mangle-port.h | 4 +-- arch/mips/include/asm/sn

Re: [PATCH 4/4] Documentation/process: add transparency promise to list subscription

2019-09-16 Thread Thomas Gleixner
gt; As I don't run the mailing list software here, I don't know how much of > a burden adding this support to it would be, so I'll defer to Thomas. > > We could just have something like "All new people need to announce > themselves" rule like many other private mail

Re: [PATCH 0/6] Address issues with SPDX requirements and PEP-263

2019-09-08 Thread Thomas Gleixner
On Sun, 8 Sep 2019, Matthew Wilcox wrote: > On Sat, Sep 07, 2019 at 11:17:22PM +0200, Thomas Gleixner wrote: > > On Sat, 7 Sep 2019, Markus Heiser wrote: > > > Am 07.09.19 um 20:04 schrieb Mauro Carvalho Chehab: > > > > No idea. I would actually prefer to just r

Re: [PATCH 0/6] Address issues with SPDX requirements and PEP-263

2019-09-07 Thread Thomas Gleixner
On Sat, 7 Sep 2019, Markus Heiser wrote: > Am 07.09.19 um 20:04 schrieb Mauro Carvalho Chehab: > > No idea. I would actually prefer to just remove the restriction, and let > > the SPDX header to be anywhere inside the first comment block inside a > > file [2]. > > > That's basically how this threa

Re: [PATCH] nvmem: core: add nvmem_device_find

2019-09-02 Thread Thomas Bogendoerfer
On Mon, Aug 26, 2019 at 03:08:28PM +0200, Thomas Bogendoerfer wrote: > nvmem_device_find provides a way to search for nvmem devices with > the help of a match function simlair to bus_find_device. > > Signed-off-by: Thomas Bogendoerfer > --- > Documentation/driver-

Re: [PATCH 4.19 72/98] x86/CPU/AMD: Clear RDRAND CPUID bit on AMD family 15h/16h

2019-08-28 Thread Thomas Gleixner
On Wed, 28 Aug 2019, Pavel Machek wrote: > On Wed 2019-08-28 14:46:21, Borislav Petkov wrote: > > On Wed, Aug 28, 2019 at 02:29:13PM +0200, Pavel Machek wrote: > > > This is not a way to have an inteligent conversation. > > > > No, this *is* the way to keep the conversation sane, without veering >

Re: [PATCH 4.19 72/98] x86/CPU/AMD: Clear RDRAND CPUID bit on AMD family 15h/16h

2019-08-28 Thread Thomas Gleixner
Pavel, On Wed, 28 Aug 2019, Pavel Machek wrote: > On Tue 2019-08-27 15:30:30, Thomas Gleixner wrote: > > There is no way to reinitialize RDRAND from the kernel otherwise we would > > have exactly done that. If you know how to do that please tell. > > Would they? AMD is not e

Re: [PATCH 4.19 72/98] x86/CPU/AMD: Clear RDRAND CPUID bit on AMD family 15h/16h

2019-08-27 Thread Thomas Gleixner
On Tue, 27 Aug 2019, Pavel Machek wrote: > On Tue 2019-08-27 09:50:51, Greg Kroah-Hartman wrote: > > From: Tom Lendacky > > > > commit c49a0a80137c7ca7d6ced4c812c9e07a949f6f24 upstream. > > > > There have been reports of RDRAND issues after resuming from suspend on > > some AMD family 15h and f

[PATCH] nvmem: core: add nvmem_device_find

2019-08-26 Thread Thomas Bogendoerfer
nvmem_device_find provides a way to search for nvmem devices with the help of a match function simlair to bus_find_device. Signed-off-by: Thomas Bogendoerfer --- Documentation/driver-api/nvmem.rst | 2 ++ drivers/nvmem/core.c | 61 +- include

Re: [PATCH v5 10/17] net: sgi: ioc3-eth: rework skb rx handling

2019-08-21 Thread Thomas Bogendoerfer
On Mon, 19 Aug 2019 16:55:22 -0700 Jakub Kicinski wrote: > On Mon, 19 Aug 2019 18:31:33 +0200, Thomas Bogendoerfer wrote: > > Buffers alloacted by alloc_skb() are already cache aligned so there > > is no need for an extra align done by ioc3_alloc_skb. And instead > > of sk

Re: [PATCH v5 11/17] net: sgi: ioc3-eth: no need to stop queue set_multicast_list

2019-08-21 Thread Thomas Bogendoerfer
On Mon, 19 Aug 2019 17:04:53 -0700 Jakub Kicinski wrote: > On Mon, 19 Aug 2019 18:31:34 +0200, Thomas Bogendoerfer wrote: > > netif_stop_queue()/netif_wake_qeue() aren't needed for changing > > multicast filters. Use spinlocks instead for proper protection > > of

Re: [PATCH v2 3/3] arm64: implement KPROBES_ON_FTRACE

2019-08-20 Thread Thomas Gleixner
On Tue, 20 Aug 2019, Jisheng Zhang wrote: > KPROBES_ON_FTRACE avoids much of the overhead with regular kprobes as it > eliminates the need for a trap, as well as the need to emulate or > single-step instructions. > > This patch implements KPROBES_ON_FTRACE for arm64. git grep 'This patch' Docum

Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set

2019-08-20 Thread Thomas Gleixner
On Tue, 20 Aug 2019, Jisheng Zhang wrote: > This is to make the x86 kprobe_ftrace_handler() more common so that > the code could be reused in future. While I agree with the change in general, I can't find anything which reuses that code. So the change log is pretty useless and I have no idea how

Re: [PATCH v5 15/17] mfd: ioc3: Add driver for SGI IOC3 chip

2019-08-20 Thread Thomas Bogendoerfer
On Tue, 20 Aug 2019 08:23:08 +0200 Alexandre Belloni wrote: > On 19/08/2019 18:31:38+0200, Thomas Bogendoerfer wrote: > > diff --git a/drivers/mfd/ioc3.c b/drivers/mfd/ioc3.c > > new file mode 100644 > > index ..5bcb3461a189 > > --- /dev/null > > +++

[PATCH v5 03/17] nvmem: core: add nvmem_device_find

2019-08-19 Thread Thomas Bogendoerfer
nvmem_device_find provides a way to search for nvmem devices with the help of a match function simlair to bus_find_device. Signed-off-by: Thomas Bogendoerfer --- Documentation/driver-api/nvmem.rst | 2 ++ drivers/nvmem/core.c | 62 -- include

[PATCH v5 04/17] MIPS: PCI: refactor ioc3 special handling

2019-08-19 Thread Thomas Bogendoerfer
Refactored code to only have one ioc3 special handling for read access and one for write access. Signed-off-by: Thomas Bogendoerfer --- arch/mips/pci/pci-xtalk-bridge.c | 167 +++ 1 file changed, 62 insertions(+), 105 deletions(-) diff --git a/arch/mips/pci

[PATCH v5 11/17] net: sgi: ioc3-eth: no need to stop queue set_multicast_list

2019-08-19 Thread Thomas Bogendoerfer
netif_stop_queue()/netif_wake_qeue() aren't needed for changing multicast filters. Use spinlocks instead for proper protection of private struct. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/sgi/ioc3-eth.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --

[PATCH v5 10/17] net: sgi: ioc3-eth: rework skb rx handling

2019-08-19 Thread Thomas Bogendoerfer
Buffers alloacted by alloc_skb() are already cache aligned so there is no need for an extra align done by ioc3_alloc_skb. And instead of skb_put/skb_trim simply use one skb_put after frame size is known during receive. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/sgi/ioc3-eth.c

[PATCH v5 09/17] net: sgi: ioc3-eth: use defines for constants dealing with desc rings

2019-08-19 Thread Thomas Bogendoerfer
Descriptor ring sizes of the IOC3 are more or less fixed size. To make clearer where there is a relation to ring sizes use defines. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/sgi/ioc3-eth.c | 42 + 1 file changed, 24 insertions(+), 18

[PATCH v5 07/17] MIPS: SGI-IP27: restructure ioc3 register access

2019-08-19 Thread Thomas Bogendoerfer
Break up the big ioc3 register struct into functional pieces to make use in sub-function drivers more straightforward. And while doing that get rid of all volatile access by using readX/writeX. Signed-off-by: Thomas Bogendoerfer --- arch/mips/include/asm/sn/ioc3.h | 359

[PATCH v5 14/17] net: sgi: ioc3-eth: Fix IPG settings

2019-08-19 Thread Thomas Bogendoerfer
The half/full duplex settings for inter packet gap counters/timer were reversed. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/sgi/ioc3-eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi

[PATCH v5 12/17] net: sgi: ioc3-eth: use dma-direct for dma allocations

2019-08-19 Thread Thomas Bogendoerfer
Replace the homegrown DMA memory allocation, which only works on SGI-IP27 machines, with the generic dma allocations. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/sgi/ioc3-eth.c | 107 ++-- 1 file changed, 77 insertions(+), 30 deletions(-) diff

[PATCH v5 05/17] MIPS: PCI: use information from 1-wire PROM for IOC3 detection

2019-08-19 Thread Thomas Bogendoerfer
IOC3 chips in SGI system are conntected to a bridge ASIC, which has a 1-wire prom attached with part number information. This changeset uses this information to create PCI subsystem information, which the MFD driver uses for further platform device setup. Signed-off-by: Thomas Bogendoerfer

[PATCH v5 13/17] net: sgi: ioc3-eth: use csum_fold

2019-08-19 Thread Thomas Bogendoerfer
replace open coded checksum folding by csum_fold. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/sgi/ioc3-eth.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c index 647e3926bd71

[PATCH v5 16/17] MIPS: SGI-IP27: fix readb/writeb addressing

2019-08-19 Thread Thomas Bogendoerfer
different addresses for accesses to the SuperIO and local bus of the IOC3 chip. This is fixed by changing byte order in ioc3 and m48rtc_rtc structs. Acked-by: Alexandre Belloni Signed-off-by: Thomas Bogendoerfer --- arch/mips/include/asm/mach-ip27/mangle-port.h | 4 +-- arch/mips/include/asm/sn

[PATCH v5 17/17] Input: add IOC3 serio driver

2019-08-19 Thread Thomas Bogendoerfer
This patch adds a platform driver for supporting keyboard and mouse interface of SGI IOC3 chips. Signed-off-by: Thomas Bogendoerfer --- drivers/input/serio/Kconfig | 10 +++ drivers/input/serio/Makefile | 1 + drivers/input/serio/ioc3kbd.c | 160

[PATCH v5 06/17] MIPS: SGI-IP27: remove ioc3 ethernet init

2019-08-19 Thread Thomas Bogendoerfer
Removed not needed disabling of ethernet interrupts in IP27 platform code. Signed-off-by: Thomas Bogendoerfer --- arch/mips/sgi-ip27/ip27-init.c | 13 - 1 file changed, 13 deletions(-) diff --git a/arch/mips/sgi-ip27/ip27-init.c b/arch/mips/sgi-ip27/ip27-init.c index 066b33f50bcc

  1   2   3   >