how to leverage it for better
> demultiplexing and visibility of parallel netconsole output.
>
> Signed-off-by: Breno Leitao
Reviewed-by: Simon Horman
ned-off-by: Breno Leitao
> Reviewed-by: Simon Horman
Hi Breno,
Unfortunately this series did not apply to net-next cleanly,
which trips up the Netdev CI. Could you rebase and repost?
Also, one minor nit below.
> ---
> drivers/net/netconsole.c | 30 --
>
On Tue, Feb 04, 2025 at 02:25:07PM +0100, Andrew Lunn wrote:
> > Thanks, perhaps something like this would help:
> >
> > Using inline in .h files is fine and is encouraged in place of macros
> > [reference section 12].
>
> The other major use of them in headers is for stub functions when an
>
On Mon, Feb 03, 2025 at 10:51:49AM -0800, Randy Dunlap wrote:
> Hi Simon,
>
> Another nit:
>
> On 2/3/25 5:59 AM, Simon Horman wrote:
> > Document preference for non inline functions in .c files.
> > This has been the preference for as long as I can recall
> >
On Mon, Feb 03, 2025 at 08:53:12PM +0100, Mauro Carvalho Chehab wrote:
> Em Mon, 3 Feb 2025 20:50:39 +0100
> Mauro Carvalho Chehab escreveu:
>
> > Em Mon, 03 Feb 2025 08:00:56 -0700
> > Jonathan Corbet escreveu:
> >
> > > Simon Horman writes:
> > >
On Mon, Feb 03, 2025 at 08:50:39PM +0100, Mauro Carvalho Chehab wrote:
> Em Mon, 03 Feb 2025 08:00:56 -0700
> Jonathan Corbet escreveu:
>
> > Simon Horman writes:
> >
> > > Document preference for non inline functions in .c files.
> > > This has been the
On Mon, Feb 03, 2025 at 04:10:24PM +0100, Andrew Lunn wrote:
> > Conversely, spelling and grammar fixes are not discouraged.
> >
> > +Inline functions
> > +
> > +
> > +The use of static inline functions in .c file is strongly discouraged
>
> I don't think 'static' is relevant he
...@orange.com/
Signed-off-by: Simon Horman
---
Documentation/process/maintainer-netdev.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/process/maintainer-netdev.rst
b/Documentation/process/maintainer-netdev.rst
index e497729525d5..1fbb8178b8cd 100644
--- a/Documentation
On Thu, Jan 30, 2025 at 09:15:38PM +, Mina Almasry wrote:
> Augment dmabuf binding to be able to handle TX. Additional to all the RX
> binding, we also create tx_vec needed for the TX path.
>
> Provide API for sendmsg to be able to send dmabufs bound to this device:
>
> - Provide a new dmabuf
On Thu, Jan 30, 2025 at 09:15:37PM +, Mina Almasry wrote:
> From: Stanislav Fomichev
>
> Add bind-tx netlink call to attach dmabuf for TX; queue is not
> required, only ifindex and dmabuf fd for attachment.
>
> Signed-off-by: Stanislav Fomichev
> Signed-off-by: Mina Almasry
Hi Mina,
I no
s helps ensure that netconsole
> accurately tracks and reports the originating CPU of messages.
>
> Signed-off-by: Breno Leitao
Reviewed-by: Simon Horman
ed to the extradata
> buffer, respecting the existing size limits.
>
> Signed-off-by: Breno Leitao
Reviewed-by: Simon Horman
against the MAX_EXTRADATA_ITEMS limit.
>
> The modification adds a simple check for the CPU_NR flag in the
> sysdata_fields, incrementing the entry count accordingly.
>
> Signed-off-by: Breno Leitao
Reviewed-by: Simon Horman
On Tue, Jan 28, 2025 at 04:12:34PM +, Simon Horman wrote:
> On Fri, Jan 24, 2025 at 07:16:43AM -0800, Breno Leitao wrote:
> > This patch introduces a bitfield to store sysdata features in the
> > netconsole_target struct. It also adds configfs helpers to enable
> >
by upcoming CPU sysdata changes.
>
> The helper uses list_count_nodes() to count the number of children in
> the userdata group configfs hierarchy.
>
> Signed-off-by: Breno Leitao
Reviewed-by: Simon Horman
t; ") is part of sysdata)
>
> Since sysdata is still not available, you will see the following in the
> send functions:
>
> extradata_len = nt->userdata_length;
>
> The upcoming patches will, which will add support for sysdata, will
> change it to:
>
> extradata_len = nt->userdata_length + sysdata_len;
>
> Signed-off-by: Breno Leitao
Reviewed-by: Simon Horman
On Tue, Jan 28, 2025 at 04:11:28PM +, Simon Horman wrote:
> On Fri, Jan 24, 2025 at 07:16:40AM -0800, Breno Leitao wrote:
> > Move the static buffers from send_msg_no_fragmentation() and
> > send_msg_fragmented() into the netconsole_target structure. This
> > s
On Fri, Jan 24, 2025 at 07:16:43AM -0800, Breno Leitao wrote:
> This patch introduces a bitfield to store sysdata features in the
> netconsole_target struct. It also adds configfs helpers to enable
> or disable the CPU_NR feature, which populates the CPU number in
> sysdata.
>
> The patch provides
On Fri, Jan 24, 2025 at 07:16:40AM -0800, Breno Leitao wrote:
> Move the static buffers from send_msg_no_fragmentation() and
> send_msg_fragmented() into the netconsole_target structure. This
> simplifies the code by:
> - Eliminating redundant static buffers
> - Centralizing buffer management in th
On Thu, Jan 09, 2025 at 05:27:14PM +, Simon Horman wrote:
> On Wed, Jan 08, 2025 at 09:47:11PM +0800, Luo Jie wrote:
> > The BM (Buffer Management) config controls the pause frame generated
> > on the PPE port. There are maximum 15 BM ports and 4 groups supported,
> > all
On Wed, Jan 08, 2025 at 09:47:15PM +0800, Luo Jie wrote:
> PPE service code is a special code (0-255) that is defined by PPE for
> PPE's packet processing stages, as per the network functions required
> for the packet.
>
> For packet being sent out by ARM cores on Ethernet ports, The service
> cod
On Wed, Jan 08, 2025 at 09:47:14PM +0800, Luo Jie wrote:
> Configure unicast and multicast hardware queues for the PPE
> ports to enable packet forwarding between the ports.
>
> Each PPE port is assigned with a range of queues. The queue ID
> selection for a packet is decided by the queue base and
On Wed, Jan 08, 2025 at 09:47:13PM +0800, Luo Jie wrote:
> The PPE scheduler settings determine the priority of scheduling the
> packet across the different hardware queues per PPE port.
>
> Signed-off-by: Luo Jie
> ---
> drivers/net/ethernet/qualcomm/ppe/ppe_config.c | 789
> ++
On Wed, Jan 08, 2025 at 09:47:11PM +0800, Luo Jie wrote:
> The BM (Buffer Management) config controls the pause frame generated
> on the PPE port. There are maximum 15 BM ports and 4 groups supported,
> all BM ports are assigned to group 0 by default. The number of hardware
> buffers configured for
On Tue, Oct 22, 2024 at 09:12:01PM -0700, Leo Stone wrote:
> Fix grammar where it improves readability.
>
> Signed-off-by: Leo Stone
Reviewed-by: Simon Horman
On Wed, Oct 09, 2024 at 11:42:14AM +0200, Przemek Kitszel wrote:
> On 10/9/24 11:12, Simon Horman wrote:
> > The purpose of this section is to document what is the current practice
> > regarding clean-up patches which address checkpatch warnings and similar
> > problems. I fee
.
Signed-off-by: Simon Horman
---
Changes in v2:
- Drop RFC designation
- Correct capitalisation of heading
- Add that:
+ devm_ conversions are also discouraged, outside the context of other work
+ Spelling and grammar fixes are not discouraged
- Reformat text accordingly
- Link to v1:
https
On Mon, Oct 07, 2024 at 09:54:12AM -0700, Jakub Kicinski wrote:
> On Mon, 7 Oct 2024 17:15:01 +0100 Simon Horman wrote:
> > > > We could merge or otherwise rearrange that section with the one
> > > > proposed by
> > > > this patch. But I
On Mon, Oct 07, 2024 at 09:08:28AM -0700, Jakub Kicinski wrote:
> On Mon, 7 Oct 2024 16:55:21 +0100 Simon Horman wrote:
> > > > +Netdev discourages patches which perform simple clean-ups, which are
> > > > not in
> > > > +the context of other work.
On Mon, Oct 07, 2024 at 08:24:30AM -0700, Jakub Kicinski wrote:
> On Fri, 04 Oct 2024 10:49:53 +0100 Simon Horman wrote:
> > The purpose of this section is to document what is the current practice
> > regarding clean-up patches which address checkpatch warnings and similar
>
.
Signed-off-by: Simon Horman
---
Documentation/process/maintainer-netdev.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/process/maintainer-netdev.rst
b/Documentation/process/maintainer-netdev.rst
index c9edf9e7362d..da9980ad0c57 100644
--- a/Documentation/process
On Tue, Sep 24, 2024 at 11:01:12AM +0200, Akihiko Odaki wrote:
> RSS is a receive steering algorithm that can be negotiated to use with
> virtio_net. Conventionally the hash calculation was done by the VMM.
> However, computing the hash after the queue was chosen defeats the
> purpose of RSS.
>
>
On Tue, Jul 30, 2024 at 04:24:23PM +0800, Liju-clr Chen wrote:
> From: Yingshiuan Pan
>
> Ioeventfd leverages eventfd to provide asynchronous notification
> mechanism for VMM. VMM can register a mmio address and bind with an
> eventfd. Once a mmio trap occurs on this registered region, its
> corr
and query dim results from a customized profile list.
>
> Signed-off-by: Heng Qi
Reviewed-by: Simon Horman
On Tue, Jun 18, 2024 at 10:56:43AM +0800, Heng Qi wrote:
> DIM-related mode and work have been collected in one same place,
> so new interfaces are added to provide convenience.
>
> Signed-off-by: Heng Qi
Reviewed-by: Simon Horman
= 256, .comps = n/a,},
> {.usec = 3, .pkts = 3, .comps = n/a,},
> {.usec = 4, .pkts = 4, .comps = n/a,},
> {.usec = 256, .pkts = 5, .comps = n/a,}
> tx-profile: n/a
>
> 3. Hint
> If the device does not support some type of customized dim profiles,
> the corresponding "n/a" will display.
>
> If the "n/a" field is being modified, -EOPNOTSUPP will be reported.
>
> Signed-off-by: Heng Qi
Reviewed-by: Simon Horman
net_dim, so
> it also needs to depend on NET.
>
> Signed-off-by: Heng Qi
Reviewed-by: Simon Horman
On Tue, Jun 18, 2024 at 10:56:40AM +0800, Heng Qi wrote:
> Useful macros will be used effectively elsewhere.
> These will be utilized in subsequent patches.
>
> Signed-off-by: Heng Qi
Reviewed-by: Simon Horman
On Wed, May 29, 2024 at 04:42:26PM +0800, Liju-clr Chen wrote:
> From: Yi-De Wu
>
> From: "Yingshiuan Pan"
nit: I think there should be at most one From line,
denoting the author of the patch. Based on the Signed-off-by
lines I assume that is Yingshiuan Pan.
If there are multipl
On Wed, May 01, 2024 at 01:31:34AM +0800, Heng Qi wrote:
...
> diff --git a/include/linux/dim.h b/include/linux/dim.h
...
> @@ -198,6 +234,32 @@ enum dim_step_result {
> DIM_ON_EDGE,
> };
>
> +/**
> + * net_dim_init_irq_moder - collect information to initialize irq moderation
> + * @de
On Thu, Dec 28, 2023 at 06:51:35PM +0800, Yi-De Wu wrote:
> From: "Yingshiuan Pan"
>
> VMM use this interface to create vcpu instance which is a fd, and this
> fd will be for any vcpu operations, such as setting vcpu registers and
> accepts the most important ioctl GZVM_VCPU_RUN which requests Ge
location in struct netns_ipv4 as suggested by Kuniyuki
> Iwashima.
>
> v2: Make it per-namesapce setting, and other updates suggested by Neal
> Cardwell,
> and Kuniyuki Iwashima.
Thanks,
this looks clean to me. It seems to address the review of v2.
And keeps the knob as syctl as discussed in v2.
Reviewed-by: Simon Horman
rnel.
> >Also this patch updates documentation for using uncompressed
> >image "Image" which is used for ARM64.
> >
> >Signed-off-by: Bharat Bhushan
> >---
> >v1->v2
> > - "a uncompressed" replaced with "an uncompressed"
>
Hi Russell,
On Thu, Apr 28, 2016 at 10:26:44AM +0100, Russell King - ARM Linux wrote:
> These changes are required for TI Keystone2 kexec to be functional. TI
> Keystone2 has the run-time view of physical memory above 4GiB, but with
> a boot time alias below 4GiB which can only be used during the
44 matches
Mail list logo
