Re: [PATCH v2 12/29] mm/zsmalloc: stop using __ClearPageMovable()

2025-07-06 Thread Sergey Senozhatsky
pages get destroyed > while they are isolated -- and instead delaying that to the > putback/migration call. Add a TODO for that. > > Reviewed-by: Harry Yoo > Reviewed-by: Lorenzo Stoakes > Signed-off-by: David Hildenbrand Reviewed-by: Sergey Senozhatsky

Re: [PATCH v1 12/29] mm/zsmalloc: stop using __ClearPageMovable()

2025-07-03 Thread Sergey Senozhatsky
On (25/07/03 09:45), David Hildenbrand wrote: > Not sure if there is real value for that; given the review status, I assume > this series won't take too long to be ready for upstream. Of course, if that > is not the case we could try pulling them out. Sounds good to me.

Re: [PATCH v1 12/29] mm/zsmalloc: stop using __ClearPageMovable()

2025-07-02 Thread Sergey Senozhatsky
On (25/07/03 11:28), Sergey Senozhatsky wrote: > > > > > >static int zs_page_migrate(struct page *newpage, struct page > > > > > > *page, > > > > > > @@ -1736,6 +1736,13 @@ static int zs_page_migrate(struct page > > > > >

Re: [PATCH v1 12/29] mm/zsmalloc: stop using __ClearPageMovable()

2025-07-02 Thread Sergey Senozhatsky
On (25/07/02 12:55), David Hildenbrand wrote: > On 02.07.25 12:10, Sergey Senozhatsky wrote: > > On (25/07/02 10:25), David Hildenbrand wrote: > > > On 02.07.25 10:11, Sergey Senozhatsky wrote: > > > > On (25/06/30 14:59), David Hildenbrand wrote: > &

Re: [PATCH v1 12/29] mm/zsmalloc: stop using __ClearPageMovable()

2025-07-02 Thread Sergey Senozhatsky
On (25/07/02 10:25), David Hildenbrand wrote: > On 02.07.25 10:11, Sergey Senozhatsky wrote: > > On (25/06/30 14:59), David Hildenbrand wrote: > > [..] > > > static int zs_page_migrate(struct page *newpage, struct page *page, > > > @@ -1736,6 +1736,13 @@ stati

Re: [PATCH v1 12/29] mm/zsmalloc: stop using __ClearPageMovable()

2025-07-02 Thread Sergey Senozhatsky
On (25/06/30 14:59), David Hildenbrand wrote: [..] > static int zs_page_migrate(struct page *newpage, struct page *page, > @@ -1736,6 +1736,13 @@ static int zs_page_migrate(struct page *newpage, > struct page *page, > unsigned long old_obj, new_obj; > unsigned int obj_idx; > > +

Re: [PATCH RFC 03/29] mm/zsmalloc: drop PageIsolated() related VM_BUG_ONs

2025-06-18 Thread Sergey Senozhatsky
On (25/06/18 19:39), David Hildenbrand wrote: > Let's drop these checks; these are conditions the core migration code > must make sure will hold either way, no need to double check. > > Signed-off-by: David Hildenbrand Reviewed-by: Sergey Senozhatsky

Re: [PATCH RFC 06/29] mm/zsmalloc: make PageZsmalloc() sticky

2025-06-18 Thread Sergey Senozhatsky
On (25/06/18 19:39), David Hildenbrand wrote: > Let the buddy handle clearing the type. > > Signed-off-by: David Hildenbrand FWIW, Reviewed-by: Sergey Senozhatsky

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-28 Thread Sergey Senozhatsky
On (08/28/19 18:22), Uwe Kleine-König wrote: > That is wrong. When you do > > pr_err("There are no round tuits to give out: %dE\n", -ENOENT); > > in a kernel that doesn't support %dE you get: > > There are no round tuits to give out: -2E OK. Good point. -ss

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-28 Thread Sergey Senozhatsky
On (08/28/19 14:49), Rasmus Villemoes wrote: > On 28/08/2019 14.02, Sergey Senozhatsky wrote: > > On (08/28/19 14:54), Jani Nikula wrote: > > [..] > >>> I personally think that this feature is not worth the code, data, > >>> and bikeshedding. > >&g

Re: [PATCH v2] vsprintf: introduce %dE for error constants

2019-08-28 Thread Sergey Senozhatsky
On (08/28/19 14:54), Jani Nikula wrote: [..] > > I personally think that this feature is not worth the code, data, > > and bikeshedding. > > The obvious alternative, I think already mentioned, is to just add > strerror() or similar as a function. I doubt there'd be much opposition > to that. Folks

Re: [PATCH v1 1/2] vsprintf: introduce %dE for error constants

2019-08-25 Thread Sergey Senozhatsky
On (08/24/19 16:58), Andrew Morton wrote: > On Sun, 25 Aug 2019 01:37:23 +0200 Uwe Kleine-König > wrote: > > > pr_info("probing failed (%dE)\n", ret); > > > > expands to > > > > probing failed (EIO) > > > > if ret holds -EIO (or EIO). This introduces an array of error codes. If > > th

Re: [PATCH] Documentation: fix vm/slub.rst warning

2019-02-10 Thread Sergey Senozhatsky
line emphasis start-string without > > end-string. > > > > Signed-off-by: Randy Dunlap > > Cc: Christoph Lameter > > Cc: Sergey Senozhatsky > > Acked-by: Mike Rapoport FWIW, Reviewed-by: Sergey Senozhatsky -ss

Re: [PATCH 1/3] printk: Introduce per-console loglevel setting

2018-10-21 Thread Sergey Senozhatsky
On (10/19/18 22:03), Calvin Owens wrote: > Hi Sergey, > > It's in-progress, I'm sorry it hasn't happened sooner. Great! > By embedding the kobject in the console struct, we end up needing to refactor > the console drivers to use the kobject refcount instead of simply calling > kfree(), which is

Re: [PATCH 1/3] printk: Introduce per-console loglevel setting

2018-10-18 Thread Sergey Senozhatsky
On (09/28/17 17:43), Calvin Owens wrote: > Not all consoles are created equal: depending on the actual hardware, > the latency of a printk() call can vary dramatically. The worst examples > are serial consoles, where it can spin for tens of milliseconds banging > the UART to emit a message, which c

Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

2017-09-17 Thread Sergey Senozhatsky
On (09/15/17 07:29), Mark Salyzyn wrote: > On 09/15/2017 06:28 AM, Petr Mladek wrote: > > I am still slightly nervous that external tools would need updating. > > Also they might have troubles to interpret the time stamps especially > > when the source is changed at runtime via > > /sys/module/prin

Re: [PATCH 2/2 v8] printk: Add monotonic, boottime, and realtime timestamps

2017-08-24 Thread Sergey Senozhatsky
On (08/24/17 09:42), Prarit Bhargava wrote: [..] > +config PRINTK_TIME_DEBUG > + bool "Allow runtime reselection of any timebase on printks" > + depends on PRINTK > + default N > + help > + Selecting this option causes time stamps of the printk() > + messages to be chang

Re: [PATCH v4] printk: Add monotonic, boottime, and realtime timestamps

2017-08-07 Thread Sergey Senozhatsky
On (08/07/17 11:52), Prarit Bhargava wrote: [..] > +/** > + * enum printk_time_type - Timestamp types for printk() messages. > + * @PRINTK_TIME_DISABLE: No time stamp. > + * @PRINTK_TIME_LOCAL: Local hardware clock timestamp. > + * @PRINTK_TIME_BOOT: Boottime clock timestamp. > + * @PRINTK_TIME_MON

Re: [PATCH v3] printk: Add boottime and real timestamps

2017-08-07 Thread Sergey Senozhatsky
On (08/07/17 08:41), Prarit Bhargava wrote: [..] > >> +static int printk_time_set(const char *val, const struct kernel_param *kp) > >> +{ > >> +char *param = strstrip((char *)val); > >> +int _printk_time; > >> + > >> +if (strlen(param) != 1) > >> +return -EINVAL; > > (see below)