gt; > +
> > > + - the Media development profile:
> > > +Documentation/driver-api/media/maintainer-entry-profile.rst
> >
> > Could you add a label to the title and refer to it directly?
>
> Same as above.
>
> > > +
> > > +- understanding of the projects' code base and coding style;
> > > +- ability to provide feedback to the patch authors;
> > > +- ability to judge when a patch might be ready for review and to submit;
> > > +- ability to write good code (last but certainly not least).
> > > +
> > > +Developers that intend to become committers are encouraged to
> > > participate
> >
> > s/intend/yearn/
>
> Heh, I had to go to the dictionary to seek for "yearn" meaning ;-)
>
> Let's use a simpler language, as most developers are not native-English
> speakers. I did:
>
> s/intend/desire/
>
> which is a synonym.
Works for me.
--
Kind regards,
Sakari Ailus
nactive for more than a couple of Kernel cycles,
> +maintainers will try to reach you via e-mail. If not possible, they may
> +revoke your committer grants and update MAINTAINERS file entries
> +accordingly. If you wish to resume contributing later on, then contact
> +the subsystem main
On Tue, Sep 24, 2019 at 09:03:56AM -0300, Mauro Carvalho Chehab wrote:
> This got moved to the firmware-guide.
>
> Fixes: f2dde1ed0f28 ("Documentation: ACPI: move dsd/graph.txt to
> firmware-guide/acpi and convert to reST")
> Signed-off-by: Mauro Carvalho Chehab
See documentation under
> - * Documentation/acpi/dsd instead and especially graph.txt,
> + * Documentation/firmware-guide/acpi/dsd instead and especially graph.txt,
> * data-node-references.txt and leds.txt .
Thanks! The files now have .rst suffix. Could you address that as well?
,
- attributes (such as aligned) containing numbers were not removed,
- attributes are only cleared from struct fields, not structs themselves.
This patch addresses these issues by removing the attributes.
Signed-off-by: Sakari Ailus
---
scripts/kernel-doc | 7 ---
1 file changed, 4 insertions(+), 3
imple enough to just declare them, de-obfuscating
> the code.
>
> While here, replace BUG_ON() by WARN_ON() as there's no reason
> why to panic the Kernel if this fails.
>
> Signed-off-by: Mauro Carvalho Chehab
Thanks!
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail:
On Mon, Dec 18, 2017 at 05:27:04PM -0200, Mauro Carvalho Chehab wrote:
> Em Mon, 9 Oct 2017 23:23:56 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > On Mon, Oct 09, 2017 at 07:19:21AM -0300, Mauro Carvalho Chehab wrote:
> > > The __V4L2_SUBDEV_MK_GET_T
Hi Mauro,
On Tue, Oct 10, 2017 at 08:37:43AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 6 Oct 2017 15:48:22 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > On Wed, Sep 27, 2017 at 07:23:47PM -0300, Mauro Carvalho Chehab wrote:
> > > As we now
Hi Mauro,
On Tue, Oct 10, 2017 at 09:49:38AM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 10 Oct 2017 14:54:35 +0300
> Sakari Ailus escreveu:
>
> > On Tue, Oct 10, 2017 at 06:15:03AM -0300, Mauro Carvalho Chehab wrote:
> > > Em Fri, 6 Oct 2017 14:51:06 +0300
>
On Mon, Oct 09, 2017 at 07:19:24AM -0300, Mauro Carvalho Chehab wrote:
> Use the existing macros to identify vb2_io_modes bits.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send
On Mon, Oct 09, 2017 at 07:19:28AM -0300, Mauro Carvalho Chehab wrote:
> Add cross-references where needed and add periods at the end of
> each kernel-doc paragraph, in order to make it coherent with other
> VB2 descriptions.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-b
implement QUERYBUF operation. It is called
"Videobuf2" and "VIDIOC_" prefix for IOCTL commands. With this and the ones
below fixed,
Acked-by: Sakari Ailus
> + * internally by VB2 by an API-specific handler, like ``videobuf2-v4l2.h``.
> *
> * The passed buffer shoul
* .. note::
> + *
> + *The following fields at @q should be set before calling this function:
should -> shall
I bet there's a lot of that in the documentation elsewhere, including this
patch.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from
On Tue, Oct 10, 2017 at 06:15:03AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 6 Oct 2017 14:51:06 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > On Fri, Oct 06, 2017 at 01:22:29PM +0300, Sakari Ailus wrote:
> > > > +V4L2 device nod
On Tue, Oct 10, 2017 at 05:30:04AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 6 Oct 2017 13:22:29 +0300
> Sakari Ailus escreveu:
>
> > > +Bridge driver
> > > + The same as V4L2 main driver.
> >
> > Not all V4L2 main drivers can be bridge driver
> @@ -1048,6 +1100,14 @@ void v4l2_subdev_init(struct v4l2_subdev *sd,
> __result; \
> })
>
> +/**
> + * v4l2_subdev_has_op - Checks if a subdev defines a certain ops.
s/ops/operation/ (or "op").
> + *
&
as defined by &enum v4l2_subdev_flags.
> *
> * @v4l2_dev: pointer to struct &v4l2_device
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
its right place.
>
> Signed-off-by: Mauro Carvalho Chehab
For patches 10--14:
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo
y_compose(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg,
> + unsigned int pad)
> +{
> + WARN_ON(pad >= sd->entity.num_pads);
> + return &cfg[pad].try_compose;
> +}
> #endif
>
> extern c
On Mon, Oct 09, 2017 at 07:19:09AM -0300, Mauro Carvalho Chehab wrote:
> Instead of using (1 << n) for bits, use the BIT() macro,
> as it makes them better documented.
I wouldn't say this makes a difference from documentation point of view.
Anyway,
Acked-by: Sakari Ailus
&
b/include/media/v4l2-flash-led-class.h
> @@ -91,12 +91,24 @@ struct v4l2_flash {
> struct v4l2_ctrl **ctrls;
> };
>
> +/**
> + * v4l2_subdev_to_v4l2_flash - Returns a &v4l2_flash from the
v4l2_flash -> struct v4l2_flash ?
Same below. With these,
Acked-by: Sakari Ai
e &struct media_entity embedded on it.
> + *
> + * @entity: pointer to &struct media_entity
> + */
> +#define media_entity_to_video_device(entity) \
> + container_of(entity, struct video_device, entity)
> +
> +/**
> + * media_entity_to_video_device - Returns a &stru
ed for this purpose. But several drivers do not use it, and while some
> +code exists that uses sysfs to discover related V4L2 device nodes (see
> libmedia_dev in the
> `v4l-utils <http://git.linuxtv.org/cgit.cgi/v4l-utils.git/>`__ git
> repository), there is no library yet that can pro
he :ref:`media controller API ` before
> +the periferal can be used. For such devices, the sub-devices' configuration
> +can be controlled via the :ref:`sub-device API `, which creates one
> +device node per sub-device.
> +
> .. _v4l2_device_naming:
>
> V4L2 Device Node Naming
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro,
On Fri, Oct 06, 2017 at 01:22:29PM +0300, Sakari Ailus wrote:
> > +V4L2 device node
> > + A device node that is associated to a V4L2 main driver,
> > + as specified in :ref:`v4l2_device_naming`.
I think we need to name the interface, not so much their ins
y: Hans Verkuil
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
long.
> + V4L2 hardware that it is controlled via V4L2 device nodes.
> +
> + See :ref:`v4l2_hardware_control`.
> diff --git a/Documentation/media/uapi/v4l/v4l2.rst
> b/Documentation/media/uapi/v4l/v4l2.rst
> index 2128717299b3..698c060939f0 100644
> --- a/Documentation/media/uapi/v4l/v4l2.rst
> +++ b/Documentation/media/uapi/v4l/v4l2.rst
> @@ -32,6 +32,7 @@ This part describes the Video for Linux API version 2 (V4L2
> API) specification.
> videodev
> capture-example
> v4l2grab-example
> +glossary
> biblio
>
>
--
Regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ISP drivers.
>
> We have drivers for things implemented via ISP. However, right now,
> there's no distinction at the driver if the functionality is implemented
> on software (ISP) or in hardware.
>
> >
> > > confusing, as an ISP hardware may actually implemen
On Thu, Oct 05, 2017 at 03:39:29PM -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 5 Oct 2017 11:21:07 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > My apologies for the late reply.
> >
> > On Tue, Aug 29, 2017 at 10:07:50AM -0300, Mauro Carvalho
Hi Mauro,
My apologies for the late reply.
On Tue, Aug 29, 2017 at 10:07:50AM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 29 Aug 2017 10:47:48 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > Thanks for the update. A few comments below.
> >
>
Hi Mauro,
(Removing the non-list recipients.)
On Fri, Sep 29, 2017 at 06:27:13AM -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Sep 2017 15:09:21 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > On Wed, Sep 27, 2017 at 06:46:56PM -0300, Mauro Carva
On Wed, Sep 27, 2017 at 07:23:48PM -0300, Mauro Carvalho Chehab wrote:
> As both vdev-centric and MC-centric devices may implement the
> same APIs, we need a flag to allow userspace to distinguish
> between them.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Sakari Ailus
-
support some subdev-specific
> controls.
>
> Signed-off-by: Mauro Carvalho Chehab
Thanks!
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.
interface with that name, fwnode property API is just an API.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
interface with that name, fwnode property API is just an API.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
union at async match struct
> media: v4l2-ctrls: document nested members of structs
> media: videobuf2-core: improve kernel-doc markups
> media: media-entity.h: add kernel-doc markups for nested structs
For patches apart form 7 and 13 (see my comments to them):
Acked-by: Sakari
ffer/g
With that,
Acked-by: Sakari Ailus
> name is, instead, v4l2_kevent;
>
> - Some things are mentioned on both places (with different words),
> others are either on one of the files.
>
> In order to cleanup this mess, put everything at v4l2-event.rst
> and improve
liance/
Same below.
Please see:
https://mipi.org/content/what-does-mipi-stand>
With that,
Acked-by: Sakari Ailus
> + * Interface's Camera Serial Interface version 1
> + * (MIPI CSI1) or Standard Mobile Imaging Architecture's
&g
Hi Mauro,
On Mon, Sep 04, 2017 at 05:41:27PM -0300, Mauro Carvalho Chehab wrote:
> From: Sakari Ailus
>
> There appears to be an issue in using \small in certain cases on Sphinx
> 1.4 and 1.5. Other format documents don't use \small either, remove it
> from here as w
There appears to be an issue in using \small in certain cases on Sphinx
1.4 and 1.5. Other format documents don't use \small either, remove it
from here as well.
Signed-off-by: Sakari Ailus
---
Hi Mauro,
What would you think of this as an alternative approach? No hacks needed.
J
be true. In any case,
> this is not relevant, as udev will take care of it.
>
> So, remove this useless misinformation.
>
> Acked-by: Hans Verkuil
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Sakari Ailus
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe
_USB_Camera-B4.04.27.1-video-index0 ->
> ../../video0
> + └── by-path
> + └── pci-:00:14.0-usb-0:2:1.0-video-index0 -> ../../video0
> +
> +
> Many drivers support "video_nr", "radio_nr" or "vbi_nr" module
> options to sel
ine.
> +
> + See :ref:`subdev`.
> +
> +Vdev-centric
> + V4L2 hardware that it is controlled via V4L2 device nodes.
> +
> + See :ref:`v4l2_hardware_control`.
> diff --git a/Documentation/media/uapi/v4l/v4l2.rst
> b/Documentation/media/uapi/v4l/v4l2.rst
> index f52a11c949d3..1ee4b86d18e1 100644
> --- a/Documentation/media/uapi/v4l/v4l2.rst
> +++ b/Documentation/media/uapi/v4l/v4l2.rst
> @@ -31,6 +31,7 @@ This part describes the Video for Linux API version 2 (V4L2
> API) specification.
> videodev
> capture-example
> v4l2grab-example
> +glossary
> biblio
>
>
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ote::
> +
> + A **vdev-centric** may optionally expose V4L2 sub-devices via
> + :ref:`sub-device API `. In that case, it has to implement
> + the :ref:`media controller API ` as well.
Looks good!
> +
> +
> +
> +.. _v4l2_device_naming:
>
> Device Naming
> =
--
Kind regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
note::
> +
> + It is forbidden for **device-centric** devices to expose V4L2
> + sub-devices via :ref:`sub-device API `, although this
> + might change in the future.
I believe we agree on the subject matter but we can still argue. :-D
Could you drop ", although this might change in
Hi Mauro,
On Wed, Aug 23, 2017 at 10:42:28AM -0300, Mauro Carvalho Chehab wrote:
> Em Wed, 23 Aug 2017 12:37:30 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > Thanks for the patch! Something like this was long due.
> >
> > I cc'd
is a pain
without MC. Less variance in interface availability is better for the user
space, and unlike between video node centric vs. MC-centric, there are
hardly technical reasons (or at least I can't remember one) for doing this.
I remember we had a few of these drivers and the agreement was to add MC
interfac
Nfsroot uses nfsvers=2 by default (as in fs/nfs/nfsroot.c), unlike is
specified in a modern nfs man page. Document this.
Signed-off-by: Sakari Ailus
---
Hi all,
I just figured out that NFS v2 is the default version when mounting root
over NFS. It'd be nice to tell in documentation th
48 matches
Mail list logo
