RE: [PATCH v4 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

Hi Hans, > On 28/08/17 12:30, Mauro Carvalho Chehab wrote: > > Em Mon, 28 Aug 2017 12:05:06 +0200 > > Hans Verkuil escreveu: > > > >> On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > >>> The documentation doesn't mention if vdev-centric hardware control > >>> would have subdev API or not. > >>>

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Oliver, Thanks :-) Actually it will be v5 patch set & I have sent it now. Marc comments were on old v2 patch. Thanks, Ramesh > -Original Message- > From: Oliver Hartkopp [mailto:socket...@hartkopp.net] > Sent: 28 April 2016 07:28 > To: Ramesh Shanmugasundaram ; >

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

HI Marc, Gentle reminder! Are you happy with the open comment's disposition? I can send a next version of patch if we have a closure on current set of comments. Thanks, Ramesh > -Original Message- > From: Ramesh Shanmugasundaram > Sent: 01 April 2016 13:49 > To: Ramesh

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Marc, Thanks for your time & review comments. > -Original Message- (...) > > +#define RCANFD_NAPI_WEIGHT 8 /* Rx poll quota */ > > + > > +#define RCANFD_NUM_CHANNELS2 > > +#define RCANFD_CHANNELS_MASK 0x3 /* Two channels max */ > > (BIT(

RE: [PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Marc, > Subject: Re: [PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver > > On 03/15/2016 10:48 AM, Ramesh Shanmugasundaram wrote: > > This patch adds support for the CAN FD controller found in Renesas > > R-Car SoCs. The controller operates in CAN FD

[PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver

5. The maximum number of message RAM area the controller can use is 3584 bytes. It is specified 10752 bytes in the manual. Signed-off-by: Ramesh Shanmugasundaram --- Hi All, Thanks for the review comments. This updated patch is based on linux-can-next tag (linux-can-next-for-4.6-20160310)

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Oliver, Marc, > On 03/08/2016 01:48 PM, Ramesh Shanmugasundaram wrote: > > >> In fact you provided a CAN driver which is "CAN-FD-only". > > > > Yes. That's the status of current submission. (...) > > > > I did try this option earlier bu

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Oliver, Thanks for the comments. > On 08.03.2016 09:57, Ramesh Shanmugasundaram wrote: > > > > > As you mentioned further down, when a user does this > > > > "ip link set can0 up type can bitrate 100" > > > > the intention is to

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Oliver, Thanks for the comments. > On 03/07/2016 09:32 AM, Ramesh Shanmugasundaram wrote: > > >>>>> + /* Ensure channel starts in FD mode */ > >>>>> + if (!(priv->can.ctrlmode & CAN_CTRLMODE_FD)) { > >>>>> +

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Rob, Thanks for the review comments. > On Thu, Mar 03, 2016 at 03:38:35PM +0000, Ramesh Shanmugasundaram wrote: > > This patch adds support for the CAN FD controller found in Renesas > > R-Car SoCs. The controller operates in CAN FD mode by default. > > > > CAN FD m

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Marc, > On 03/07/2016 09:02 AM, Ramesh Shanmugasundaram wrote: > > Hi Oliver, > > > > Thanks for the review comments. > > > >> On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote: > >> > >>> Changes since v1: > >>> * Rem

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Oliver, Thanks for the review comments. > On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote: > > > Changes since v1: > > * Removed testmodes & debugfs code (suggested by Oliver H) > > * Fixed tx path race issue by introducing lock (suggested

[PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

e maximum number of message RAM area the controller can use is 3584 bytes. It is specified 10752 bytes in the manual. Signed-off-by: Ramesh Shanmugasundaram --- Changes since v1: * Removed testmodes & debugfs code (suggested by Oliver H) * Fixed tx path race issue by introducin

RE: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Marc, Sorry for the late response. > On 03/02/2016 11:08 AM, Ramesh Shanmugasundaram wrote: > >>>> I see no locking for the tx-path. > >>> > >>> I am not sure why locking is needed in tx-path? > >> > >> If the tx-path is shared b

RE: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Marc, > On 03/02/2016 09:41 AM, Ramesh Shanmugasundaram wrote: > >> Is the channel loopback mode configurable per channel? If so, please > >> remove the module parameter and make use of CAN_CTRLMODE_LOOPBACK to > >> configure it. > > > > The l

RE: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Oliver, Thanks for the review. > On 03/01/2016 10:34 AM, Ramesh Shanmugasundaram wrote: > > This patch adds support for the CAN FD controller found in Renesas > > R-Car SoCs. The controller operates in CAN FD mode by default. Two > > test modes are available and

RE: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

Hi Marc, Thanks for the review. > On 03/01/2016 10:34 AM, Ramesh Shanmugasundaram wrote: > > This patch adds support for the CAN FD controller found in Renesas > > R-Car SoCs. The controller operates in CAN FD mode by default. Two > > test modes are available and

[PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

FD controller. This is not documented. 4. The minimum value of NTSEG1 in RSCFDnCFDCmNCFG register is 2 Tq. It is mentioned 4 Tq in the manual. 5. The maximum number of message RAM area the controller can use is 3584 bytes. It is mentioned 10752 bytes in the manual. Signed-off-by: Ramesh Sh