Re: [PATCH v6 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-07-23 Thread Phil Auld
gt; Peter add it. > Sounds good. > Will you be handling the backport into the RHEL 8 kernels? I'll > submit this to Ubuntu and linux-stable once it gets accepted. > Yep. > Thanks again, Thank you :) Cheers, Phil > > > On Tue, Jul 23, 2019 at 12:13 PM Phil Au

Re: [PATCH v6 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-07-23 Thread Phil Auld
most 30x performance > improvement, while still maintaining correct cpu quota restrictions. > That testcase is available at https://github.com/indeedeng/fibtest. > > Fixes: 512ac999d275 ("sched/fair: Fix bandwidth timer clock drift condition") > Signed-off-by: Dave Chiluk

Re: [PATCH v3 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-05-29 Thread Phil Auld
that the non-cpu bound > application > +will use up to sched_cfs_bandwidth_slice_us additional quota in some periods, > +thereby preventing the cpu-bound application from fully using it's quota by "its quota" > +that same amount. In these instances it will be up to the CFS algorithm (see > +sched-design-CFS.txt) to decide which application is chosen to run, as they > +will both be runnable and have remaining quota. This runtime discrepancy > will > +should made up in the following periods when the interactive application > idles. > + "discrepancy will be made" or "descrepancy should be made" but not both :) Otherwise, fwiw, Acked-by: Phil Auld Cheers, Phil --

Re: [PATCH v2 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-05-24 Thread Phil Auld
On Fri, May 24, 2019 at 10:14:36AM -0500 Dave Chiluk wrote: > On Fri, May 24, 2019 at 9:32 AM Phil Auld wrote: > > On Thu, May 23, 2019 at 02:01:58PM -0700 Peter Oskolkov wrote: > > > > If the machine runs at/close to capacity, won't the overallocation > >

Re: [PATCH v2 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-05-24 Thread Phil Auld
On Thu, May 23, 2019 at 02:01:58PM -0700 Peter Oskolkov wrote: > On Thu, May 23, 2019 at 11:44 AM Dave Chiluk wrote: > > > > It has been observed, that highly-threaded, non-cpu-bound applications > > running under cpu.cfs_quota_us constraints can hit a high percentage of > > periods throttled whil