Re: [PATCH HID 6/7] HID: bpf: Allow to control the connect mask of hid-generic from BPF

2024-09-02 Thread Peter Hutterer
On Tue, Sep 03, 2024 at 01:14:36AM +0900, Benjamin Tissoires wrote: > We make struct hid_device_id writeable and use the .driver_data field > of hid-generic as the connect mask. I think this needs to be spelled out a bit more: for this to work the driver *must* be hid-generic, otherwise this doesn

Re: [PATCH v2 35/37] input: add a EV_SW event for ratchet switch

2017-04-06 Thread Peter Hutterer
On Thu, Apr 06, 2017 at 09:16:05PM -0300, Mauro Carvalho Chehab wrote: > Em Wed, 5 Apr 2017 22:03:03 +1000 > Peter Hutterer escreveu: > > > On Tue, Apr 04, 2017 at 09:22:35AM -0300, Mauro Carvalho Chehab wrote: > > > Some mouses have a switch on their wheel, allowing t

Re: [PATCH v2 35/37] input: add a EV_SW event for ratchet switch

2017-04-05 Thread Peter Hutterer
On Tue, Apr 04, 2017 at 09:22:35AM -0300, Mauro Carvalho Chehab wrote: > Some mouses have a switch on their wheel, allowing to switch isnt' the plural of mouse mice? (non-native english speaker myself) > between ratchet or free wheel mode. Add support for it. s/or/and/ > > Signed-off-by: Mauro

Re: [PATCH 11/33] docs: input/event-codes: convert it to ReST format

2017-04-02 Thread Peter Hutterer
On Sat, Apr 01, 2017 at 11:42:05PM -0300, Mauro Carvalho Chehab wrote: > Em Sun, 2 Apr 2017 11:16:35 +1000 > Peter Hutterer escreveu: > > > On Sat, Apr 01, 2017 at 03:15:54PM -0300, Mauro Carvalho Chehab wrote: > > > This file require minimum adjustments to be a valid Re

Re: [PATCH 11/33] docs: input/event-codes: convert it to ReST format

2017-04-01 Thread Peter Hutterer
On Sat, Apr 01, 2017 at 03:15:54PM -0300, Mauro Carvalho Chehab wrote: > This file require minimum adjustments to be a valid ReST file. > Do it, in order to be able to parse it with Sphinx. > > Signed-off-by: Mauro Carvalho Chehab there's a conflict markerleft in this file, see below Cheers,

Re: [PATCH v4] Documentation: Input: Add uinput documentation

2017-03-27 Thread Peter Hutterer
On Mon, Mar 27, 2017 at 09:01:19PM -0300, Marcos Paulo de Souza wrote: > Signed-off-by: Marcos Paulo de Souza > --- > > v3 -> v4: > Add comment and a sleep call before UI_DEV_DESTROY (requested by Peter) > On emit function, add an fd parameter, avoiding global variables > Check return of ioct

Re: [PATCH v3] Documentation: Input: Add uinput documentation

2017-03-26 Thread Peter Hutterer
On Sun, Mar 26, 2017 at 01:48:12PM -0300, Marcos Paulo de Souza wrote: > Signed-off-by: Marcos Paulo de Souza > --- > v2 -> v3: > Changes in libevdev's description (suggested by Peter) > Added uinput version check when using the old interface (suggested by Peter) > Removed section numbers from

Re: [PATCH v2] Docs: Input: initial uinput documentation

2017-03-26 Thread Peter Hutterer
ion of this patch. The first version can be > > > checked > > > here[1]. A special thanks to Peter Hutterer who dug the last patch and > > > suggested > > > a lot of changes , hopefully, all addressed in this version. > > > > This seems like a goo

Re: [PATCH v2] Documentation: Input: Add uinput documentation

2017-03-26 Thread Peter Hutterer
On Sun, Mar 26, 2017 at 01:21:14PM -0300, Marcos Paulo de Souza wrote: > On Fri, Mar 24, 2017 at 02:39:13PM +1000, Peter Hutterer wrote: > > as usual, reading through these things multiple times means one spots a > > couple of different things. sorry about that. > > > >

Re: [PATCH v2] Documentation: Input: Add uinput documentation

2017-03-23 Thread Peter Hutterer
as usual, reading through these things multiple times means one spots a couple of different things. sorry about that. On Fri, Mar 24, 2017 at 12:34:59AM -0300, Marcos Paulo de Souza wrote: > Signed-off-by: Marcos Paulo de Souza > --- > Documentation/input/uinput.rst | 196 >

Re: [PATCH] Documentation: Input: Add uinput documentation

2017-03-22 Thread Peter Hutterer
just two comments below: > On Wed, Mar 22, 2017 at 02:03:31PM +1000, Peter Hutterer wrote: [...] > > > +memset(&ie, 0, sizeof(ie)); > > > +ie.type = type; > > > +ie.code = code; > > > +ie.value = val; > > > + >

Re: [PATCH] Documentation: Input: Add uinput documentation

2017-03-21 Thread Peter Hutterer
Thanks for this, I'm getting enough questions about this, so it's nice to have a link :) First comment: I don't think rst requires unwrapped lines, so please break those up. Second comment: I'd really like to have a link to libevdev here. It has a uinput interface that's a bit more obvious and ta