Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

2025-02-19 Thread Pavel Begunkov
On 2/17/25 23:26, Mina Almasry wrote: On Thu, Feb 13, 2025 at 5:17 AM Pavel Begunkov wrote: ... It's asserting that sizeof(ubuf_info_msgzc) <= sizeof(skb->cb), and I'm guessing increasing skb->cb size is not really the way to go. What I may be able to do here is stash th

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

2025-02-13 Thread Pavel Begunkov
On 2/12/25 19:18, Mina Almasry wrote: On Wed, Feb 12, 2025 at 7:52 AM Pavel Begunkov wrote: On 2/10/25 21:09, Mina Almasry wrote: On Wed, Feb 5, 2025 at 4:20 AM Pavel Begunkov wrote: On 2/3/25 22:39, Mina Almasry wrote: ... diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

2025-02-12 Thread Pavel Begunkov
On 2/10/25 21:09, Mina Almasry wrote: On Wed, Feb 5, 2025 at 4:20 AM Pavel Begunkov wrote: On 2/3/25 22:39, Mina Almasry wrote: ... diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index bb2b751d274a..3ff8f568c382 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h

Re: [PATCH RFC net-next v1 5/5] net: devmem: Implement TX path

2025-02-05 Thread Pavel Begunkov
On 2/5/25 22:16, Pavel Begunkov wrote: On 2/5/25 20:22, Mina Almasry wrote: On Wed, Feb 5, 2025 at 4:41 AM Pavel Begunkov wrote: On 1/28/25 14:49, Willem de Bruijn wrote: +struct net_devmem_dmabuf_binding * +net_devmem_get_sockc_binding(struct sock *sk, struct sockcm_cookie *sockc

Re: [PATCH RFC net-next v1 5/5] net: devmem: Implement TX path

2025-02-05 Thread Pavel Begunkov
On 2/5/25 20:22, Mina Almasry wrote: On Wed, Feb 5, 2025 at 4:41 AM Pavel Begunkov wrote: On 1/28/25 14:49, Willem de Bruijn wrote: +struct net_devmem_dmabuf_binding * +net_devmem_get_sockc_binding(struct sock *sk, struct sockcm_cookie *sockc) +{ + struct net_devmem_dmabuf_binding

Re: [PATCH RFC net-next v1 5/5] net: devmem: Implement TX path

2025-02-05 Thread Pavel Begunkov
orse if it works for a while but starts to unpredictably fail as time passes. With binding at least it'd fail fast if the setup is not done correctly. -- Pavel Begunkov

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

2025-02-05 Thread Pavel Begunkov
err = PTR_ERR(binding); + binding = NULL; + goto out_err; + } + } -- Pavel Begunkov