Re: [PATCH 01/18] docs: can.rst: fix a footnote reference

2018-05-07 Thread Oliver Hartkopp
gt; > So, replace it by a valid syntax. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Oliver Hartkopp Thanks Mauro! Best regards, Oliver > --- > Documentation/networking/can.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/n

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-04-27 Thread Oliver Hartkopp
Hello Ramesh, please send out a new v3 patchset to trigger the process again :-) Best regards, Oliver On 04/13/2016 08:25 AM, Ramesh Shanmugasundaram wrote: HI Marc, Gentle reminder! Are you happy with the open comment's disposition? I can send a next version of patch if we have a closure on

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-12 Thread Oliver Hartkopp
Hi Ramesh, On 03/11/2016 08:14 AM, Ramesh Shanmugasundaram wrote: As we are fixing this issue in CAN dev.c, I'll remove this check in ndo_open and set CAN_CTRLMODE_FD flag in ctrlmode & remove the flag in ctrlmode_supported in the next v3 version of the patch. I posted a V2 version of that

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-08 Thread Oliver Hartkopp
On 03/08/2016 01:48 PM, Ramesh Shanmugasundaram wrote: >> In fact you provided a CAN driver which is "CAN-FD-only". > > Yes. That's the status of current submission. > >> We did not had that before but there's a solution for this kind of setup. >> >> There is a similar case with CAN_CTRLMODE_FD_

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-08 Thread Oliver Hartkopp
Hi Ramesh, On 08.03.2016 09:57, Ramesh Shanmugasundaram wrote: As you mentioned further down, when a user does this "ip link set can0 up type can bitrate 100" the intention is to put the controller in CAN 2.0 mode. Even if we use a status flag or copy the data bitrate equal to the nomin

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-07 Thread Oliver Hartkopp
On 03/07/2016 09:32 AM, Ramesh Shanmugasundaram wrote: > + /* Ensure channel starts in FD mode */ > + if (!(priv->can.ctrlmode & CAN_CTRLMODE_FD)) { > + netdev_err(ndev, "enable can fd mode for channel %d\n", ch); > + goto fail_mode; > + } What's the

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-06 Thread Oliver Hartkopp
On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote: > Changes since v1: > * Removed testmodes & debugfs code (suggested by Oliver H) > * Fixed tx path race issue by introducing lock (suggested by Marc K) > * Removed __maybe_unused attribute of rcar_canfd_of_table > > obj-$

Re: [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-01 Thread Oliver Hartkopp
On 03/01/2016 10:34 AM, Ramesh Shanmugasundaram wrote: > This patch adds support for the CAN FD controller found in Renesas R-Car > SoCs. The controller operates in CAN FD mode by default. Two test modes > are available and can be enabled by the "rcar_canfd.testmode" module > parameter. Refer to