Re: [PATCH 6/7] remoteproc: qcom_q6v5_pas: Add hwspinlock bust on stop

2024-05-17 Thread Mukesh Ojha
On 5/17/2024 4:28 AM, Chris Lew wrote: From: Richard Maina When remoteproc goes down unexpectedly this results in a state where any acquired hwspinlocks will remain locked possibly resulting in deadlock. In order to ensure all locks are freed we include a call to hwspin_lock_bust() during re

Re: [PATCH 6/7] remoteproc: qcom_q6v5_pas: Add hwspinlock bust on stop

2024-05-17 Thread Mukesh Ojha
On 5/17/2024 4:28 AM, Chris Lew wrote: From: Richard Maina When remoteproc goes down unexpectedly this results in a state where any acquired hwspinlocks will remain locked possibly resulting in deadlock. In order to ensure all locks are freed we include a call to hwspin_lock_bust() during re

Re: [PATCH v8 00/10] Add Qualcomm APSS Minidump driver related support

2024-03-04 Thread Mukesh Ojha
I would really appreciate if i get review on this series.. Thank you.. -Mukesh On 1/31/2024 4:38 PM, Mukesh Ojha wrote: Abstract and PDF here: https://lpc.events/event/17/contributions/1468/ Video: https://www.youtube.com/watch?v=3vL3gtAu84s Patch 1 deals in detail documentation on minidump

Re: [PATCH v8 08/10] pstore/ram: Add dynamic ramoops region support through commandline

2024-02-12 Thread Mukesh Ojha
Hi @Kees/@Tony/@Guilherme, Wanted to get your early feedback, especially on 8th and 9th patch. please suggest. -Mukesh On 1/31/2024 4:38 PM, Mukesh Ojha wrote: The reserved memory region for ramoops is assumed to be at a fixed and known location when read from the devicetree. This may not be

[PATCH v8 10/10] soc: qcom: register ramoops region with APSS minidump

2024-01-31 Thread Mukesh Ojha
Register ramoops region with APSS minidump via ramoops info notifier so that these region gets captured on system crash. Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/qcom_minidump.c | 84 1 file changed, 84 insertions(+) diff --git a/drivers/soc/qcom

[PATCH v8 08/10] pstore/ram: Add dynamic ramoops region support through commandline

2024-01-31 Thread Mukesh Ojha
can be read by ramoops driver. Signed-off-by: Mukesh Ojha --- Documentation/admin-guide/ramoops.rst | 23 +- fs/pstore/Kconfig | 15 ++ fs/pstore/ram.c | 66 +-- include/linux/pstore_ram.h| 5

[PATCH v8 09/10] pstore/ram: Add ramoops information notifier support

2024-01-31 Thread Mukesh Ojha
o the passed callback by the client and If the call for ramoops ready register comes after ramoops probe than call the callback directly. Signed-off-by: Mukesh Ojha --- fs/pstore/ram.c| 114 + include/linux/pstore_ram.h | 15 + 2 files changed

[PATCH v8 06/10] soc: qcom: Add Qualcomm APSS minidump kernel driver

2024-01-31 Thread Mukesh Ojha
ts updated upon registration of a new region. Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/Kconfig | 13 + drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/qcom_minidump.c | 606 ++ drivers/soc/qcom/qcom_minidump_internal.h | 10 + d

[PATCH v8 07/10] MAINTAINERS: Add entry for minidump related files

2024-01-31 Thread Mukesh Ojha
Add the entries into maintainer file for all the minidump related modules. Signed-off-by: Mukesh Ojha --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c45587eb4c1d..a7eea6e64dce 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18176,6

[PATCH v8 05/10] init: export linux_banner data variable

2024-01-31 Thread Mukesh Ojha
Some debug loadable module like minidump is interested in knowing the kernel version against which it is being build. Let's export linux_banner. Signed-off-by: Mukesh Ojha --- include/linux/init.h | 3 +++ init/version-timestamp.c | 2 ++ 2 files changed, 5 insertions(+) diff --

[PATCH v8 04/10] remoteproc: qcom: Remove minidump related data from qcom_common.c

2024-01-31 Thread Mukesh Ojha
As minidump specific data structure and functions move under config QCOM_RPROC_MINIDUMP, so remove minidump specific data from driver/remoteproc/qcom_common.c . Signed-off-by: Mukesh Ojha --- drivers/remoteproc/qcom_common.c | 160 --- 1 file changed, 160 deletions

[PATCH v8 03/10] remoteproc: qcom_q6v5_pas: Use qcom_rproc_minidump()

2024-01-31 Thread Mukesh Ojha
s use qcom_rproc_minidump() and we will be removing qcom_minidump() and minidump related stuff from driver/remoteproc/qcom_common.c . Signed-off-by: Mukesh Ojha --- drivers/remoteproc/Kconfig | 1 + drivers/remoteproc/qcom_q6v5_pas.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)

[PATCH v8 02/10] soc: qcom: Add qcom_rproc_minidump module

2024-01-31 Thread Mukesh Ojha
idump() functionality from driver/remoteproc/qcom_common.c into a separate file under qcom_rproc_minidump(). Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/Kconfig | 10 ++ drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/qcom_minidump_internal.h | 64 + dr

[PATCH v8 01/10] docs: qcom: Add qualcomm minidump guide

2024-01-31 Thread Mukesh Ojha
Add the qualcomm minidump guide for the users which tries to cover the dependency, API use and the way to test and collect minidump on Qualcomm supported SoCs. Signed-off-by: Mukesh Ojha Reviewed-by: Bagas Sanjaya --- Documentation/admin-guide/index.rst | 1 + Documentation/admin

[PATCH v8 00/10] Add Qualcomm APSS Minidump driver related support

2024-01-31 Thread Mukesh Ojha
p boot firmware support. After that we will see a bunch of predefined registered region as binary blobs files starts with md_* downloaded on the x86 machine at configured/default location in PCAT tool from the product, more about this can be found in qualcomm minidump guide patch. Mukesh Ojha

Re: RESEND: Re: [Patch v6 03/12] docs: qcom: Add qualcomm minidump guide

2024-01-09 Thread Mukesh Ojha
On 1/8/2024 9:04 PM, Ruipeng Qi wrote: On Wed, Jan 3, 2024 at 11:27 PM Mukesh Ojha wrote: One more thing, kernel part of minidump, we are calling it APSS Minidump has limitation of no of entries so it will be difficult to dump non-continuous regions after a certain number of registration

Re: RESEND: Re: [Patch v6 03/12] docs: qcom: Add qualcomm minidump guide

2024-01-03 Thread Mukesh Ojha
On 12/25/2023 7:25 PM, Ruipeng Qi wrote: <+How a kernel client driver can register region with minidump <+ <+ <+Client driver can use ``qcom_minidump_region_register`` API's to register <+and ``qcom_minidump_region_unregister`` to unr

Re: [Patch v6 03/12] docs: qcom: Add qualcomm minidump guide

2023-12-11 Thread Mukesh Ojha
On 24/11/2023 22:19, Mukesh Ojha wrote: Add the qualcomm minidump guide for the users which tries to cover the dependency, API use and the way to test and collect minidump on Qualcomm supported SoCs. Signed-off-by: Mukesh Ojha ---   Documentation/admin-guide/index.rst |   1 +   Document

Re: [Patch v6 10/12] pstore/ram: Add dynamic ramoops region support through commandline

2023-11-28 Thread Mukesh Ojha
On 11/27/2023 5:04 PM, Pavan Kondeti wrote: On Sat, Nov 25, 2023 at 03:49:53AM +0530, Mukesh Ojha wrote: The reserved memory region for ramoops is assumed to be at a fixed and known location when read from the devicetree. This may not be required for something like Qualcomm's minidump

[Patch v6 08/12] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-11-24 Thread Mukesh Ojha
art of ram dump collection. It provides appropriate symbol to register/unregister client regions. To simplify post mortem debugging, it creates and maintain an ELF header as first region that gets updated upon registration of a new region. Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/Kconfig

[Patch v6 11/12] pstore/ram: Add ramoops ready notifier support

2023-11-24 Thread Mukesh Ojha
river probes successfully and it passes the ramoops region information to the passed callback by the client and If the call for ramoops ready register comes after ramoops probe than call the callback directly. Signed-off-by: Mukesh Ojha --- fs/pstore/ram.c

[Patch v6 12/12] soc: qcom: register ramoops region with APSS minidump

2023-11-24 Thread Mukesh Ojha
Register ramoops region with APSS minidump so that these region gets captured on system crash. Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/qcom_minidump.c | 62 1 file changed, 62 insertions(+) diff --git a/drivers/soc/qcom/qcom_minidump.c b/drivers

[Patch v6 09/12] MAINTAINERS: Add entry for minidump related files

2023-11-24 Thread Mukesh Ojha
Add the entries into maintainer file for all the minidump related modules. Signed-off-by: Mukesh Ojha --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f2b2cd60eb20..53b9f22816c2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18016,6

[Patch v6 10/12] pstore/ram: Add dynamic ramoops region support through commandline

2023-11-24 Thread Mukesh Ojha
at it can be read by ramoops driver. Signed-off-by: Mukesh Ojha --- Documentation/admin-guide/ramoops.rst | 7 fs/pstore/Kconfig | 15 + fs/pstore/ram.c | 62 --- include/linux/pstore_ram.h|

[Patch v6 06/12] remoteproc: qcom: Remove minidump related data from qcom_common.c

2023-11-24 Thread Mukesh Ojha
As minidump specific data structure and functions move under config QCOM_RPROC_MINIDUMP, so remove minidump specific data from driver/remoteproc/qcom_common.c . Signed-off-by: Mukesh Ojha --- drivers/remoteproc/qcom_common.c | 160 --- 1 file changed, 160

[Patch v6 07/12] init: export linux_banner data variable

2023-11-24 Thread Mukesh Ojha
Some debug loadable module like minidump is interested in knowing the kernel version against which it is being build. Let's export linux_banner. Signed-off-by: Mukesh Ojha --- include/linux/init.h | 3 +++ init/version-timestamp.c | 3 +++ 2 files changed, 6 insertions(+) diff --

[Patch v6 05/12] remoteproc: qcom_q6v5_pas: Use qcom_rproc_minidump()

2023-11-24 Thread Mukesh Ojha
s use qcom_rproc_minidump() and we will be removing qcom_minidump() and minidump related stuff from driver/remoteproc/qcom_common.c . Signed-off-by: Mukesh Ojha --- drivers/remoteproc/Kconfig | 1 + drivers/remoteproc/qcom_q6v5_pas.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)

[Patch v6 03/12] docs: qcom: Add qualcomm minidump guide

2023-11-24 Thread Mukesh Ojha
Add the qualcomm minidump guide for the users which tries to cover the dependency, API use and the way to test and collect minidump on Qualcomm supported SoCs. Signed-off-by: Mukesh Ojha --- Documentation/admin-guide/index.rst | 1 + Documentation/admin-guide/qcom_minidump.rst | 272

[Patch v6 02/12] firmware/qcom: qcom_scm: Add multiple download mode support

2023-11-24 Thread Mukesh Ojha
Currently, scm driver only supports full dump when download mode is selected. Add support to enable minidump as well as enable it along with fulldump. Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/qcom_scm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers

[Patch v6 04/12] soc: qcom: Add qcom_rproc_minidump module

2023-11-24 Thread Mukesh Ojha
idump() functionality from driver/remoteproc/qcom_common.c into a separate file under qcom_rproc_minidump(). Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/Kconfig | 10 +++ drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/qcom_minidump_internal.h

[Patch v6 00/12] Add Qualcomm Minidump driver related support

2023-11-24 Thread Mukesh Ojha
ackage manager kit). After that we will see a bunch of predefined registered region as binary blobs files starts with md_* downloaded on the x86 machine on given location in PCAT tool from the target device, more about this can be found in qualcomm minidump guide patch. Mukesh Ojha (12):

[Patch v6 01/12] firmware: qcom_scm: Refactor code to support multiple dload mode

2023-11-24 Thread Mukesh Ojha
. Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/Kconfig| 11 drivers/firmware/qcom/qcom_scm.c | 58 +--- 2 files changed, 49 insertions(+), 20 deletions(-) diff --git a/drivers/firmware/qcom/Kconfig b/drivers/firmware/qcom/Kconfig index

Re: [REBASE PATCH v5 10/17] pstore: Add pstore_region_defined() helper and export it

2023-10-09 Thread Mukesh Ojha
Thanks for the review. On 9/14/2023 4:54 AM, Kees Cook wrote: On Mon, Sep 11, 2023 at 04:23:52PM +0530, Mukesh Ojha wrote: There are users like Qualcomm minidump which is interested in knowing the pstore frontend addresses and sizes from the backend (ram) to be able to register it with

Re: [REBASE PATCH v5 04/17] remoteproc: qcom: Remove minidump related data from qcom_common.c

2023-10-06 Thread Mukesh Ojha
independent from this series. [1] https://lore.kernel.org/all/1696440338-12561-1-git-send-email-quic_mo...@quicinc.com/ -Mukesh On 9/11/2023 4:23 PM, Mukesh Ojha wrote: As minidump specific data structure and functions move under config QCOM_RPROC_MINIDUMP, so remove minidump specific data from

Re: [REBASE PATCH v5 08/17] arm64: mm: Add dynamic ramoops region support through command line

2023-10-05 Thread Mukesh Ojha
On 10/5/2023 5:14 PM, Pavan Kondeti wrote: On Thu, Oct 05, 2023 at 04:52:20PM +0530, Mukesh Ojha wrote: Sorry for the late reply, was on a long vacation. On 9/14/2023 4:47 AM, Kees Cook wrote: On Tue, Sep 12, 2023 at 11:18:20AM +0100, Will Deacon wrote: On Mon, Sep 11, 2023 at 04:23:50PM

Re: [REBASE PATCH v5 08/17] arm64: mm: Add dynamic ramoops region support through command line

2023-10-05 Thread Mukesh Ojha
Sorry for the late reply, was on a long vacation. On 9/14/2023 4:47 AM, Kees Cook wrote: On Tue, Sep 12, 2023 at 11:18:20AM +0100, Will Deacon wrote: On Mon, Sep 11, 2023 at 04:23:50PM +0530, Mukesh Ojha wrote: The reserved memory region for ramoops is assumed to be at a fixed and known

Re: [REBASE PATCH v5 01/17] docs: qcom: Add qualcomm minidump guide

2023-09-13 Thread Mukesh Ojha
On 9/13/2023 2:55 PM, Bagas Sanjaya wrote: On Mon, Sep 11, 2023 at 04:23:43PM +0530, Mukesh Ojha wrote: +Qualcomm APSS Minidump kernel driver concept + +:: + ... +Dump collection

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-13 Thread Mukesh Ojha
On 9/12/2023 12:39 AM, Jeff Johnson wrote: On 9/11/2023 4:07 AM, Krzysztof Kozlowski wrote: On 09/09/2023 22:16, Mukesh Ojha wrote: +/** + * qcom_minidump_region_register() - Register region in APSS Minidump table. + * @region: minidump region. + * + * Return: On success, it returns 0 and

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-13 Thread Mukesh Ojha
On 9/12/2023 3:24 PM, Krzysztof Kozlowski wrote: On 12/09/2023 11:26, Mukesh Ojha wrote: + return -EINVAL; + } + + mutex_init(&md->md_lock); + ret = qcom_apss_md_table_init(md, &mdgtoc->subsystems[MINIDUMP_APSS_DESC]); +

Re: [REBASE PATCH v5 08/17] arm64: mm: Add dynamic ramoops region support through command line

2023-09-13 Thread Mukesh Ojha
Thanks for the response. On 9/12/2023 3:48 PM, Will Deacon wrote: On Mon, Sep 11, 2023 at 04:23:50PM +0530, Mukesh Ojha wrote: The reserved memory region for ramoops is assumed to be at a fixed and known location when read from the devicetree. This may not be required for something like

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-12 Thread Mukesh Ojha
On 9/12/2023 2:56 PM, Mukesh Ojha wrote: Thanks for your time in reviewing this. On 9/11/2023 4:31 PM, Krzysztof Kozlowski wrote: On 09/09/2023 22:16, Mukesh Ojha wrote: Minidump is a best effort mechanism to collect useful and predefined data for first level of debugging on end user

Re: [PATCH v5 09/17] pstore/ram: Use dynamic ramoops reserve resource

2023-09-12 Thread Mukesh Ojha
On 9/12/2023 6:09 AM, Pavan Kondeti wrote: On Mon, Sep 11, 2023 at 04:21:44PM +0530, Mukesh Ojha wrote: On 9/11/2023 11:03 AM, Pavan Kondeti wrote: On Sun, Sep 10, 2023 at 01:46:10AM +0530, Mukesh Ojha wrote: As dynamic ramoops command line parsing is now added, so lets add the support

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-12 Thread Mukesh Ojha
Thanks for your time in reviewing this. On 9/11/2023 4:31 PM, Krzysztof Kozlowski wrote: On 09/09/2023 22:16, Mukesh Ojha wrote: Minidump is a best effort mechanism to collect useful and predefined data for first level of debugging on end user devices running on Qualcomm SoCs. It is built on

Re: [REBASE PATCH v5 15/17] firmware: scm: Modify only the download bits in TCSR register

2023-09-12 Thread Mukesh Ojha
On 9/11/2023 8:37 PM, Kathiravan Thirumoorthy wrote: On 9/11/2023 4:23 PM, Mukesh Ojha wrote: Crashdump collection is based on the DLOAD bit of TCSR register. To retain other bits, we read the register and modify only the DLOAD bit as the other bits have their own significance. Co

[REBASE PATCH v5 01/17] docs: qcom: Add qualcomm minidump guide

2023-09-11 Thread Mukesh Ojha
Add the qualcomm minidump guide for the users which tries to cover the dependency, API use and the way to test and collect minidump on Qualcomm supported SoCs. Signed-off-by: Mukesh Ojha --- Documentation/admin-guide/index.rst | 1 + Documentation/admin-guide/qcom_minidump.rst | 272

[REBASE PATCH v5 13/17] firmware: qcom_scm: provide a read-modify-write function

2023-09-11 Thread Mukesh Ojha
ction. Suggested-by: Srinivas Kandagatla Signed-off-by: Mukesh Ojha Tested-by: Kathiravan Thirumoorthy # IPQ9574 and IPQ5332 --- drivers/firmware/qcom_scm.c| 20 include/linux/firmware/qcom/qcom_scm.h | 2 ++ 2 files changed, 22 insertions(+) diff --git a/dr

[REBASE PATCH v5 15/17] firmware: scm: Modify only the download bits in TCSR register

2023-09-11 Thread Mukesh Ojha
Crashdump collection is based on the DLOAD bit of TCSR register. To retain other bits, we read the register and modify only the DLOAD bit as the other bits have their own significance. Co-developed-by: Poovendhan Selvaraj Signed-off-by: Poovendhan Selvaraj Signed-off-by: Mukesh Ojha Tested-by

[REBASE PATCH v5 00/17] Add Qualcomm Minidump kernel driver related support

2023-09-11 Thread Mukesh Ojha
files starts with md_* downloaded on the x86 machine on given location in PCAT tool from the target device, more about this can be found in qualcomm minidump guide patch. Mukesh Ojha (17): docs: qcom: Add qualcomm minidump guide soc: qcom: Add qcom_rproc_minidump module remoteproc:

[REBASE PATCH v5 17/17] firmware: qcom_scm: Add multiple download mode support

2023-09-11 Thread Mukesh Ojha
Currently, scm driver only supports full dump when download mode is selected. Add support to enable minidump as well as enable it along with fulldump. Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom_scm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers

[REBASE PATCH v5 10/17] pstore: Add pstore_region_defined() helper and export it

2023-09-11 Thread Mukesh Ojha
There are users like Qualcomm minidump which is interested in knowing the pstore frontend addresses and sizes from the backend (ram) to be able to register it with firmware to finally collect them during crash for debugging. Signed-off-by: Mukesh Ojha --- fs/pstore/platform.c | 15

[REBASE PATCH v5 16/17] firmware: qcom_scm: Refactor code to support multiple download mode

2023-09-11 Thread Mukesh Ojha
. Signed-off-by: Mukesh Ojha --- drivers/firmware/Kconfig| 11 - drivers/firmware/qcom_scm.c | 56 +++-- 2 files changed, 49 insertions(+), 18 deletions(-) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index b59e3041fd62

Re: [PATCH v5 09/17] pstore/ram: Use dynamic ramoops reserve resource

2023-09-11 Thread Mukesh Ojha
On 9/11/2023 11:03 AM, Pavan Kondeti wrote: On Sun, Sep 10, 2023 at 01:46:10AM +0530, Mukesh Ojha wrote: As dynamic ramoops command line parsing is now added, so lets add the support in ramoops driver to get the resource structure and add it during platform device registration. Signed-off

[REBASE PATCH v5 14/17] pinctrl: qcom: Use qcom_scm_io_update_field()

2023-09-11 Thread Mukesh Ojha
Use qcom_scm_io_update_field() exported function in pinctrl-msm driver. Signed-off-by: Mukesh Ojha --- drivers/pinctrl/qcom/pinctrl-msm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index

[REBASE PATCH v5 03/17] remoteproc: qcom_q6v5_pas: Use qcom_rproc_minidump()

2023-09-11 Thread Mukesh Ojha
s use qcom_rproc_minidump() and we will be removing qcom_minidump() and minidump related stuff from driver/remoteproc/qcom_common.c . Signed-off-by: Mukesh Ojha --- drivers/remoteproc/Kconfig | 1 + drivers/remoteproc/qcom_q6v5_pas.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)

[REBASE PATCH v5 05/17] init: export linux_banner data variable

2023-09-11 Thread Mukesh Ojha
Some debug loadable module like minidump is interested in knowing the kernel version against which it is being build. Let's export linux_banner. Signed-off-by: Mukesh Ojha --- include/linux/init.h | 3 +++ init/version-timestamp.c | 3 +++ 2 files changed, 6 insertions(+) diff --

[REBASE PATCH v5 02/17] soc: qcom: Add qcom_rproc_minidump module

2023-09-11 Thread Mukesh Ojha
idump() functionality from driver/remoteproc/qcom_common.c into a separate file under qcom_rproc_minidump(). Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/Kconfig | 10 +++ drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/qcom_minidump_internal.h

[REBASE PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-11 Thread Mukesh Ojha
art of ram dump collection. It provides appropriate symbol to register/unregister client regions. To simplify post mortem debugging, it creates and maintain an ELF header as first region that gets updated upon registration of a new region. Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/Kconfig

[REBASE PATCH v5 12/17] MAINTAINERS: Add entry for minidump related files

2023-09-11 Thread Mukesh Ojha
Add the entries into maintainer file for all the minidump related modules. Signed-off-by: Mukesh Ojha --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2833e2da63e0..2ec5fafe7060 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17787,6

[REBASE PATCH v5 11/17] qcom_minidump: Register ramoops region with minidump

2023-09-11 Thread Mukesh Ojha
appropriate place from minidump probe so that they always get registered. While at it also rename the out minidump module object name during build as qcom_apss_minidump which basically depicts as Qualcomm Application processor subsystem minidump. Signed-off-by: Mukesh Ojha --- drivers/soc/qcom

[REBASE PATCH v5 04/17] remoteproc: qcom: Remove minidump related data from qcom_common.c

2023-09-11 Thread Mukesh Ojha
As minidump specific data structure and functions move under config QCOM_RPROC_MINIDUMP, so remove minidump specific data from driver/remoteproc/qcom_common.c . Signed-off-by: Mukesh Ojha --- drivers/remoteproc/qcom_common.c | 160 --- 1 file changed, 160

[REBASE PATCH v5 09/17] pstore/ram: Use dynamic ramoops reserve resource

2023-09-11 Thread Mukesh Ojha
As dynamic ramoops command line parsing is now added, so lets add the support in ramoops driver to get the resource structure and add it during platform device registration. Signed-off-by: Mukesh Ojha --- fs/pstore/ram.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

[REBASE PATCH v5 08/17] arm64: mm: Add dynamic ramoops region support through command line

2023-09-11 Thread Mukesh Ojha
at it can be read by ramoops driver. Signed-off-by: Mukesh Ojha --- arch/arm64/mm/init.c | 94 ++ include/linux/pstore_ram.h | 2 + 2 files changed, 96 insertions(+) diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 8a0f8604348b.

[REBASE PATCH v5 07/17] soc: qcom: minidump: Add pending region registration

2023-09-11 Thread Mukesh Ojha
Pending regions are those apss minidump regions which came for registration before minidump was initialized or ready to do register the region. We can add regions to pending region list and register all of them from apss minidump driver probe in one go. Signed-off-by: Mukesh Ojha --- drivers

Re: [PATCH v5 00/17] Add Qualcomm Minidump kernel driver related support

2023-09-11 Thread Mukesh Ojha
On 9/11/2023 2:22 PM, Bagas Sanjaya wrote: On Sun, Sep 10, 2023 at 01:46:01AM +0530, Mukesh Ojha wrote: Hi All, This is to continuation from the conversation happened at v4 https://lore.kernel.org/lkml/632c5b97-4a91-c3e8-1e6c-33d6c4f64...@quicinc.com/ https://lore.kernel.org/lkml/695133e6

Re: [PATCH v5 11/17] qcom_minidump: Register ramoops region with minidump

2023-09-11 Thread Mukesh Ojha
On 9/11/2023 11:31 AM, Pavan Kondeti wrote: On Sun, Sep 10, 2023 at 01:46:12AM +0530, Mukesh Ojha wrote: Register all the pstore frontend with minidump, so that they can be dumped as default Linux minidump region to be collected on SoC where minidump is enabled. Helper functions is written

[PATCH v5 08/17] arm64: mm: Add dynamic ramoops region support through command line

2023-09-09 Thread Mukesh Ojha
at it can be read by ramoops driver. Signed-off-by: Mukesh Ojha --- arch/arm64/mm/init.c | 94 ++ include/linux/pstore_ram.h | 2 + 2 files changed, 96 insertions(+) diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index d31c3a9290c5.

[PATCH v5 10/17] pstore: Add pstore_region_defined() helper and export it

2023-09-09 Thread Mukesh Ojha
There are users like Qualcomm minidump which is interested in knowing the pstore frontend addresses and sizes from the backend (ram) to be able to register it with firmware to finally collect them during crash for debugging. Signed-off-by: Mukesh Ojha --- fs/pstore/platform.c | 15

[PATCH v5 11/17] qcom_minidump: Register ramoops region with minidump

2023-09-09 Thread Mukesh Ojha
appropriate place from minidump probe so that they always get registered. While at it also rename the out minidump module object name during build as qcom_apss_minidump which basically depicts as Qualcomm Application processor subsystem minidump. Signed-off-by: Mukesh Ojha --- drivers/soc/qcom

[PATCH v5 15/17] firmware: scm: Modify only the download bits in TCSR register

2023-09-09 Thread Mukesh Ojha
Crashdump collection is based on the DLOAD bit of TCSR register. To retain other bits, we read the register and modify only the DLOAD bit as the other bits have their own significance. Co-developed-by: Poovendhan Selvaraj Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom_scm.c | 12

[PATCH v5 17/17] firmware: qcom_scm: Add multiple download mode support

2023-09-09 Thread Mukesh Ojha
Currently, scm driver only supports full dump when download mode is selected. Add support to enable minidump as well as enable it along with fulldump. Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom_scm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v5 16/17] firmware: qcom_scm: Refactor code to support multiple download mode

2023-09-09 Thread Mukesh Ojha
. Signed-off-by: Mukesh Ojha --- drivers/firmware/Kconfig| 11 - drivers/firmware/qcom_scm.c | 56 +++-- 2 files changed, 49 insertions(+), 18 deletions(-) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index b59e3041fd62

[PATCH v5 12/17] MAINTAINERS: Add entry for minidump related files

2023-09-09 Thread Mukesh Ojha
Add the entries into maintainer file for all the minidump related modules. Signed-off-by: Mukesh Ojha --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d590ce31aa72..0595176e76fb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17640,6

[PATCH v5 13/17] firmware: qcom_scm: provide a read-modify-write function

2023-09-09 Thread Mukesh Ojha
ction. Suggested-by: Srinivas Kandagatla Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom_scm.c| 20 include/linux/firmware/qcom/qcom_scm.h | 2 ++ 2 files changed, 22 insertions(+) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c

[PATCH v5 14/17] pinctrl: qcom: Use qcom_scm_io_update_field()

2023-09-09 Thread Mukesh Ojha
Use qcom_scm_io_update_field() exported function in pinctrl-msm driver. Signed-off-by: Mukesh Ojha --- drivers/pinctrl/qcom/pinctrl-msm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index

[PATCH v5 09/17] pstore/ram: Use dynamic ramoops reserve resource

2023-09-09 Thread Mukesh Ojha
As dynamic ramoops command line parsing is now added, so lets add the support in ramoops driver to get the resource structure and add it during platform device registration. Signed-off-by: Mukesh Ojha --- fs/pstore/ram.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

[PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-09 Thread Mukesh Ojha
art of ram dump collection. It provides appropriate symbol to register/unregister client regions. To simplify post mortem debugging, it creates and maintain an ELF header as first region that gets updated upon registration of a new region. Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/Kconfig

[PATCH v5 07/17] soc: qcom: minidump: Add pending region registration

2023-09-09 Thread Mukesh Ojha
Pending regions are those apss minidump regions which came for registration before minidump was initialized or ready to do register the region. We can add regions to pending region list and register all of them from apss minidump driver probe in one go. Signed-off-by: Mukesh Ojha --- drivers

[PATCH v5 04/17] remoteproc: qcom: Remove minidump related data from qcom_common.c

2023-09-09 Thread Mukesh Ojha
As minidump specific data structure and functions move under config QCOM_RPROC_MINIDUMP, so remove minidump specific data from driver/remoteproc/qcom_common.c . Signed-off-by: Mukesh Ojha --- drivers/remoteproc/qcom_common.c | 150 --- 1 file changed, 150

[PATCH v5 05/17] init: export linux_banner data variable

2023-09-09 Thread Mukesh Ojha
Some debug loadable module like minidump is interested in knowing the kernel version against which it is being build. Let's export linux_banner. Signed-off-by: Mukesh Ojha --- include/linux/init.h | 3 +++ init/version-timestamp.c | 3 +++ 2 files changed, 6 insertions(+) diff --

[PATCH v5 01/17] docs: qcom: Add qualcomm minidump guide

2023-09-09 Thread Mukesh Ojha
Add the qualcomm minidump guide for the users which tries to cover the dependency, API use and the way to test and collect minidump on Qualcomm supported SoCs. Signed-off-by: Mukesh Ojha --- Documentation/admin-guide/index.rst | 1 + Documentation/admin-guide/qcom_minidump.rst | 272

[PATCH v5 02/17] soc: qcom: Add qcom_rproc_minidump module

2023-09-09 Thread Mukesh Ojha
idump() functionality from driver/remoteproc/qcom_common.c into a separate file under qcom_rproc_minidump(). Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/Kconfig | 10 +++ drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/qcom_minidump_internal.h

[PATCH v5 00/17] Add Qualcomm Minidump kernel driver related support

2023-09-09 Thread Mukesh Ojha
t Qualcomm package manager kit). After that we will see a bunch of predefined registered region as binary blobs files starts with md_* downloaded on the x86 machine on given location in PCAT tool from the target device, more about this can be found in qualcomm minidump guide patch. Mukesh Ojha

[PATCH v5 03/17] remoteproc: qcom_q6v5_pas: Use qcom_rproc_minidump()

2023-09-09 Thread Mukesh Ojha
s use qcom_rproc_minidump() and we will be removing qcom_minidump() and minidump related stuff from driver/remoteproc/qcom_common.c . Signed-off-by: Mukesh Ojha --- drivers/remoteproc/Kconfig | 1 + drivers/remoteproc/qcom_q6v5_pas.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)