TRCACATRn registers have match bits for secure and non-secure exception
levels which are not accessible by the sysfs API.
This adds a new sysfs parameter to enable this - addr_exlevel_s_ns.
Reviewed-by: Suzuki K Poulose
Signed-off-by: Mike Leach
---
.../coresight/coresight-etm4x-sysfs.c
the user to see the current settings of
the indexed address comparator without resorting to trial and error when
the set type is not known.
Reviewed-by: Mathieu Poirier
Reviewed-by: Leo Yan
Signed-off-by: Mike Leach
---
.../coresight/coresight-etm4x-sysfs.c | 52 +++
1
Add in detailed programmers reference for users wanting to program the
CoreSight ETM 4.x driver using sysfs.
Signed-off-by: Mike Leach
---
.../coresight/coresight-etm4x-reference.rst | 798 ++
1 file changed, 798 insertions(+)
create mode 100644 Documentation/trace/coresight
Update document to include the new sysfs features added during this
patchset.
Updated to reflect the new sysfs component nameing schema.
Signed-off-by: Mike Leach
---
.../testing/sysfs-bus-coresight-devices-etm4x | 183 +++---
1 file changed, 115 insertions(+), 68 deletions
olling TRCVIPCSSCTLR - start stop control by
PE comparators.
3) Default ETM configuration sets a trace all range, and correctly sets
the start-stop status bit. This was not being correctly reflected in
the 'mode' parameter.
Signed-off-by: Mike Leach
---
.../coresight/coresi
Context ID and VM ID masks required 2 value inputs, even when the
second value is ignored as insufficient CID / VMID comparators are
implemented.
Permit a single value to be used if that is sufficient to cover all
implemented comparators.
Reviewed-by: Mathieu Poirier
Signed-off-by: Mike Leach
ther use a 3rd input parameter as the include exclude
value, or if not present use the current value of 'mode'. Do not change
current range when 'mode' changes.
Reviewed-by: Mathieu Poirier
Signed-off-by: Mike Leach
---
.../hwtracing/coresight/coresight-etm4x-sysfs.c| 14
There are two files in the Documentation/trace directory relating to
coresight, with more to follow, so create a Documentation/trace/coresight
directory and move existing files there. Update MAINTAINERS to reference
this sub-directory rather than the individual files.
Signed-off-by: Mike Leach
An API to control single-shot comparator operation was missing from sysfs.
This adds the parameters to sysfs to allow programming of this feature.
Signed-off-by: Mike Leach
---
.../coresight/coresight-etm4x-sysfs.c | 122 ++
drivers/hwtracing/coresight/coresight-etm4x.c
(from reviews by Mathieu and Leo):-
Usability patch split into 2 separate functional patches.
Docs patch split into 3 patches.
Misc style and comment typo fixes.
Mike Leach (11):
coresight: etm4x: Fixes for ETM v4.4 architecture updates.
coresight: etm4x: Fix input validation for sysfs
max before checking min
otherwise wrapped values can set illegal value below min.
4) res_ctrl_store() - update to mask off all res0 bits.
Reviewed-by: Leo Yan
Reviewed-by: Mathieu Poirier
Signed-off-by: Mike Leach
Fixes: a77de2637c9eb ("coresight: etm4x: moving sysFS entries to a dedicated
ETMv4.4 adds in support for tracing secure EL2 (per arch 8.x updates).
Patch accounts for this new capability.
Reviewed-by: Leo Yan
Signed-off-by: Mike Leach
---
.../hwtracing/coresight/coresight-etm4x-sysfs.c | 12 ++--
drivers/hwtracing/coresight/coresight-etm4x.c | 5
Hi Mathieu,
On Tue, 3 Sep 2019 at 20:38, Mathieu Poirier wrote:
>
> Hi Mike,
>
> On Thu, Aug 29, 2019 at 10:33:21PM +0100, Mike Leach wrote:
> > Add in detailed programmers reference for users wanting to program the
> > CoreSight ETM 4.x driver using sysfs.
> >
An API to control single-shot comparator operation was missing from sysfs.
This adds the parameters to sysfs to allow programming of this feature.
Signed-off-by: Mike Leach
---
.../coresight/coresight-etm4x-sysfs.c | 122 ++
drivers/hwtracing/coresight/coresight-etm4x.c
max before checking min
otherwise wrapped values can set illegal value below min.
4) res_ctrl_store() - update to mask off all res0 bits.
Reviewed-by: Leo Yan
Reviewed-by: Mathieu Poirier
Signed-off-by: Mike Leach
---
.../coresight/coresight-etm4x-sysfs.c | 21 ---
1
ther use a 3rd input parameter as the include exclude
value, or if not present use the current value of 'mode'. Do not change
current range when 'mode' changes.
Reviewed-by: Mathieu Poirier
Signed-off-by: Mike Leach
---
.../hwtracing/coresight/coresight-etm4x-sysfs.c| 14
olling TRCVIPCSSCTLR - start stop control by
PE comparators.
3) Default ETM configuration sets a trace all range, and correctly sets
the start-stop status bit. This was not being correctly reflected in
the 'mode' parameter.
Signed-off-by: Mike Leach
---
.../coresight/coresi
the user to see the current settings of
the indexed address comparator without resorting to trial and error when
the set type is not known.
Reviewed-by: Mathieu Poirier
Reviewed-by: Leo Yan
Signed-off-by: Mike Leach
---
.../coresight/coresight-etm4x-sysfs.c | 52 +++
1
Add in detailed programmers reference for users wanting to program the
CoreSight ETM 4.x driver using sysfs.
Signed-off-by: Mike Leach
---
.../coresight/coresight-etm4x-reference.txt | 458 ++
1 file changed, 458 insertions(+)
create mode 100644 Documentation/trace/coresight
Context ID and VM ID masks required 2 value inputs, even when the
second value is ignored as insufficient CID / VMID comparators are
implemented.
Permit a single value to be used if that is sufficient to cover all
implemented comparators.
Reviewed-by: Mathieu Poirier
Signed-off-by: Mike Leach
There are two files in the Documentation/trace directory relating to
coresight, with more to follow, so create a Documentation/trace/coresight
directory and move existing files there. Update MAINTAINERS to reference
this sub-directory rather than the individual files.
Signed-off-by: Mike Leach
ETMv4.4 adds in support for tracing secure EL2 (per arch 8.x updates).
Patch accounts for this new capability.
Reviewed-by: Leo Yan
Signed-off-by: Mike Leach
---
.../hwtracing/coresight/coresight-etm4x-sysfs.c | 12 ++--
drivers/hwtracing/coresight/coresight-etm4x.c | 5
TRCACATRn registers have match bits for secure and non-secure exception
levels which are not accessible by the sysfs API.
This adds a new sysfs parameter to enable this - addr_exlevel_s_ns.
Signed-off-by: Mike Leach
---
.../coresight/coresight-etm4x-sysfs.c | 42 +++
1
Update document to include the new sysfs features added during this
patchset.
Updated to reflect the new sysfs component nameing schema.
Signed-off-by: Mike Leach
---
.../testing/sysfs-bus-coresight-devices-etm4x | 183 +++---
1 file changed, 115 insertions(+), 68 deletions
since v1 (from reviews by Mathieu and Leo):-
Usability patch split into 2 separate functional patches.
Docs patch split into 3 patches.
Misc style and comment typo fixes.
Mike Leach (11):
coresight: etm4x: Fixes for ETM v4.4 architecture updates.
coresight: etm4x: Fix input validation for
+drvdata->edcidsr_present = false;
>> >+ drvdata->edvidsr_present = false;
>> >+} else if (mode == EDDEVID_IMPL_EDPCSR) {
>> >+drvdata->edpcsr_present = true;
>> >+drvdata->edcidsr_present = false;
;> > + debug_disable_func();
>> > +}
>> > +
>> > +static int debug_probe(struct amba_device *adev, const struct amba_id *id)
>> > +{
>> > + void __iomem *base;
>> > + struct device *dev = &adev->dev;
>> > +
es in the STM trace is by channel number allocations only.
Best Regards
Mike.
----
Mike Leach +44 (0)1254 893911 (Direct)
Principal Engineer +44 (0)1254 893900 (Main)
Arm Blackburn Design Centre
28 matches
Mail list logo
