Re: [PATCH v2 7/8] scsi: sr: workaround VMware ESXi cdrom emulation bug

2019-10-23 Thread Michal Suchánek
On Wed, Oct 23, 2019 at 04:13:15PM +0200, Hannes Reinecke wrote: > On 10/23/19 2:52 PM, Michal Suchanek wrote: > > The WMware ESXi cdrom identifies itself as: > > sr 0:0:0:0: [sr0] scsi3-mmc drive: vendor: "NECVMWarVMware SATA CD001.00" > > model: "VMware SATA CD001.00" > > with the following get_c

Re: [PATCH resend 3/6] cdrom: wait for tray to close

2019-10-23 Thread Michal Suchánek
On Mon, Jan 29, 2018 at 05:05:47PM +, Bart Van Assche wrote: > On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote: > > +static int cdrom_tray_close(struct cdrom_device_info *cdi) > > +{ > > + int ret; > > + > > + ret = cdi->ops->tray_move(cdi, 0); > > + if (ret || !cdi->ops->drive_s

Re: [PATCH resend 3/6] cdrom: wait for tray to close

2018-01-31 Thread Michal Suchánek
On Mon, 29 Jan 2018 17:05:47 + Bart Van Assche wrote: > On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote: > > +static int cdrom_tray_close(struct cdrom_device_info *cdi) > > +{ > > + int ret; > > + > > + ret = cdi->ops->tray_move(cdi, 0); > > + if (ret || !cdi->ops->drive_status

Re: [PATCH resend 0/6] Fix cdrom autoclose

2018-01-27 Thread Michal Suchánek
On Fri, 26 Jan 2018 12:04:56 -0800 James Bottomley wrote: > On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote: > > First time I did not get any feedback for the patches. > > This is likely because no-one who might inspect the code saw the > patches ... what list are they going to?  I'm

Re: [PATCH 6/6] Documentation/admin-guide: single quotes in kernel arguments.

2017-09-25 Thread Michal Suchánek
On Fri, 15 Sep 2017 10:59:00 -0700 Randy Dunlap wrote: > On 09/15/17 10:02, Michal Suchanek wrote: > > Signed-off-by: Michal Suchanek > > --- > > Documentation/admin-guide/kernel-parameters.rst | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/ad

Re: [PATCH 1/6] lib/cmdline.c: Add backslash support to kernel commandline parsing.

2017-09-25 Thread Michal Suchánek
On Fri, 15 Sep 2017 19:28:56 +0200 Michal Suchánek wrote: > On Fri, 15 Sep 2017 18:14:09 +0100 > Al Viro wrote: > > > On Fri, Sep 15, 2017 at 07:02:46PM +0200, Michal Suchanek wrote: > > > > > for (i = 0; args[i]; i++) { > > > -

Re: [PATCH 1/6] lib/cmdline.c: Add backslash support to kernel commandline parsing.

2017-09-15 Thread Michal Suchánek
On Fri, 15 Sep 2017 18:14:09 +0100 Al Viro wrote: > On Fri, Sep 15, 2017 at 07:02:46PM +0200, Michal Suchanek wrote: > > > for (i = 0; args[i]; i++) { > > - if (isspace(args[i]) && !in_quote) > > + if (isspace(args[i]) && !in_quote && !backslash) > > b

Re: [PATCH v7 3/4] lib/cmdline.c Remove quotes symmetrically.

2017-08-21 Thread Michal Suchánek
On Mon, 21 Aug 2017 18:27:12 +0800 Baoquan He wrote: > On 08/17/17 at 10:14pm, Michal Suchanek wrote: > > Remove quotes from argument value only if there is qoute on both > > sides. > > > > Signed-off-by: Michal Suchanek > > Sounds reasonable. Just for curiosity, do we have chance to pass in

Re: [PATCH v7 1/4] powerpc/fadump: reduce memory consumption for capture kernel

2017-08-18 Thread Michal Suchánek
On Fri, 18 Aug 2017 16:20:53 +0530 Hari Bathini wrote: > Hi Michal, > > > Thanks for the patches. I tried testing with the patches: > > [0.00] fadump: Firmware-assisted dump is active. > [0.00] fadump: Modifying command line to enforce the > additional parameters passed through

Re: [PATCH v4 RFT 1/2] powerpc/fadump: reduce memory consumption for capture kernel

2017-05-10 Thread Michal Suchánek
On Wed, 3 May 2017 12:43:33 +0530 Hari Bathini wrote: > On Tuesday 02 May 2017 09:26 PM, Michal Suchanek wrote: > > With fadump (dump capture) kernel booting like a regular kernel, it > > almost needs the same amount of memory to boot as the production > > kernel, which is unwarranted for a dump