approaches that could help with it, I'd be happy to
write something simpler/more discreet.
Thanks for the suggestions and discussions.
[1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2016-June/144196.html
--
Mauricio Faria de Oliveira
IBM Linux Technology Center
--
To unsubscribe from
to), but it wasn't accepted [1]; so
I guess it apparently is, in some cases.
[1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2016-June/144196.html
thanks
--
Mauricio Faria de Oliveira
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-d
in nvme_map_data() - they can return either
BLK_MQ_RQ_QUEUE_BUSY or BLK_MQ_RQ_QUEUE_ERROR - so the former is OK.)
Does that make sense?
Thanks for the review.
--
Mauricio Faria de Oliveira
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe lin
tch.pl (line wrapping and typos)
Tested on next-20160801.
Mauricio Faria de Oliveira (3):
dma-mapping: introduce the DMA_ATTR_NO_WARN attribute
powerpc: implement the DMA_ATTR_NO_WARN attribute
nvme: use the DMA_ATTR_NO_WARN attribute
Documentation/DMA-attributes.txt | 17 +
Introduce the DMA_ATTR_NO_WARN attribute, and document it.
Signed-off-by: Mauricio Faria de Oliveira
---
Documentation/DMA-attributes.txt | 17 +
include/linux/dma-mapping.h | 5 +
2 files changed, 22 insertions(+)
diff --git a/Documentation/DMA-attributes.txt b
Use the DMA_ATTR_NO_WARN attribute for the dma_map_sg() call of the nvme
driver that returns BLK_MQ_RQ_QUEUE_BUSY (not for BLK_MQ_RQ_QUEUE_ERROR).
Signed-off-by: Mauricio Faria de Oliveira
Reviewed-by: Gabriel Krisman Bertazi
---
drivers/nvme/host/pci.c | 3 ++-
1 file changed, 2 insertions
Add support for the DMA_ATTR_NO_WARN attribute on powerpc iommu code.
Signed-off-by: Mauricio Faria de Oliveira
---
arch/powerpc/kernel/iommu.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c
index 37d6e74
Add support for the DMA_ATTR_NO_WARN attribute on powerpc iommu code.
Signed-off-by: Mauricio Faria de Oliveira
---
Changelog:
v3:
- powerpc: none
v2:
- all: address warnings from checkpatch.pl (line wrapping and typos)
arch/powerpc/kernel/iommu.c | 6 --
1 file changed, 4 insertions
gelog:
v3:
- nvme: use DMA_ATTR_NO_WARN when ret = BLK_MQ_RQ_QUEUE_BUSY (io will be
requeued) but not when ret = BLK_MQ_RQ_QUEUE_ERROR (io will be failed).
thanks: Masayoshi Mizuma
v2:
- all: address warnings from checkpatch.pl (line wrapping and typos)
Mauricio Faria de Olive
Use the DMA_ATTR_NO_WARN attribute on dma_map_sg() calls of nvme driver.
Signed-off-by: Mauricio Faria de Oliveira
Reviewed-by: Gabriel Krisman Bertazi
---
Changelog:
v3:
- nvme: use DMA_ATTR_NO_WARN when ret = BLK_MQ_RQ_QUEUE_BUSY (io will be
requeued) but not when ret
Introduce the DMA_ATTR_NO_WARN attribute, and document it.
Signed-off-by: Mauricio Faria de Oliveira
---
Changelog:
v3:
- dma: none.
v2:
- all: address warnings from checkpatch.pl (line wrapping and typos)
Documentation/DMA-attributes.txt | 17 +
include/linux/dma-attrs.h
On 07/08/2016 04:54 AM, Masayoshi Mizuma wrote:
Here, I think the error messages should not be suppressed because
the return value of nvme_map_data() is BLK_MQ_RQ_QUEUE_ERROR, so
the IO returns as -EIO.
Agree; good point. fixed in v3.
Thanks for reviewing.
--
Mauricio Faria de Oliveira
IBM
On 07/06/2016 09:41 PM, Gabriel Krisman Bertazi wrote:
checkpatch.pl complains about line wrapping. Other than that, this
looks good to me.
I'll submit a v2 w/ that and typos fixed.
Thanks for reviewing.
--
Mauricio Faria de Oliveira
IBM Linux Technology Center
--
To unsubscribe from
Add support for the DMA_ATTR_NO_WARN attribute on powerpc iommu code.
Signed-off-by: Mauricio Faria de Oliveira
---
Changelog:
v2:
- address warnings from checkpatch.pl (line wrapping and typos)
arch/powerpc/kernel/iommu.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
Introduce the DMA_ATTR_NO_WARN attribute, and document it.
Signed-off-by: Mauricio Faria de Oliveira
---
Changelog:
v2:
- address warnings from checkpatch.pl (line wrapping and typos)
Documentation/DMA-attributes.txt | 17 +
include/linux/dma-attrs.h| 1 +
2 files
Use the DMA_ATTR_NO_WARN attribute on dma_map_sg() calls of nvme driver.
Signed-off-by: Mauricio Faria de Oliveira
Reviewed-by: Gabriel Krisman Bertazi
---
Changelog:
v2:
- address warnings from checkpatch.pl (line wrapping and typos)
drivers/nvme/host/pci.c | 12 ++--
1 file
v2:
- address warnings from checkpatch.pl (line wrapping and typos)
Mauricio Faria de Oliveira (3):
dma: introduce DMA_ATTR_NO_WARN
nvme: implement DMA_ATTR_NO_WARN
powerpc: implement DMA_ATTR_NO_WARN
Documentation/DMA-attributes.txt | 17 +
arch/powerpc/kernel/iommu.c
Use the DMA_ATTR_NO_WARN attribute on dma_map_sg() calls of nvme driver.
Signed-off-by: Mauricio Faria de Oliveira
---
drivers/nvme/host/pci.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d1a8259..c3c3348
Introduce the DMA_ATTR_NO_WARN attribute, and document it.
Signed-off-by: Mauricio Faria de Oliveira
---
Documentation/DMA-attributes.txt | 17 +
include/linux/dma-attrs.h| 1 +
2 files changed, 18 insertions(+)
diff --git a/Documentation/DMA-attributes.txt b
Add support for the DMA_ATTR_NO_WARN attribute on powerpc iommu code.
Signed-off-by: Mauricio Faria de Oliveira
---
arch/powerpc/kernel/iommu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c
index a8e3490
ystem logs
with error messages at least on powerpc: "iommu_alloc failed")
- Patch 3/3 implements support for it on powerpc arch (where this problem
was observed. It's possible to extend support for more archs
if the patchset is welcome).
Mauricio Far
21 matches
Mail list logo
