The code in the example does not build for a few trivial errors: type
mismatch in callback, missing semicolon. Fix them to help newcomers using
the example as a starting point.
Signed-off-by: Luca Ceresoli
---
Documentation/driver-api/pinctl.rst | 6 +++---
1 file changed, 3 insertions(+), 3
Hi Hans,
On 14/06/19 09:14, Hans Verkuil wrote:
> On 6/13/19 4:18 PM, Luca Ceresoli wrote:
>> This sentence renders as:
>>
>>> Since such compound controls need to expose more information about
>>> themselves than is possible with ioctls VIDIOC_QUERYCT
_EXT_CTRL
^ ^
> ioctl was added.
This does not make sense. Fix by providing an explicit link text. This
results in:
> Since such compound controls need to expose more information about
> themselves than is possible with VIDIOC_QUERYCTRL the
> VIDIOC_QUERY_EXT_CTRL ioctl was added.
Signed-
from the code.
Signed-off-by: Luca Ceresoli
---
Documentation/media/kapi/v4l2-controls.rst | 40 +-
1 file changed, 17 insertions(+), 23 deletions(-)
diff --git a/Documentation/media/kapi/v4l2-controls.rst
b/Documentation/media/kapi/v4l2-controls.rst
index 0c3f486727ed.
The tutorial in this section is almost complete, add the one missing bit.
Signed-off-by: Luca Ceresoli
---
Documentation/media/kapi/v4l2-controls.rst | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/media/kapi/v4l2-controls.rst
b/Documentation/media/kapi/v4l2-controls.rst
Fix indentation in example C code.
Signed-off-by: Luca Ceresoli
---
Documentation/media/uapi/v4l/extended-controls.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/media/uapi/v4l/extended-controls.rst
b/Documentation/media/uapi/v4l/extended-controls.rst
Mentioning :ref:`VIDIOC_QUERYCTRL` renders all the three related ioctls.
Explicitly adding VIDIOC_QUERY_EXT_CTRL and VIDIOC_QUERYMENU will make
them render twice, so remove them
Signed-off-by: Luca Ceresoli
---
Documentation/media/uapi/v4l/extended-controls.rst | 4 +---
1 file changed, 1
tl was added.
Signed-off-by: Luca Ceresoli
---
Documentation/media/uapi/v4l/extended-controls.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/media/uapi/v4l/extended-controls.rst
b/Documentation/media/uapi/v4l/extended-controls.rst
index 24274b398e63..0968
This section lacks links to struct definitions. Add one where each struct
is introduced.
Signed-off-by: Luca Ceresoli
---
Documentation/media/kapi/v4l2-controls.rst | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/Documentation/media/kapi/v4l2-controls.rst
All these code blocks contain C code, enable C formatting for a nicer
reading.
Signed-off-by: Luca Ceresoli
---
Documentation/media/kapi/v4l2-controls.rst | 74 +++---
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/Documentation/media/kapi/v4l2-controls.rst
b
ding a few paragraphs later
anyway:
> You’re done! And this is sufficient for most of the drivers we have. No
> need to do any validation of control values, or implement QUERYCTRL,
> QUERY_EXT_CTRL and QUERYMENU. And G/S_CTRL as well as G/TRY/S_EXT_CTRLS
> are automatically supported
This section lacks links to functions. Add one to simplify reading.
Signed-off-by: Luca Ceresoli
---
Documentation/media/kapi/v4l2-controls.rst | 67 +++---
1 file changed, 35 insertions(+), 32 deletions(-)
diff --git a/Documentation/media/kapi/v4l2-controls.rst
b
The clk_foo_ops struct example has syntax errors. Fix it so it can be
copy-pasted and used more easily.
Signed-off-by: Luca Ceresoli
---
Documentation/driver-api/clk.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/driver-api/clk.rst b/Documentation
13 matches
Mail list logo