t; > > > setup of platform devices and interrupt distribution for the subdevices.
> > > >
> > > > Serial portion: Acked-by: Greg Kroah-Hartman
> > > >
> > > > Acked-for-MFD-by: Lee Jones
> > > >
> > > > Signed-off
new MFD driver, which takes care of card detection,
> > setup of platform devices and interrupt distribution for the subdevices.
> >
> > Serial portion: Acked-by: Greg Kroah-Hartman
> > Acked-for-MFD-by: Lee Jones
> >
> > Signed-off-by: Thomas Bogendoerfer
struct ioc3 __iomem *regs = ipd->regs;
> + u32 pending, mask;
> + unsigned int irq;
> +
> + pending = readl(®s->sio_ir);
> + mask = readl(®s->sio_ies);
> + pending &= mask; /* mask off not enabled but pending irqs */
> +
> + if (mask & BIT(IOC3_IRQ_ETH_DOMAIN))
> + /* if eth irq is enabled we need to check in eth irq regs */
Nit: Comments should be expressive. Please expand all of the
short-hand in this sentence. It would also be nicer if you started
with an uppercase character.
Same with all of the other comments in this file.
Other than that, it looks like it's really coming together. Once the
above is fixed, please re-sumbit with my:
For my own reference:
Acked-for-MFD-by: Lee Jones
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
->start);
> >~~~~~~~~~~
>
> I assume you plan on fixing this Thomas?
Ah, I see the new set - ignore this.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
int', but argument 4 has type 'resource_size_t
> >> {aka unsigned int}' [-Wformat=]
>sizeof(ioc3_w1_platform_data.dev_id), "ioc3-%012llx",
>~~^
> %012x
>ipd->pdev->resource->start);
>~~
I assume you plan on fixing this Thomas?
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
gt; 9 files changed, 235 insertions(+)
> create mode 100644 drivers/counter/cros_ec_sensors_sync.c
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Thu, 27 Jun 2019, Paul Cercueil wrote:
> Le jeu. 27 juin 2019 à 8:58, Lee Jones a écrit :
> > On Wed, 26 Jun 2019, Paul Cercueil wrote:
> > > Le mer. 26 juin 2019 à 15:18, Lee Jones a
> > > écrit :
> > > > On Tue, 21 May 2019, Paul Cercueil wrote
On Wed, 26 Jun 2019, Paul Cercueil wrote:
> Le mer. 26 juin 2019 à 15:18, Lee Jones a écrit :
> > On Tue, 21 May 2019, Paul Cercueil wrote:
> >
> > > This driver will provide a regmap that can be retrieved very early
> > > in
> > >
nclude/linux/mfd/ingenic-tcu.h b/include/linux/mfd/ingenic-tcu.h
> index 2083fa20821d..21df23916cd2 100644
> --- a/include/linux/mfd/ingenic-tcu.h
> +++ b/include/linux/mfd/ingenic-tcu.h
> @@ -6,6 +6,11 @@
> #define __LINUX_MFD_INGENIC_TCU_H_
>
> #include
> +#include
> +
> +struct device;
> +struct device_node;
> +struct regmap;
>
> #define TCU_REG_WDT_TDR 0x00
> #define TCU_REG_WDT_TCER 0x04
> @@ -53,4 +58,7 @@
> #define TCU_REG_TCNTc(c) (TCU_REG_TCNT0 + ((c) * TCU_CHANNEL_STRIDE))
> #define TCU_REG_TCSRc(c) (TCU_REG_TCSR0 + ((c) * TCU_CHANNEL_STRIDE))
>
> +struct regmap * __init ingenic_tcu_get_regmap(struct device_node *np);
> +bool ingenic_tcu_pwm_can_use_chn(struct device *dev, unsigned int channel);
> +
> #endif /* __LINUX_MFD_INGENIC_TCU_H_ */
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
l. Simply
removing all useful prints regardless of log-level is not the way to
go IMHO.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Wed, 05 Jun 2019, Greg Kroah-Hartman wrote:
> On Wed, Jun 05, 2019 at 09:40:02AM +0100, Lee Jones wrote:
> > On Wed, 05 Jun 2019, Greg Kroah-Hartman wrote:
> >
> > > On Wed, Jun 05, 2019 at 07:48:39AM +0100, Lee Jones wrote:
> > > > On Tue, 04 Jun 2019, Gr
On Wed, 05 Jun 2019, Greg Kroah-Hartman wrote:
> On Wed, Jun 05, 2019 at 07:48:39AM +0100, Lee Jones wrote:
> > On Tue, 04 Jun 2019, Greg Kroah-Hartman wrote:
> > > On Tue, Jun 04, 2019 at 11:39:21AM -0700, Guenter Roeck wrote:
> > > > On Tue, Jun 4, 2019
nel log, I don't have it.
"Oh wow, I didn't know I had XXX functionality on this platform."
In my real job, I am currently enabling some newly released AArch64
based laptops for booting with ACPI. I must have wasted a day whilst
enabling some of the devices the system relies upon, just to find
out that 90% of them were actually probing semi-fine (at least probe()
was succeeding), just silently. *grumble*
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Tue, 18 Dec 2018, Jae Hyun Yoo wrote:
> This commit adds a dt-bindings document for PECI client MFD.
>
> Cc: Lee Jones
> Cc: Rob Herring
> Cc: Mark Rutland
> Cc: Andrew Jeffery
> Cc: James Feist
> Cc: Jason M Biils
> Cc: Joel Stanley
> Cc: Vernon Mauery
On Tue, 18 Dec 2018, Jae Hyun Yoo wrote:
> This commit adds PECI client MFD driver.
>
> Cc: Lee Jones
> Cc: Randy Dunlap
> Cc: Rob Herring
> Cc: Andrew Jeffery
> Cc: James Feist
> Cc: Jason M Biils
> Cc: Joel Stanley
> Cc: Vernon Mauery
> Signed-off-by: J
On Mon, 03 Dec 2018, Matti Vaittinen wrote:
>
> Hi de Ho Lee,
>
> On Mon, Dec 03, 2018 at 12:19:51PM +0000, Lee Jones wrote:
> > > Series add bd71837/bd71837 PMIC clock support + managed interfaces
> >
> > You've send me a cover letter and no patches.
ed, 325 insertions(+), 79 deletions(-)
> create mode 100644 drivers/clk/clk-bd718x7.c
You've send me a cover letter and no patches.
I suggest that I should not be on the addressee list at all for this.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Wed, 24 Oct 2018, Jae Hyun Yoo wrote:
> On 10/24/2018 3:59 AM, Lee Jones wrote:
> > On Tue, 18 Sep 2018, Jae Hyun Yoo wrote:
> >
> > > This commit adds PECI client MFD driver.
> > >
>
>
[...]
> > > +bool peci_temp_need_update(struct t
On Tue, 18 Sep 2018, Jae Hyun Yoo wrote:
> This commit adds PECI client MFD driver.
>
> Cc: Lee Jones
> Cc: Randy Dunlap
> Cc: Rob Herring
> Cc: Andrew Jeffery
> Cc: James Feist
> Cc: Jason M Biils
> Cc: Joel Stanley
> Cc: Vernon Mauery
> Signed-off-by: J
On Tue, 18 Sep 2018, Jae Hyun Yoo wrote:
> This commit adds a dt-bindings document for PECI client MFD.
>
> Cc: Lee Jones
> Cc: Rob Herring
> Cc: Mark Rutland
> Cc: Andrew Jeffery
> Cc: James Feist
> Cc: Jason M Biils
> Cc: Joel Stanley
> Cc: Vernon Mauery
t;> [ ... ]
Paul,
I think there is something wrong with your mailer since your replies
are being scattered across my inbox un-threaded, making conversations
very difficult to follow.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
+-
> drivers/mfd/timberdale.c | 2 +-
> include/linux/{ => platform_data}/i2c-ocores.h | 0
> 4 files changed, 3 insertions(+), 3 deletions(-)
> rename include/linux/{ => platform_data}/i2c-ocores.h (100%)
Acked-by: Lee Jones
--
Lee Jones [李琼斯]
Linaro Services Tec
On Wed, 01 Nov 2017, Rafael J. Wysocki wrote:
> On Wed, Nov 1, 2017 at 10:28 AM, Lee Jones wrote:
> > On Tue, 31 Oct 2017, Rafael J. Wysocki wrote:
> >
> >> On Tue, Oct 31, 2017 at 4:09 PM, Lee Jones wrote:
> >> > On Mon, 16 Oct 2017, Rafael J. Wysocki
On Tue, 31 Oct 2017, Rafael J. Wysocki wrote:
> On Tue, Oct 31, 2017 at 4:09 PM, Lee Jones wrote:
> > On Mon, 16 Oct 2017, Rafael J. Wysocki wrote:
> >
> >> From: Rafael J. Wysocki
> >>
> >> Make the intel-lpss driver set DPM_FLAG_SMART_SUSPEND for its
nsertions(+), 1 deletion(-)
Is this patch independent?
For my own reference:
Acked-for-MFD-by: Lee Jones
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the lin
trol behavior. Add the explicit API calls to the devres list.
>
> Cc: Jonathan Corbet
> Cc: Lee Jones
> Cc: linux-doc@vger.kernel.org
> Signed-off-by: Philipp Zabel
> ---
> Documentation/driver-model/devres.txt | 7 ++-
> 1 file changed, 6 insertions(+), 1 del
On Wed, 13 Apr 2016, Lee Jones wrote:
> On Tue, 12 Apr 2016, Thierry Reding wrote:
>
> > On Tue, Apr 12, 2016 at 03:16:13PM +0100, Lee Jones wrote:
> > > On Tue, 12 Apr 2016, Thierry Reding wrote:
> > >
> > > > On Wed, Mar 30, 2016 at 10:03:26PM +
On Tue, 12 Apr 2016, Thierry Reding wrote:
> On Tue, Apr 12, 2016 at 03:16:13PM +0100, Lee Jones wrote:
> > On Tue, 12 Apr 2016, Thierry Reding wrote:
> >
> > > On Wed, Mar 30, 2016 at 10:03:26PM +0200, Boris Brezillon wrote:
> > > > pwm->period field is
Signed-off-by: Boris Brezillon
> > ---
> > drivers/video/backlight/lm3630a_bl.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Applied, thanks.
Applied?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for A
; > Signed-off-by: Boris Brezillon
> > Acked-by: Lee Jones
> > ---
> > drivers/video/backlight/pwm_bl.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Applied, thanks.
Applied?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Lin
_irq_exit(tps65910);
> @@ -528,7 +528,6 @@ static int tps65910_i2c_remove(struct i2c_client *i2c)
> struct tps65910 *tps65910 = i2c_get_clientdata(i2c);
>
> tps65910_irq_exit(tps65910);
> - mfd_remove_devices(tps65910->dev);
>
> return 0;
> }
--
L
truct i2c_device_id wm8400_i2c_id[] = {
> { "wm8400", 0 },
> { }
> @@ -196,7 +178,6 @@ static struct i2c_driver wm8400_i2c_driver = {
> .name = "WM8400",
> },
> .probe= wm8400_i2c_probe,
> - .remove = wm8400_i2c_
nt rk808_remove(struct i2c_client *client)
> struct rk808 *rk808 = i2c_get_clientdata(client);
>
> regmap_del_irq_chip(client->irq, rk808->irq_data);
> - mfd_remove_devices(&client->dev);
> pm_power_off = NULL;
>
> return 0;
--
Lee Jon
nst struct i2c_device_id sky81452_ids[] = {
> { "sky81452" },
> { }
> @@ -97,7 +92,6 @@ static struct i2c_driver sky81452_driver = {
> .of_match_table = of_match_ptr(sky81452_of_match),
> },
> .probe = sky81452_probe,
> - .remove = sky81452_remove,
&g
dev_err(&i2c->dev, "failed to add sub-devices: %d\n", ret);
> return ret;
> @@ -102,7 +102,6 @@ static int rn5t618_i2c_remove(struct i2c_client *i2c)
> pm_power_off = NULL;
> }
>
> - mfd_remove_devices(&i2c->de
; -}
> -
> static const struct of_device_id mt6397_of_match[] = {
> { .compatible = "mediatek,mt6397" },
> { .compatible = "mediatek,mt6323" },
> @@ -334,7 +329,6 @@ MODULE_DEVICE_TABLE(platform, mt6397_id);
>
> static struct platform_driver
return 0;
> -}
> -
> static const struct i2c_device_id rt5033_i2c_id[] = {
> { "rt5033", },
> { }
> @@ -135,7 +128,6 @@ static struct i2c_driver rt5033_driver = {
> .of_match_table = of_match_ptr(rt5033_dt_match),
> },
> .probe = rt5033_i2c_probe,
> -
LL, 0, NULL);
> }
>
> static const struct pci_device_id rdc321x_sb_table[] = {
> @@ -105,7 +101,6 @@ static struct pci_driver rdc321x_sb_driver = {
> .name = "RDC321x Southbridge",
> .id_table = rdc321x_sb_table,
> .probe = rdc321x_sb_p
truct i2c_driver tps65217_driver = {
> },
> .id_table = tps65217_id_table,
> .probe = tps65217_probe,
> - .remove = tps65217_remove,
> };
>
> static int __init tps65217_init(void)
--
Lee Jones
Linaro STMicroelectronics Landing Team Le
amp;client->dev);
> - return 0;
> -}
> -
> /*
> * This ID table is completely unused, as this is a pure
> * device-tree probed driver, but it has to be here due to
> @@ -246,7 +240,6 @@ static struct i2c_driver stw481x_driver = {
> .of_match_table = stw
d tps6507x_i2c_id[] = {
> @@ -132,7 +124,6 @@ static struct i2c_driver tps6507x_i2c_driver = {
> .of_match_table = of_match_ptr(tps6507x_of_match),
> },
> .probe = tps6507x_i2c_probe,
> - .remove = tps6507x_i2c_remove,
> .id_table = tps6507x_
90xx_of_match),
> },
> .probe = bcm590xx_i2c_probe,
> - .remove = bcm590xx_i2c_remove,
> .id_table = bcm590xx_i2c_id,
> };
> module_i2c_driver(bcm590xx_i2c_driver);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for
" },
> { }
> @@ -122,7 +116,6 @@ static struct i2c_driver menf21bmc_driver = {
> .driver.name= "menf21bmc",
> .id_table = menf21bmc_id_table,
> .probe = menf21bmc_probe,
> - .remove = menf21bmc_remove,
> };
>
.of_match_table = of_match_ptr(as3711_of_match),
> },
> .probe = as3711_i2c_probe,
> - .remove = as3711_i2c_remove,
> .id_table = as3711_i2c_id,
> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM
ation/driver-model/devres.txt
> +++ b/Documentation/driver-model/devres.txt
> @@ -317,6 +317,9 @@ MEM
>devm_kvasprintf()
>devm_kzalloc()
>
> +MFD
> + devm_mfd_add_devices()
> +
> PCI
>pcim_enable_device() : after success, all PCI ops become managed
>
st struct of_device_id atmel_hlcdc_match[] = {
> @@ -152,7 +145,6 @@ MODULE_DEVICE_TABLE(of, atmel_hlcdc_match);
>
> static struct platform_driver atmel_hlcdc_driver = {
> .probe = atmel_hlcdc_probe,
> - .remove = atmel_hlcdc_remove,
> .driver = {
>
> @@ -151,7 +144,6 @@ MODULE_DEVICE_TABLE(of, lp3943_of_match);
>
> static struct i2c_driver lp3943_driver = {
> .probe = lp3943_probe,
> - .remove = lp3943_remove,
> .driver = {
> .name = "lp3943",
> .of_match_table = of_matc
5,6 @@ static struct i2c_driver act8945a_i2c_driver = {
> .of_match_table = of_match_ptr(act8945a_of_match),
> },
> .probe = act8945a_i2c_probe,
> - .remove = act8945a_i2c_remove,
> .id_table = act8945a_i2c_id,
> };
>
--
Lee Jones
Linar
8,6 @@ static struct platform_driver hi6421_pmic_driver = {
> .of_match_table = of_hi6421_pmic_match_tbl,
> },
> .probe = hi6421_pmic_probe,
> - .remove = hi6421_pmic_remove,
> };
> module_platform_driver(hi6421_pmic_driver);
>
--
Lee Jones
Linaro STMicroel
re.h
> @@ -131,4 +131,8 @@ static inline int mfd_add_hotplug_devices(struct device
> *parent,
>
> extern void mfd_remove_devices(struct device *parent);
>
> +extern int devm_mfd_add_devices(struct device *dev, int id,
> + const struct mfd_cell *cells, int n_de
On Thu, 07 Apr 2016, Laxman Dewangan wrote:
> Hi Lee,
> Thanks for review.
> I will send another patch with incorporating your comments.
>
>
> On Thursday 07 April 2016 04:14 PM, Lee Jones wrote:
> >On Tue, 05 Apr 2016, Laxman Dewangan wrote:
> >
> >+if
a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -131,4 +131,11 @@ static inline int mfd_add_hotplug_devices(struct device
> *parent,
>
> extern void mfd_remove_devices(struct device *parent);
>
> +extern int devm_mfd_add_devices(struct device *dev, int id
52 matches
Mail list logo
