On 05/02/2025 15:52, Yanteng Si wrote:
>
> 在 2/5/25 22:23, Krzysztof Kozlowski 写道:
>> On 05/02/2025 08:37, Yanteng Si wrote:
>>>
>>>
>>> 在 2025/2/4 01:46, Jakub Kicinski 写道:
>>>> Adding company name in round brackets to From/SoB lines
>>&g
On 05/02/2025 08:37, Yanteng Si wrote:
>
>
>
> 在 2025/2/4 01:46, Jakub Kicinski 写道:
>> Adding company name in round brackets to From/SoB lines
>> is fairly common, but I don't see it documented anywhere.
>> Every now and then people try to add the sponsorship lines
>> to the commit message, fun
han
> Acked-by: Dan Williams
> Signed-off-by: Miguel Ojeda
> ---
> Documentation/process/submitting-patches.rst | 12 ++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
Acked-by: Krzysztof Kozlowski
Best regards,
Krzysztof
te this clearly.
>
> Link:
> https://lore.kernel.org/rust-for-linux/caeg-je-h4nitwb2erfgcoqt0kqfxuykwlhpnnhcdrzzdxi0...@mail.gmail.com/
> [1]
> Suggested-by: Dan Williams
> Acked-by: Shuah Khan
> Acked-by: Dan Williams
> Signed-off-by: Miguel Ojeda
Acked-by: Krzysztof Kozlowski
Best regards,
Krzysztof
s given above, in the previous commit.
>
Acked-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On 12/01/2025 16:50, Neal Gompa wrote:
> On Sun, Jan 12, 2025 at 10:30 AM Miguel Ojeda wrote:
>>
>> Newcomers to the kernel need to learn the different tags that are
>> used in commit messages and when to apply them. Acked-by is sometimes
>> misunderstood, since the documentation did not really cl
On Wed, Jan 08, 2025 at 09:47:08PM +0800, Luo Jie wrote:
> +required:
> + - clocks
> + - clock-names
> + - resets
> + - interrupts
> + - interrupt-names
> +
> + ethernet-ports:
This device really looks like DSA or other ethernet switch, so I would
really expect proper
On 07/10/2024 19:18, Jonathan Corbet wrote:
>>
>> ---
>>
>> During our LPC ad-hoc BoF, we discussed improving Maintainer SoC docs
>> and I think I volunteered to write something. The trouble is that
>> whatever I won't write in my notes, escapes my memory.
>>
>> I believe this is what we discussed
Patches for SoCs are expected to be picked up by SoC submaintainers.
The main SoC maintainers should be addressed only in few cases.
Rewrite the section about maintainer handling to document above
expectation.
Signed-off-by: Krzysztof Kozlowski
Cc: Linus Walleij
Cc: Alexandre Belloni
Cc: Will
On 24/09/2024 15:19, Conor Dooley wrote:
> On Tue, Sep 24, 2024 at 03:08:31PM +0200, Krzysztof Kozlowski wrote:
>
>> Most of these submaintainers have their own trees where they stage patches,
>> sending pull requests to the main SoC tree. These trees are usually, but
Patches for SoCs are expected to be picked up by SoC submaintainers.
The main SoC maintainers should be addressed only in few cases.
Rewrite the section about maintainer handling to document above
expectation.
Signed-off-by: Krzysztof Kozlowski
Cc: Linus Walleij
Cc: Alexandre Belloni
Cc: Will
On 24/05/2024 21:23, Bjorn Andersson wrote:
> On Thu, May 23, 2024 at 08:15:54AM +0200, Krzysztof Kozlowski wrote:
>> On 22/05/2024 19:50, Bjorn Andersson wrote:
>>>>>>>
>>>>>>> We did consider tying this to the SMEM instance, but the enti
On 22/05/2024 19:50, Bjorn Andersson wrote:
>
> We did consider tying this to the SMEM instance, but the entitiy
> relating to firmware is the remoteproc instance.
I still do not understand why you have to add hwlock to remoteproc, even
though it is not directly used. Yo
by smem, so this proves you are taking someone else's
lock. I commented on this in the binding, but let's be specific:
NAK, please carry:
Nacked-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On 21/05/2024 21:17, Bjorn Andersson wrote:
>>>
>>> Hi Krzysztof,
>>>
>>> Sorry for the confusion, I dont think I meant that the smem driver will
>>> ever crash. The referred to crash in the cover letter is a crash in the
>>> firmware running on the remoteproc. The remoteproc could crash for any
On 21/05/2024 06:08, Chris Lew wrote:
>
>
> On 5/19/2024 10:36 AM, Krzysztof Kozlowski wrote:
>> On 17/05/2024 00:58, Chris Lew wrote:
>>> Add hwlocks property to describe the hwspinlock that remoteproc can try
>>> to bust on behalf of the remoteproc's sme
On 17/05/2024 00:58, Chris Lew wrote:
> Add hwlocks property to describe the hwspinlock that remoteproc can try
> to bust on behalf of the remoteproc's smem.
Sorry, as you wrote, the lock is part of smem, not here. Drivers do not
crash, so if your crashes as you imply in the cover letter, then fir
On 23/04/2024 15:19, Andy Shevchenko wrote:
> Add a note that explains that Cc: email header is implied by other
> tags, such as Reviewed-by:. In this case an explicit Cc: is _not_
> needed.
>
> Signed-off-by: Andy Shevchenko
> ---
> Documentation/process/5.Posting.rst | 4 +++-
> Docu
On 23/04/2024 15:19, Andy Shevchenko wrote:
> The recommendation is based on the following rationale:
>
> - it makes the commit messages much cleaner and easy to read, especially
> on the screens of the mobile devices;
>
> - it reduces resources (memory, time, energy) to retrieve all these
>
+++
> Documentation/process/index.rst | 1 +
> Documentation/process/security-bugs.rst | 5 +-
Great direction! Finally all these bugs we are fixing every release
(thus in stable trees) will get proper attention via assigned CVEs.
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
Extend the list of maintainer profiles with SoC and netdev.
Signed-off-by: Krzysztof Kozlowski
---
Documentation/maintainer/maintainer-entry-profile.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/maintainer/maintainer-entry-profile.rst
b/Documentation/maintainer
On 03/12/2023 21:25, Dragan Simic wrote:
>> +Order of Properties in Device Node
>> +--
>> +
>> +The following order of properties in device nodes is preferred:
>> +
>> +1. compatible
>> +2. reg
>> +3. ranges
>> +4. Standard/common properties (defined by common bindin
On 03/12/2023 21:12, Dragan Simic wrote:
> Just a brief reminder about my suggestions below, which seemingly didn't
> find their way into the v4. At least the first one, which improves the
> opening sentence, is worth including, IMHO.
>
I applied almost all your suggestions, except few which I
: Jonathan Corbet
Cc: Matthias Brugger
Cc: Michal Simek
Cc: Neil Armstrong
Cc: Nishanth Menon
Cc: Olof Johansson
Cc: Rafał Miłecki
Acked-by: Neil Armstrong
Acked-by: Heiko Stuebner
Reviewed-by: Laurent Pinchart
Acked-by: Konrad Dybcio
Reviewed-by: Geert Uytterhoeven
Signed-off-by: Krzysztof
On 01/12/2023 17:46, Conor Dooley wrote:
> On Sat, Nov 25, 2023 at 07:44:22PM +0100, Krzysztof Kozlowski wrote:
>> +Indentation
>> +---
>> +
>> +1. Use indentation according to :ref:`codingstyle`.
>
> One thing Jonathan mentioned before to me was to d
On 28/11/2023 21:00, Dragan Simic wrote:
>> 5. Allow two style of ordering overrides in board DTS: alphabetically
>> or
>>by order of DTSI (Rob).
>> 6. I did not incorporate feedback about, due to lack of consensus and
>> my
>>disagreement:
>>a. SoM being DTS without DTSI in "Organizi
On 29/11/2023 08:29, Francesco Dolcini wrote:
> On Sat, Nov 25, 2023 at 07:44:22PM +0100, Krzysztof Kozlowski wrote:
>> Document preferred coding style for Devicetree sources (DTS and DTSI),
>> to bring consistency among all (sub)architectures and ease in reviews.
>
> Thank K
On 27/11/2023 15:19, Geert Uytterhoeven wrote:
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/dts-coding-style.rst
>
>> + /* SoC DTSI */
>> +
>> + / {
>> + cpus {
>> + /* ... */
>> + };
>> +
>> + psci {
>> +
On 25/11/2023 20:47, Andrew Lunn wrote:
>> +=
>> +Devicetree Sources (DTS) Coding Style
>> +=
>> +
>> +When writing Devicetree Sources (DTS) please observe below guidelines. They
>> +should be considered complementary to any r
On 25/11/2023 20:37, Laurent Pinchart wrote:
> Hi Krzysztof,
>
> Thank you for the patch.
>
> On Sat, Nov 25, 2023 at 07:44:22PM +0100, Krzysztof Kozlowski wrote:
>> Document preferred coding style for Devicetree sources (DTS and DTSI),
>> to bring consistency among
On 25/11/2023 20:33, Jonathan Corbet wrote:
> Krzysztof Kozlowski writes:
>
>> Document preferred coding style for Devicetree sources (DTS and DTSI),
>> to bring consistency among all (sub)architectures and ease in reviews.
>
> One little nit:
>
>> diff
: Geert Uytterhoeven
Cc: Heiko Stuebner
Cc: Jonathan Corbet
Cc: Konrad Dybcio
Cc: Matthias Brugger
Cc: Michal Simek
Cc: Neil Armstrong
Cc: Nishanth Menon
Cc: Olof Johansson
Cc: Rafał Miłecki
Acked-by: Neil Armstrong
Acked-by: Heiko Stuebner
Signed-off-by: Krzysztof Kozlowski
---
Merging
On 24/10/2023 11:15, Przemek Kitszel wrote:
> On 10/23/23 16:02, Sean Christopherson wrote:
>> +Mateusz
>>
>> On Mon, Oct 23, 2023, Przemek Kitszel wrote:
>>> Additional tags between Co-developed-by and corresponding Signed-off-by
>>> could include Reviewed-by tags collected by Submitter, which is
On 12/09/2023 11:26, Mukesh Ojha wrote:
>>
>>> + return -EINVAL;
>>> + }
>>> +
>>> + mutex_init(&md->md_lock);
>>> + ret = qcom_apss_md_table_init(md,
>>> &mdgtoc->subsystems[MINIDUMP_APSS_DESC]);
>>> + if (ret) {
>>> + dev_err(md->dev, "apss minidump initialization fai
On 11/09/2023 12:53, Mukesh Ojha wrote:
> Add the qualcomm minidump guide for the users which tries to cover
> the dependency, API use and the way to test and collect minidump
> on Qualcomm supported SoCs.
>
> Signed-off-by: Mukesh Ojha
> ---
Please let us review your previous patch before sendi
On 09/09/2023 22:16, Mukesh Ojha wrote:
> Register all the pstore frontend with minidump, so that they can
> be dumped as default Linux minidump region to be collected on
> SoC where minidump is enabled.
>
...
> +
> + record.type = type;
> + record.id = 0;
> + max_dump_cnt = 0;
> +
On 09/09/2023 22:16, Mukesh Ojha wrote:
> Minidump is a best effort mechanism to collect useful and predefined
> data for first level of debugging on end user devices running on
> Qualcomm SoCs. It is built on the premise that System on Chip (SoC)
> or subsystem part of SoC crashes, due to a range
On 09/09/2023 22:16, Mukesh Ojha wrote:
> +/**
> + * qcom_minidump_region_register() - Register region in APSS Minidump table.
> + * @region: minidump region.
> + *
> + * Return: On success, it returns 0 and negative error value on failure.
> + */
> +int qcom_minidump_region_register(const struct q
On 09/09/2023 22:16, Mukesh Ojha wrote:
> static int qcom_apss_minidump_probe(struct platform_device *pdev)
> {
> struct minidump_global_toc *mdgtoc;
> @@ -571,7 +688,10 @@ static int qcom_apss_minidump_probe(struct
> platform_device *pdev)
> return ret;
> }
>
> +
On 11/09/2023 12:53, Mukesh Ojha wrote:
...
> +module_platform_driver(qcom_minidump_driver);
> +
> +MODULE_DESCRIPTION("Qualcomm APSS minidump driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:qcom-minidump-smem");
Nothing improved here and in other places. To avoid review being spre
p points should be registered
> without 'irq-mode' flag.
Please fix the line-wrap.
>
> Cc: Kukjin Kim
> Cc: Krzysztof Kozlowski
> Cc: devicet...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-samsung-...@vger.kernel.org
> Signed-off-by:
On Wed, 7 Nov 2018 at 18:10, Lukasz Luba wrote:
>
Subject prefix:
dt-bindings: thermal:
> Thermal trip point gets new flag in DT: irq-mode.
> Trip point may have a new explicit flag which indicate
> IRQ support when the temperature is met (so the thermal framework
> deos not need to set polling
On Thu, 1 Nov 2018 at 08:19, Matti Vaittinen
wrote:
>
> Use devm variant of clkdev lookup registration in order to avoid
> clkdev lookup leak at device remove.
>
> Signed-off-by: Matti Vaittinen
> ---
> drivers/clk/samsung/clk-s3c2410-dclk.c | 15 ---
> 1 file changed, 8 insertions(+
provider(parent->of_node,
> of_clk_max77686_get,
> -drv_data);
> + ret = devm_of_clk_add_parent_hw_provider(dev,
> + of_clk_max77686_get,
> drv_data);
The same, please.
Rest looks good, so with these changes:
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Wed, 17 Oct 2018 at 09:42, Lukasz Luba wrote:
>
> Hi Krzysztof,
>
> On 10/17/2018 09:03 AM, Krzysztof Kozłowski wrote:
> > On Tue, 16 Oct 2018 at 16:56, Lukasz Luba
> > wrote:
> >>
> >> Hi all,
> >>
> >> This patch set adds new flag and mechanism in thermal trip point in DT.
> >> The current
On Tue, 16 Oct 2018 at 17:48, Lukasz Luba wrote:
>
> Hi Krzysztof,
>
> On 10/16/2018 05:09 PM, Krzysztof Kozlowski wrote:
> > On Tue, 16 Oct 2018 at 16:56, Lukasz Luba
> > wrote:
> >>
> >
> > Hi Lukasz,
> >
> > Thanks for patches.
> &g
On Tue, 16 Oct 2018 at 16:56, Lukasz Luba wrote:
>
> This patch adds support for new flash which indicates
> that trip point triggers irq when temperature is met.
> Exynos5433 supports 8 trip point which will trigger irq.
Exynos5420? 4 trip points?
BTW, I just noted that you skipped samsung-soc
On Tue, 16 Oct 2018 at 16:56, Lukasz Luba wrote:
>
> This patch adds support for new flash which indicates
> that trip point triggers irq when temperature is met.
> Exynos5433 supports 8 trip point which will trigger irq.
Exynos4? 4 trip points?
Beside that other comments apply as well.
Best re
On Tue, 16 Oct 2018 at 16:56, Lukasz Luba wrote:
>
> This patch adds support for new flash which indicates
> that trip point triggers irq when temperature is met.
> Exynos5433 supports 8 trip point which will trigger irq.
Exynos7?
Beside that comments from previous email apply (no need to duplic
er trip points should be registered
> without 'irq-mode' flag.
Why they should be registered without irq-mode?
> That will force the thermal framework to start polling
> the temperature sensor under configured conditions and
> handle the trip point.
How does it fit into ex
On Thu, Oct 12, 2017 at 2:36 PM, Maciej Purski wrote:
> Add optional max expected current property which allows calibrating
> the ina sensor in order to achieve requested measure scale. Document
> the changes in Documentation/hwmon/ina2xx.
>
> Signed-off-by: Maciej Purski
> ---
> Documentation/d
On Fri, Feb 24, 2017 at 10:21:35AM -0700, Jonathan Corbet wrote:
> On Fri, 24 Feb 2017 10:36:20 +0200
> Krzysztof Kozlowski wrote:
>
> > What happened with this patch? I am asking because on top of
> > next-20170224 I found some more sysrq.txt obsolete paths... including
&g
Commit 9d85025b0418 ("docs-rst: create an user's manual book") moved the
sysrq.txt leaving old paths in the kernel docs.
Signed-off-by: Krzysztof Kozlowski
---
Documentation/media/v4l-drivers/bttv.rst | 2 +-
Documentation/s390/Debugging390.txt | 2 +-
On Tue, Dec 13, 2016 at 4:40 PM, Hans Holmberg wrote:
> A bunch of documentation files have moved, correct the paths.
>
> Signed-off-by: Hans Holmberg
> ---
> lib/Kconfig.debug | 19 ++-
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
Hi Jon,
What happened with this patch?
On Thu, Nov 03, 2016 at 01:42:01AM -0400, Anurup M wrote:
> 1) Device tree bindings for Hisilicon SoC PMU.
> 2) Add example for Hisilicon L3 cache, MN and DDRC PMU.
Get rid of this weird indentation in all patches.
>
> Signed-off-by: Anurup M
> Signed-off-by: Shaokun Zhang
> ---
>
dma_attrs *attrs);
@@
identifier r.f;
@@
f(...,
- NULL
+ 0
)
===
Signed-off-by: Krzysztof Kozlowski
---
Documentation/DMA-API.txt| 29 +--
Documentation/DMA-attributes.txt | 2 +-
include/linux/dma-attrs.h| 71 --
include/linux/dma-mapping.h
After switching DMA attributes to unsigned long it is easier to just
compare the bits.
Signed-off-by: Krzysztof Kozlowski
[for avr32]
Acked-by: Hans-Christian Noren Egtvedt
[for arc]
Acked-by: Vineet Gupta
[for arm64 and dma-iommu]
Acked-by: Robin Murphy
---
Documentation/DMA-API.txt
he
attributes are passed by value.
Best regards,
Krzysztof
Krzysztof Kozlowski (46):
[media] mtk-vcodec: Remove unused dma_attrs
dma-mapping: Use unsigned long for dma_attrs
alpha: dma-mapping: Use unsigned long for dma_attrs
arc: dma-mapping: Use unsigned long for dma_attrs
ARM: dma-
On 07/12/2016 02:16 PM, Daniel Vetter wrote:
> On Thu, Jun 30, 2016 at 10:23:39AM +0200, Krzysztof Kozlowski wrote:
>> Hi,
>>
>>
>> This is fifth approach for replacing struct dma_attrs with unsigned
>> long.
>>
>> The main patch (1/44) doing the chang
After switching DMA attributes to unsigned long it is easier to just
compare the bits.
Signed-off-by: Krzysztof Kozlowski
[for avr32]
Acked-by: Hans-Christian Noren Egtvedt
[for arc]
Acked-by: Vineet Gupta
[for arm64 and dma-iommu]
Acked-by: Robin Murphy
---
Documentation/DMA-API.txt
dma_attrs *attrs);
@@
identifier r.f;
@@
f(...,
- NULL
+ 0
)
===
Signed-off-by: Krzysztof Kozlowski
---
Documentation/DMA-API.txt| 29 +--
Documentation/DMA-attributes.txt | 2 +-
include/linux/dma-attrs.h| 71 --
include/linux/dma-mapping.h
const correctness because the
attributes are passed by value.
Best regards,
Krzysztof
Krzysztof Kozlowski (44):
dma-mapping: Use unsigned long for dma_attrs
alpha: dma-mapping: Use unsigned long for dma_attrs
arc: dma-mapping: Use unsigned long for dma_attrs
ARM: dma-mapping: Use unsig
On Fri, Jun 10, 2016 at 10:23:47PM +0200, Luis R. Rodriguez wrote:
> On Fri, Jun 10, 2016 at 10:16:00PM +0200, Krzysztof Kozlowski wrote:
> > On Fri, Jun 10, 2016 at 04:49:47PM +0200, Luis R. Rodriguez wrote:
> > > On Fri, Jun 10, 2016 at 12:11:18PM +0200, Krzysztof Kozlowski
On Fri, Jun 10, 2016 at 04:49:47PM +0200, Luis R. Rodriguez wrote:
> On Fri, Jun 10, 2016 at 12:11:18PM +0200, Krzysztof Kozlowski wrote:
> > The dma-mapping core and the implementations do not change the
> > DMA attributes passed by pointer. Thus the pointer can point to const
>
dma_attrs *attrs);
@@
identifier r.f;
@@
f(...,
- NULL
+ 0
)
===
Signed-off-by: Krzysztof Kozlowski
---
Documentation/DMA-API.txt| 29 +--
Documentation/DMA-attributes.txt | 2 +-
include/linux/dma-attrs.h| 72 ---
include/linux/dma-mapping.h
e passed by value.
Best regards,
Krzysztof
Krzysztof Kozlowski (44):
dma-mapping: Use unsigned long for dma_attrs
alpha: dma-mapping: Use unsigned long for dma_attrs
arc: dma-mapping: Use unsigned long for dma_attrs
ARM: dma-mapping: Use unsigned long for dma_attrs
arm64: dma-mappi
On 05/31/2016 08:15 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, May 30, 2016 at 01:54:06PM +0200, Krzysztof Kozlowski wrote:
>> The dma-mapping core and the implementations do not change the
>> DMA attributes passed by pointer. Thus the pointer can point to const
>> data. H
On 05/31/2016 07:04 PM, Christoph Hellwig wrote:
> On Mon, May 30, 2016 at 01:54:06PM +0200, Krzysztof Kozlowski wrote:
>> The dma-mapping core and the implementations do not change the
>> DMA attributes passed by pointer. Thus the pointer can point to const
>> data. Howe
yet. Only ARM and
ARM64 are fixed (and not everywhere).
However other API users also have to be converted which is quite
intrusive. I would rather avoid it until the overall approach is
accepted.
Signed-off-by: Krzysztof Kozlowski
---
Documentation/DMA-API.txt | 2
the patch touches the dma-mapping API so all
the users have to be converted (ARM and ARM64 as of now).
Any ideas to split it per smaller patches?
The work is not finished yet, I would rather get some feedback before
progressing further.
Best regards,
Krzysztof
Krzysztof Kozlowski (1):
dma
On 05/19/2016 11:04 AM, Vignesh R wrote:
> There are rotary-encoders where GPIO lines reflect the actual position
> of the rotary encoder dial. For example, if dial points to 9, then four
> GPIO lines connected to the rotary encoder will read HLLH(1001b = 9).
> Add support for such rotary-encoder.
ed as
> soon as the atomic PWM infrastructure is in place and the driver makes
> use of it.
>
> Signed-off-by: Boris Brezillon
> ---
> arch/arm/mach-s3c24xx/mach-rx1950.c | 6 ++
> 1 file changed, 6 insertions(+)
>
Acked-by: Krzysztof Kozlowski
Best regards,
Krzy
72 matches
Mail list logo
