On Sun, 2019-09-08 at 18:28 -0700, Brendan Higgins wrote:
> On Tue, Aug 13, 2019 at 08:09:18AM +0200, Knut Omang wrote:
> > The generic netlink protocol used to communicate between
> > kernel and user space about tests and test results, as well as some
> > means for configu
On Sun, 2019-09-08 at 18:23 -0700, Brendan Higgins wrote:
> On Tue, Aug 13, 2019 at 08:09:17AM +0200, Knut Omang wrote:
>
> Sorry, it's taken me way too long to get down to a proper code review on
> this. I was hoping to send you something a couple weeks ago in
> preparatio
On Wed, 2019-08-21 at 10:47 +0900, Masahiro Yamada wrote:
> On Wed, Aug 14, 2019 at 9:53 PM Knut Omang wrote:
> >
> > On Wed, 2019-08-14 at 07:52 +0200, Knut Omang wrote:
> > > On Wed, 2019-08-14 at 11:02 +0900, Masahiro Yamada wrote:
> > > > Hi Knut,
> >
On Thu, 2019-08-15 at 10:49 +0200, Greg Kroah-Hartman wrote:
> On Wed, Aug 14, 2019 at 07:17:07PM +0200, Knut Omang wrote:
> > I notice the discussion and your response here:
> > http://linux-kernel.2935.n7.nabble.com/debugfs-and-module-unloading-td865175.html
> > I a
On Tue, 2019-08-13 at 10:21 +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 13, 2019 at 08:09:21AM +0200, Knut Omang wrote:
> > From: Alan Maguire
> >
> > While test results is available via netlink from user space, sometimes
> > it may be useful to be able to access
On Wed, 2019-08-14 at 07:52 +0200, Knut Omang wrote:
> On Wed, 2019-08-14 at 11:02 +0900, Masahiro Yamada wrote:
> > Hi Knut,
> >
> > On Wed, Aug 14, 2019 at 1:19 AM Knut Omang wrote:
> > > On Tue, 2019-08-13 at 23:01 +0900, Masahiro Yamada wrote:
> > >
On Wed, 2019-08-14 at 11:02 +0900, Masahiro Yamada wrote:
> Hi Knut,
>
> On Wed, Aug 14, 2019 at 1:19 AM Knut Omang wrote:
> > On Tue, 2019-08-13 at 23:01 +0900, Masahiro Yamada wrote:
> > > On Tue, Aug 13, 2019 at 3:13 PM Knut Omang wrote:
> > > > C++ l
On Wed, 2019-08-14 at 11:02 +0900, Masahiro Yamada wrote:
> Hi Knut,
>
> On Wed, Aug 14, 2019 at 1:19 AM Knut Omang wrote:
> > On Tue, 2019-08-13 at 23:01 +0900, Masahiro Yamada wrote:
> > > On Tue, Aug 13, 2019 at 3:13 PM Knut Omang wrote:
> > > > C++ l
On Tue, 2019-08-13 at 23:01 +0900, Masahiro Yamada wrote:
> On Tue, Aug 13, 2019 at 3:13 PM Knut Omang wrote:
> >
> > C++ libraries interfacing to C APIs might sometimes need some glue
> > logic more easily written in C.
> > Allow a C++ library to also contain 0 or m
On Tue, 2019-08-13 at 01:17 -0700, Brendan Higgins wrote:
> On Mon, Aug 12, 2019 at 11:11 PM Knut Omang wrote:
> [...]
> > Alan Maguire (3):
> > ktf: Implementation of ktf support for overriding function entry and
> > return.
> > ktf: A simple debugfs inter
On Tue, 2019-08-13 at 10:23 +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 13, 2019 at 08:09:15AM +0200, Knut Omang wrote:
> > and in the making::
> >
> > kunit/(kernel only (UML))
>
> You are going to have to integrate this with kunit, to c
-objs instead of the intended
-cobjs and -cxxobjs following the pattern from hostprogs*.
Signed-off-by: Knut Omang
---
scripts/Makefile.host | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/scripts/Makefile.host b/scripts/Makefile.host
index b6a54bd..4e9bb21
very simple additional example tests.
ktf.h: Defines the KTF user API for kernel clients
ktf_test.c: Kernel side code for tracking and reporting ktf test results
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/kernel/Makefile | 15 +-
tools/testing/selftests/ktf/kernel/
instance verify that a particular API actually ends up being
called, and in the right way, as an effect of a test.
ktf_override.c: support for overriding function entry.
ktf_override.h: Function override support interface for KTF.
Signed-off-by: Alan Maguire
Signed-off-by: Knut Omang
Currently ktf only supports integration with googletest on the user
side, but there's nothing that prevents integration towards other user
land frameworks for running and reporting, if so desired.
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/lib/ktf_run.cc
ktf_int.h: User mode side of extension to the gtest unit test framework:
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/lib/Makefile | 21 +-
tools/testing/selftests/ktf/lib/ktf.h | 114 ++-
tools/testing/selftests/ktf/lib/ktf_int.cc | 1031 +-
tools
Signed-off-by: Knut Omang
---
Documentation/dev-tools/index.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/dev-tools/index.rst
b/Documentation/dev-tools/index.rst
index b0522a4..f155205 100644
--- a/Documentation/dev-tools/index.rst
+++ b/Documentation/dev-tools/index.rst
Signed-off-by: Knut Omang
---
tools/testing/selftests/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 9781ca7..a24c2fe 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
el netlink interactions
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/kernel/ktf_nl.c | 516 +++-
tools/testing/selftests/ktf/kernel/ktf_nl.h | 15 +-
tools/testing/selftests/ktf/kernel/ktf_unlproto.h | 105 +++-
3 files changed, 636 insertions(+)
create mode 10
Utilities for convenient and runtime enabled/disabled
printk debugging mainly intended for debugging ktf itself and subtle
early issues with execution/running of tests.
ktf_debug.h: User mode debug function definitions
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/lib
Signed-off-by: Knut Omang
---
Documentation/dev-tools/ktf/concepts.rst | 242 ++-
Documentation/dev-tools/ktf/debugging.rst | 248 +++-
Documentation/dev-tools/ktf/examples.rst | 26 ++-
Documentation/dev-tools/ktf/features.rst | 307
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/Makefile| 21 -
tools/testing/selftests/ktf/scripts/ktf_syms.mk | 16 +++-
tools/testing/selftests/ktf/scripts/runtests.mk | 3 +-
tools/testing/selftests/ktf/scripts/runtests.sh | 100 +-
tools/testing
:Hybrid (combined user level and kernel) self tests,
hybrid_self.h: The data structure passed between user level and kernel for the
self.c: Some simple self tests for KTF
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/selftest/Makefile | 17 +-
tools/testing/selftests/ktf
user level application to run kernel tests
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/user/Makefile | 26 -
tools/testing/selftests/ktf/user/hybrid.cc | 39 +-
tools/testing/selftests/ktf/user/ktfcov.cc | 68 ++-
tools/testing/selftests
A few simple examples, and example of other test modules
to make it easier to get started with ktf.
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/examples/Makefile | 17 -
tools/testing/selftests/ktf/examples/h2.c | 45 +++-
tools/testing/selftests/ktf/examples/h3.c
.
Examples follows in the selftests later in the series.
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/scripts/resolve | 188 +-
1 file changed, 188 insertions(+)
create mode 100755 tools/testing/selftests/ktf/scripts/resolve
diff --git a/tools/testing/selftests
From: Alan Maguire
Allows reports of code coverage and memory allocation.
ktf_cov.c: Code coverage support implementation for KTF.
ktf_cov.h: Code coverage support interface for KTF.
Signed-off-by: Alan Maguire
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/kernel
An implementation of configurable contexts for exchanging network
information, to make it easier to run network tests potentially
involving more than one kernel.
ktf_netctx.h:Configurable context setup for multinode network tests
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf
::map like
API
ktf_map.h: simple objects with key lookup to be inlined into a
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/kernel/ktf_map.c | 261 -
tools/testing/selftests/ktf/kernel/ktf_map.h | 154 -
2 files changed, 415 insertions(+)
create m
test
Signed-off-by: Alan Maguire
Signed-off-by: Knut Omang
---
tools/testing/selftests/ktf/kernel/ktf_debugfs.c | 356 -
tools/testing/selftests/ktf/kernel/ktf_debugfs.h | 34 ++-
2 files changed, 390 insertions(+)
create mode 100644 tools/testing/selftests/ktf/kernel
also to more discussion
around unit testing at the testing & fuzzing workshop at LPC!
Alan Maguire (3):
ktf: Implementation of ktf support for overriding function entry and return.
ktf: A simple debugfs interface to test results
ktf: Simple coverage support
Knut Omang (16):
kbuild:
On Fri, 2019-05-10 at 14:59 -0700, Frank Rowand wrote:
> On 5/10/19 3:23 AM, Brendan Higgins wrote:
> >> On Fri, May 10, 2019 at 7:49 AM Knut Omang wrote:
> >>>
> >>> On Thu, 2019-05-09 at 22:18 -0700, Frank Rowand wrote:
> >>>> On 5/9/19 4:40 PM
On Fri, 2019-05-10 at 15:18 -0700, Frank Rowand wrote:
> On 5/10/19 1:54 PM, Brendan Higgins wrote:
> > On Fri, May 10, 2019 at 5:13 AM Knut Omang wrote:
> >> On Fri, 2019-05-10 at 03:23 -0700, Brendan Higgins wrote:
> >>>> On Fri, May 10, 2019 at 7:49 AM Knut Oma
On Mon, 2018-02-05 at 08:20 +0100, Knut Omang wrote:
> On Mon, 2018-02-05 at 16:03 +0900, Masahiro Yamada wrote:
Hi Masahiro,
I know these are busy times but any hope of getting forward on this?
Anything more I can do to ease the process?
Thanks for your time,
Knut
> > 2018-02-05 15:
On Mon, 2018-02-05 at 16:03 +0900, Masahiro Yamada wrote:
> 2018-02-05 15:41 GMT+09:00 Knut Omang :
> > On Fri, 2018-01-19 at 11:14 +0100, Knut Omang wrote:
> >> Add scripts/runchecks which has generic support for running
> >> checker tools in a convenient and user
On Fri, 2018-01-19 at 11:14 +0100, Knut Omang wrote:
> Add scripts/runchecks which has generic support for running
> checker tools in a convenient and user friendly way that
> the author hopes can contribute to rein in issues detected
> by these tools in a manageable and co
e coccinelle documentation also had the
behaviour of C=1 and C=2 swapped.
Signed-off-by: Knut Omang
Reviewed-by: Håkon Bugge
Reviewed-by: Åsmund Østvold
Reviewed-by: John Haxby
Reviewed-by: Tom Saeger
---
Documentation/dev-tools/coccinelle.rst | 12 +-
Documentation/dev-tools/index.rst
r in cases
where types either are not available at all (checkdoc) or where only a few
can be filtered out (sparse)
With this in place it also became almost trivial to make the look and feel
similar
for sparse, smatch and checkdoc as for checkpatch, with some optional color
support
too, to make fi
On Sun, 2018-01-07 at 08:12 -0200, Mauro Carvalho Chehab wrote:
> Em Fri, 05 Jan 2018 20:41:41 +0100
> Knut Omang escreveu:
>
> > On Fri, 2018-01-05 at 16:08 -0200, Mauro Carvalho Chehab wrote:
> > > Em Thu, 04 Jan 2018 21:15:31 +0100
> > > Knut Omang escreveu:
On Sun, 2018-01-07 at 13:03 +0100, Philippe Ombredanne wrote:
> Knut,
>
> On Fri, Jan 5, 2018 at 3:30 PM, Jani Nikula
> wrote:
> > On Thu, 04 Jan 2018, Knut Omang wrote:
> >> On Thu, 2018-01-04 at 17:50 +0200, Jani Nikula wrote:
> >>> On Thu, 04 Jan 2018,
On Fri, 2018-01-05 at 16:08 -0200, Mauro Carvalho Chehab wrote:
> Em Thu, 04 Jan 2018 21:15:31 +0100
> Knut Omang escreveu:
>
> > > I'm surprised the commit message and the provided documentation say
> > > nothing about using CHECK=foo on the command line. That
On Thu, 2018-01-04 at 17:50 +0200, Jani Nikula wrote:
> On Thu, 04 Jan 2018, Knut Omang wrote:
> > Add scripts/runchecks which has generic support for running
> > checker tools in a convenient and user friendly way that
> > the author hopes can contribute to rein in issues
n also had the
behaviour of C=1 and C=2 swapped.
Signed-off-by: Knut Omang
Reviewed-by: Håkon Bugge
Reviewed-by: Åsmund Østvold
Reviewed-by: John Haxby
---
Documentation/dev-tools/coccinelle.rst | 12 +-
Documentation/dev-tools/index.rst | 1 +-
Documentation/dev-tools/runchecks.rst |
c as for checkpatch, with some optional color support
too, to make fixing issues in the code, the goal of this whole exercise,
much more pleasant IMHO :-)
Thanks,
Knut
Knut Omang (1):
runchecks: Generalize make C={1,2} to support multiple checkers
Documentation/dev-tools/coccinelle.rs
On Mon, 2017-12-18 at 17:56 +, Bart Van Assche wrote:
> On Mon, 2017-12-18 at 10:46 -0700, Jason Gunthorpe wrote:
> > On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote:
> >
> > > > Today when we run checkers we get so many warnings it is too hard to
> > > > make any sense of it.
> >
On Mon, 2017-12-18 at 07:30 -0800, Joe Perches wrote:
> On Mon, 2017-12-18 at 14:05 +0100, Knut Omang wrote:
> > > Here is a list of the checkpatch messages for drivers/infiniband
> > > sorted by type.
> > >
> > > Many of these might be corrected by using
&g
On Sun, 2017-12-17 at 22:00 -0700, Jason Gunthorpe wrote:
> On Sun, Dec 17, 2017 at 03:14:10AM +0100, Knut Omang wrote:
>
> > > I like the ability to add more checkers and keep then in the main
> > > upstream tree. But adding overrides for specific subsystems goes again
On Sun, 2017-12-17 at 22:00 -0800, Joe Perches wrote:
> On Sun, 2017-12-17 at 22:00 -0700, Jason Gunthorpe wrote:
> > On Sun, Dec 17, 2017 at 03:14:10AM +0100, Knut Omang wrote:
> >
> > > > I like the ability to add more checkers and keep then in the main
> &
On Sat, 2017-12-16 at 09:47 -0800, Stephen Hemminger wrote:
> On Sat, 16 Dec 2017 15:42:25 +0100
> Knut Omang wrote:
>
> > This patch series implements features to make it easier to run checkers on
> > the
> > entire kernel as part of automatic and developer testin
On Sat, 2017-12-16 at 09:00 -0800, Joe Perches wrote:
> On Sat, 2017-12-16 at 17:27 +0100, Knut Omang wrote:
> > On Sat, 2017-12-16 at 07:21 -0800, Joe Perches wrote:
> > > On Sat, 2017-12-16 at 15:42 +0100, Knut Omang wrote:
> > > > This patch series implements fea
On Sat, 2017-12-16 at 07:21 -0800, Joe Perches wrote:
> On Sat, 2017-12-16 at 15:42 +0100, Knut Omang wrote:
> > This patch series implements features to make it easier to run checkers on
> > the
> > entire kernel as part of automatic and developer testing.
>
> T
/runchecks.rst
> > @@ -0,0 +1,215 @@
> > +.. Copyright 2017 Knut Omang
> > +
> > +Makefile support for running checkers
> > +=
> > +
> > +Tools like sparse, coccinelle and scripts/checkpatch.pl is able to detect a
>
>
ess sparse specific and more
generic. The coccinelle documentation also had the
behaviour of C=1 and C=2 swapped.
Signed-off-by: Knut Omang
Reviewed-by: Håkon Bugge
Reviewed-by: Åsmund Østvold
Reviewed-by: John Haxby
---
Documentation/dev-tools/coccinelle.rst | 12 +-
Documentation/dev-tools
eck type space of the checker in cases
where types either are not available at all (checkdoc) or where only a few
can be filtered out (sparse)
With this in place it also became trivial to make the look and feel similar
for sparse and checkdoc as for checkpatch, with some optional color support
too, to m
-checkpatch.html
Thanks,
Knut
On Thu, 2017-11-16 at 18:01 +0100, Knut Omang wrote:
> This patch series implements features to facilitate running checkpatch on the
> entire kernel as part of automatic testing.
>
> This is done by by adding a few small features to checkpatch and put these
> fea
On Thu, 2017-11-16 at 14:57 -0800, Kees Cook wrote:
> On Thu, Nov 16, 2017 at 9:01 AM, Knut Omang wrote:
> > The most important checkpatch feature added is the --ignore-cfg feature,
> > which
> > takes a file argument and parses that file according to this
When running checkpatch with --ignore-cfg it will now traverse the directories
above the source file until a match is found.
Reflect this enhanced behaviour in the documentation.
Signed-off-by: Knut Omang
---
Documentation/dev-tools/run-checkpatch.rst | 48 ---
1 file
Signed-off-by: Knut Omang
Reviewed-by: Håkon Bugge
Reviewed-by: Åsmund Østvold
Reviewed-by: John Haxby
Signed-off-by: Knut Omang
---
Documentation/dev-tools/index.rst | 1 +-
Documentation/dev-tools/run-checkpatch.rst | 105 ++-
2 files changed, 106 insertions
the checkpatch.cfg file(s) to have 0 errors or warnings at
any commit boundary.
The combined set is available here:
git://github.com/knuto/linux.git branch checkpatch
Comments and suggestions appreciated!
Thanks,
Knut
Knut Omang (7):
checkpatch: Implement new --ignore-cfg parameter
kbui
59 matches
Mail list logo
