Re: [PATCH 2/2] sched: Document Energy Aware Scheduling

2019-01-18 Thread Juri Lelli
Hi, On 18/01/19 10:34, Quentin Perret wrote: > Hi Rafael, > > On Friday 18 Jan 2019 at 10:57:08 (+0100), Rafael J. Wysocki wrote: > > On Fri, Jan 18, 2019 at 10:16 AM Quentin Perret > > wrote: > > > > > > Hi Juri, > > > > > > On T

Re: [PATCH 2/2] sched: Document Energy Aware Scheduling

2019-01-17 Thread Juri Lelli
Hi, On 10/01/19 11:05, Quentin Perret wrote: > Add some documentation detailing the main design points of EAS, as well > as a list of its dependencies. > > Parts of this documentation are taken from Morten Rasmussen's original > EAS posting: https://lkml.org/lkml/2015/7/7/754 > > Reviewed-by: Qa

Re: [PATCH 1/2] PM / EM: Document the Energy Model framework

2019-01-17 Thread Juri Lelli
Hi, On 10/01/19 11:05, Quentin Perret wrote: > Introduce a documentation file summarizing the key design points and > APIs of the newly introduced Energy Model framework. > > Signed-off-by: Quentin Perret Looks good to me. Reviewed-by: Juri Lelli Best, - Juri

Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-25 Thread Juri Lelli
On 25/05/18 11:31, Patrick Bellasi wrote: [...] > Right, so the problem seems to be that we "need" to call > arch_update_cpu_topology() and we do that by calling > partition_sched_domains() which was initially introduced by: > >029190c515f1 ("cpuset sched_load_balance flag") > > back in 200

Re: [PATCH v8 3/6] cpuset: Add cpuset.sched.load_balance flag to v2

2018-05-24 Thread Juri Lelli
On 24/05/18 11:09, Waiman Long wrote: > On 05/24/2018 10:36 AM, Juri Lelli wrote: > > On 17/05/18 16:55, Waiman Long wrote: > > > > [...] > > > >> + A parent cgroup cannot distribute all its CPUs to child > >> + scheduling domain cgroups unless

Re: [PATCH v8 3/6] cpuset: Add cpuset.sched.load_balance flag to v2

2018-05-24 Thread Juri Lelli
On 17/05/18 16:55, Waiman Long wrote: [...] > + A parent cgroup cannot distribute all its CPUs to child > + scheduling domain cgroups unless its load balancing flag is > + turned off. > + > + cpuset.sched.load_balance > + A read-write single value file which exists on non-root >

Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-24 Thread Juri Lelli
On 24/05/18 10:04, Patrick Bellasi wrote: [...] > From 84bb8137ce79f74849d97e30871cf67d06d8d682 Mon Sep 17 00:00:00 2001 > From: Patrick Bellasi > Date: Wed, 23 May 2018 16:33:06 +0100 > Subject: [PATCH 1/1] cgroup/cpuset: disable sched domain rebuild when not > required > > The generate_sched

Re: [PATCH v8 4/6] cpuset: Make generate_sched_domains() recognize isolated_cpus

2018-05-24 Thread Juri Lelli
On 17/05/18 16:55, Waiman Long wrote: [...] > @@ -849,7 +860,12 @@ static void rebuild_sched_domains_locked(void) >* passing doms with offlined cpu to partition_sched_domains(). >* Anyways, hotplug work item will rebuild sched domains. >*/ > - if (!cpumask_equal(top_cp

Re: [PATCH v8 6/6] cpuset: Allow reporting of sched domain generation info

2018-05-22 Thread Juri Lelli
Hi, On 17/05/18 16:55, Waiman Long wrote: > This patch enables us to report sched domain generation information. > > If DYNAMIC_DEBUG is enabled, issuing the following command > > echo "file cpuset.c +p" > /sys/kernel/debug/dynamic_debug/control > > and setting loglevel to 8 will allow the ke

Re: [PATCH v8 2/6] cpuset: Add new v2 cpuset.sched.domain flag

2018-05-22 Thread Juri Lelli
Hi, On 17/05/18 16:55, Waiman Long wrote: [...] > /** > + * update_isolated_cpumask - update the isolated_cpus mask of parent cpuset > + * @cpuset: The cpuset that requests CPU isolation > + * @oldmask: The old isolated cpumask to be removed from the parent > + * @newmask: The new isolated cpu

[PATCH] Documentation/admin-guide/pm/intel_pstate: fix Active Mode w/o HWP paragraph

2018-05-08 Thread Juri Lelli
P-state selection algorithm (powersave or performance) is selected by echoing the desired choice to scaling_governor sysfs attribute and not to scaling_cur_freq (as currently stated). Fix it. Signed-off-by: Juri Lelli Cc: Jonathan Corbet Cc: "Rafael J. Wysocki" Cc: Srinivas Pand

Re: [PATCH v7 3/5] cpuset: Add a root-only cpus.isolated v2 control file

2018-04-23 Thread Juri Lelli
On 19/04/18 09:47, Waiman Long wrote: [...] > + cpuset.cpus.isolated > + A read-write multiple values file which exists on root cgroup > + only. > + > + It lists the CPUs that have been withdrawn from the root cgroup > + for load balancing. These CPUs can still be allocated to c

Re: [PATCH v7 0/5] cpuset: Enable cpuset controller in default hierarchy

2018-04-23 Thread Juri Lelli
On 23/04/18 15:07, Juri Lelli wrote: > Hi Waiman, > > On 19/04/18 09:46, Waiman Long wrote: > > v7: > > - Add a root-only cpuset.cpus.isolated control file for CPU isolation. > > - Enforce that load_balancing can only be turned off on cpusets with > &g

Re: [PATCH v7 0/5] cpuset: Enable cpuset controller in default hierarchy

2018-04-23 Thread Juri Lelli
Hi Waiman, On 19/04/18 09:46, Waiman Long wrote: > v7: > - Add a root-only cpuset.cpus.isolated control file for CPU isolation. > - Enforce that load_balancing can only be turned off on cpusets with >CPUs from the isolated list. > - Update sched domain generation to allow cpusets with CPUs

Re: [PATCH v6 2/2] cpuset: Add cpuset.sched_load_balance to v2

2018-03-26 Thread Juri Lelli
On 26/03/18 16:28, Waiman Long wrote: > On 03/26/2018 08:47 AM, Juri Lelli wrote: > > On 23/03/18 14:44, Waiman Long wrote: > >> On 03/23/2018 03:59 AM, Juri Lelli wrote: > > [...] > > > >>> OK, thanks for confirming. Can you tell again howeve

Re: [PATCH v6 2/2] cpuset: Add cpuset.sched_load_balance to v2

2018-03-26 Thread Juri Lelli
On 23/03/18 14:44, Waiman Long wrote: > On 03/23/2018 03:59 AM, Juri Lelli wrote: [...] > > OK, thanks for confirming. Can you tell again however why do you think > > we need to remove sched_load_balance from root level? Won't we end up > > having tasks put on isolated

Re: [PATCH v6 2/2] cpuset: Add cpuset.sched_load_balance to v2

2018-03-23 Thread Juri Lelli
On 22/03/18 17:50, Waiman Long wrote: > On 03/22/2018 04:41 AM, Juri Lelli wrote: > > On 21/03/18 12:21, Waiman Long wrote: [...] > >> + cpuset.sched_load_balance > >> + A read-write single value file which exists on non-root cgroups. > >> + The default

Re: [PATCH v6 2/2] cpuset: Add cpuset.sched_load_balance to v2

2018-03-22 Thread Juri Lelli
Hi Waiman, On 21/03/18 12:21, Waiman Long wrote: > The sched_load_balance flag is needed to enable CPU isolation similar > to what can be done with the "isolcpus" kernel boot parameter. > > The sched_load_balance flag implies an implicit !cpu_exclusive as > it doesn't make sense to have an isolat

[PATCH 1/2] Documentation/locking/lockdep: update info about states

2018-02-13 Thread Juri Lelli
Commit d92a8cfcb37e ("locking/lockdep: Rework FS_RECLAIM annotation") removed reclaim_fs lockdep STATE. Reflect the change in documentation. While we are at it, also clarify formula to calculate number of state bits. Signed-off-by: Juri Lelli Cc: Peter Zijlstra Cc: Ingo Molnar Cc

[RFC PATCH 2/2] Documentation/locking/lockdep: Add section about available annotations

2018-02-13 Thread Juri Lelli
Add section about annotations that can be used to perform additional runtime checking of locking correctness: assert that certain locks are held and prevent accidental unlocking. Signed-off-by: Juri Lelli Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Jonathan Corbet Cc: linux-ker...@vger.kernel.org

[PATCH 0/2] Update lockdep doc and add section about annotations

2018-02-13 Thread Juri Lelli
pretty new and maybe got unnoticed outside of the scheduler?). Best, - Juri Juri Lelli (2): Documentation/locking/lockdep: update info about states Documentation/locking/lockdep: Add section about available annotations Documentation/locking/lockdep-design.txt | 51

[RFC PATCH 3/3] Documentation/scheduler/sched-deadline: add info about cgroup support

2018-02-12 Thread Juri Lelli
Add documentation for SCHED_DEADLINE cgroup support (CONFIG_DEADLINE_ GROUP_SCHED config option). Signed-off-by: Juri Lelli Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Tejun Heo Cc: Jonathan Corbet Cc: Luca Abeni Cc: linux-ker...@vger.kernel.org Cc: linux-doc@vger.kernel.org --- Documentation

[PATCH] Documentation/locking/mutex-design: update to reflect latest changes

2018-02-09 Thread Juri Lelli
Commit 3ca0ff571b09 ("locking/mutex: Rework mutex::owner") reworked the basic mutex implementation to deal with several problems. Documentation was however left unchanged and became stale. Update mutex-design.txt to reflect changes introduced by the above commit. Signed-off-by: Juri

Re: [PATCH] Documentation/scheduler/sched-rt-group: Update SCHED DEADLINE references

2018-02-01 Thread Juri Lelli
off-by: Daniel Bristot de Oliveira > Cc: Jonathan Corbet > Cc: Juri Lelli > Cc: Luca Abeni > Cc: Tommaso Cucinotta > Cc: Claudio Scordino > Cc: Peter Zijlstra > Cc: linux-doc@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > > --- > Documentation/scheduler/sch