Re: [PATCH v3 17/25] gup: Don't allow FOLL_LONGTERM pinning of FS DAX pages

2024-11-21 Thread John Hubbard
!folio_is_zone_movable(folio); Reviewed-by: John Hubbard thanks, -- John Hubbard

Re: [PATCH v3 05/25] fs/dax: Create a common implementation to break DAX layouts

2024-11-21 Thread John Hubbard
(cb)(struct inode *)) @@ -979,6 +981,7 @@ void dax_break_mapping_uninterruptible(struct inode *inode, if (!page) dax_delete_mapping_range(inode->i_mapping, 0, LLONG_MAX); } +EXPORT_SYMBOL_GPL(dax_break_mapping_uninterruptible); /* * Invalidate DAX entry if it is c

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread John Hubbard
ssed Yes. The configuration options all fit together nicely now, and the naming seems exactly right as well. And no more "you must rebuild your kernel" messages. Great! thanks, -- John Hubbard Sounds good to me. And just to repeat, I do not really care about specific name but le

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-14 Thread John Hubbard
On 10/14/24 4:56 PM, Yosry Ahmed wrote: On Mon, Oct 14, 2024 at 4:53 PM John Hubbard wrote: On 10/14/24 4:48 PM, Yosry Ahmed wrote: On Mon, Oct 14, 2024 at 1:37 PM Suren Baghdasaryan wrote: Add CONFIG_PGALLOC_TAG_USE_PAGEFLAGS to store allocation tag references directly in the page flags

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-14 Thread John Hubbard
carce and valuable page flags available for other features? Sorry Suren, to keep coming back to this suggestion, I know I'm driving you crazy here! But I just keep thinking it through and failing to see why this feature deserves to consume so many page flags. thanks, -- John Hubbard Is

Re: [PATCH v2 6/6] alloc_tag: config to store page allocation tag refs in page flags

2024-09-04 Thread John Hubbard
On 9/4/24 9:08 AM, Suren Baghdasaryan wrote: On Tue, Sep 3, 2024 at 7:06 PM 'John Hubbard' via kernel-team wrote: On 9/3/24 6:25 PM, John Hubbard wrote: On 9/3/24 11:19 AM, Suren Baghdasaryan wrote: On Sun, Sep 1, 2024 at 10:16 PM Andrew Morton wrote: On Sun, 1 Sep 2024 21:4

Re: [PATCH v2 6/6] alloc_tag: config to store page allocation tag refs in page flags

2024-09-03 Thread John Hubbard
On 9/3/24 6:25 PM, John Hubbard wrote: On 9/3/24 11:19 AM, Suren Baghdasaryan wrote: On Sun, Sep 1, 2024 at 10:16 PM Andrew Morton wrote: On Sun,  1 Sep 2024 21:41:28 -0700 Suren Baghdasaryan wrote: ... We shouldn't be offering things like this to our users.  If we cannot decide, ho

Re: [PATCH v2 6/6] alloc_tag: config to store page allocation tag refs in page flags

2024-09-03 Thread John Hubbard
ll, that's probably even better. And if there is no way to set it automatically, then that probably means that the feature is still too raw to unleash upon the world. thanks, -- John Hubbard NVIDIA

Re: [PATCH] Documentation: coding-style: don't encourage WARN*()

2024-04-18 Thread John Hubbard
cided to use it for some reason (they do have the ability to customize their kernel command line, after all). It's certainly not used by default or even recommended. - Eric [1] https://lore.kernel.org/lkml/0db131cf-013e-6f0e-c90b-5c1e840d8...@nvidia.com/T/#md6836102150ac1e6265569aad55a692e3af75f34 thanks, -- John Hubbard NVIDIA

Re: Documentation/, SPDX tags, and checkpatch.pl

2019-10-14 Thread John Hubbard
On 10/14/19 1:55 PM, Joe Perches wrote: > On Mon, 2019-10-14 at 13:47 -0700, John Hubbard wrote: >> Hi, >> >> When adding a new Documentation/ file, checkpatch.pl is warning me >> that the SPDX tag is missing. Should checkpatch.pl skip those kinds >> of warnings

Documentation/, SPDX tags, and checkpatch.pl

2019-10-14 Thread John Hubbard
x27;m just looking to get to a warnings-free situation here, one way or the other. :) The exact warning I'm seeing is: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #25: FILE: Documentation/vm/get_user_pages.rst:1: +.. _get_user_pages: -- thanks, John Hubbard NVIDIA