Re: [PATCH v6 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-19 Thread Joel Stanley
re revision, hardware revision, and psu mode(active/standby). > > Signed-off-by: John Wang Reviewed-by: Joel Stanley

Re: [PATCH v5 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-18 Thread Joel Stanley
the match on the device name from the i2c table would be enough. I will defer to Guenter here though. Assuming the device tables are okay: Reviewed-by: Joel Stanley Cheers, Joel > + > +static struct i2c_driver ipsps_driver = { > + .driver = { > + .name =

Re: [PATCH v4 9/9] hwmon (occ): Add sysfs attributes for additional OCC data

2019-01-17 Thread Joel Stanley
On Fri, 18 Jan 2019 at 11:44, Thomas Gleixner wrote: > > Eddie, > > On Wed, 11 Jul 2018, Eddie James wrote: > > > --- /dev/null > > +++ b/drivers/hwmon/occ/sysfs.c > > @@ -0,0 +1,188 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * OCC hwmon driver sysfs interface > > + * > > + * Copyri

Re: [PATCH v10 08/12] mfd: intel-peci-client: Add PECI client driver

2019-01-14 Thread Joel Stanley
ds it would make for a nicer commit message. > Signed-off-by: Jae Hyun Yoo Reviewed-by: Joel Stanley

Re: [PATCH v10 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers

2019-01-14 Thread Joel Stanley
> Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by: Vernon Mauery > Acked-by: Guenter Roeck Reviewed-by: Joel Stanley

[PATCH] docs: Bump version to 5.x

2019-01-13 Thread Joel Stanley
This shows up in the index of https://www.kernel.org/doc/html/latest/ so I figured it should be updated. Fixes: bfeffd15528 ("Linux 5.0-rc1") Signed-off-by: Joel Stanley -- We could also remove the version number instead of applying this patch. --- Documentation/admin-guide/READ

Re: [PATCH v10 01/12] dt-bindings: Add a document of PECI subsystem

2019-01-13 Thread Joel Stanley
On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: > > This commit adds a document of generic PECI bus, adapter and client > driver. > > Cc: Rob Herring > Cc: Mark Rutland > Cc: Andrew Jeffery > Cc: Joel Stanley > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Hai

Re: [PATCH v3 06/10] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2018-04-11 Thread Joel Stanley
Hello Jae, On 11 April 2018 at 04:02, Jae Hyun Yoo wrote: > This commit adds PECI adapter driver implementation for Aspeed > AST24xx/AST25xx. The driver is looking good! It looks like you've done some kind of review that we weren't allowed to see, which is a double edged sword - I might be aski

Re: [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers

2018-04-11 Thread Joel Stanley
Cc: Andrew Jeffery > Cc: Andrew Lunn > Cc: Andy Shevchenko > Cc: Arnd Bergmann > Cc: Benjamin Herrenschmidt > Cc: Fengguang Wu > Cc: Greg KH > Cc: Guenter Roeck > Cc: Jason M Biils > Cc: Jean Delvare > Cc: Joel Stanley > Cc: Julia Cartwright > Cc: Mi

Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs

2018-04-11 Thread Joel Stanley
On 11 April 2018 at 04:02, Jae Hyun Yoo wrote: > This commit adds a dt-bindings document of PECI adapter driver for Aspeed We try to capitalise ASPEED. > AST24xx/25xx SoCs. > --- > .../devicetree/bindings/peci/peci-aspeed.txt | 60 > ++ > 1 file changed, 60 insertions

Re: [PATCH v3 05/10] ARM: dts: aspeed: peci: Add PECI node

2018-04-11 Thread Joel Stanley
On 11 April 2018 at 04:02, Jae Hyun Yoo wrote: > This commit adds PECI bus/adapter node of AST24xx/AST25xx into > aspeed-g4 and aspeed-g5. > The patches to the device trees get merged by the ASPEED maintainer (me). Once you have the bindings reviewed you can send the patches to me and the linux-a

[PATCH] Documentation: Mention why %p prints ptrval

2018-03-21 Thread Joel Stanley
When debugging recent kernels, people will see '(ptrval)' but there isn't much information as to what that means. Briefly describe why it's there. Signed-off-by: Joel Stanley --- Documentation/core-api/printk-formats.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-11 Thread Joel Stanley
On Wed, Jan 10, 2018 at 11:30 PM, Greg KH wrote: > On Wed, Jan 10, 2018 at 01:46:34PM -0800, Jae Hyun Yoo wrote: >> Thanks for your pointing it out and I totally agree with you. Actually, we >> are preparing 4.13 update for now and an another update will be followed up. >> As I answered above, I'l

Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller

2017-06-06 Thread Joel Stanley
On Wed, Jun 7, 2017 at 1:50 AM, Matthew Barth wrote: > > On 06/06/17 8:33 AM, Guenter Roeck wrote: >> >> On 06/06/2017 12:02 AM, Andrew Jeffery wrote: >>> Over and above the features of the original patch is support for a >>> secondary >>> rotor measurement value that is provided by MAX31785 chips

Re: [PATCH linux v7 4/6] hwmon: occ: Add callbacks for parsing P8 OCC datastructures

2017-02-09 Thread Joel Stanley
On Wed, Feb 8, 2017 at 9:40 AM, wrote: > From: "Edward A. James" > > Add functions to parse the data structures that are specific to the OCC on > the POWER8 processor. These are the sensor data structures, including > temperature, frequency, power, and "caps." > > Signed-off-by: Edward A. James

Re: [PATCH linux v7 6/6] hwmon: occ: Add callbacks for parsing P9 OCC datastructures

2017-02-09 Thread Joel Stanley
On Wed, Feb 8, 2017 at 9:40 AM, wrote: > From: "Edward A. James" > > Add functions to parse the data structures that are specific to the OCC on > the POWER9 processor. These are the sensor data structures, including > temperature, frequency, power, and "caps." > > Signed-off-by: Edward A. James

Re: [PATCH linux v7 1/6] hwmon: Add core On-Chip Controller support for POWER CPUs

2017-02-09 Thread Joel Stanley
On Wed, Feb 8, 2017 at 9:40 AM, wrote: > diff --git a/Documentation/hwmon/occ b/Documentation/hwmon/occ > new file mode 100644 > index 000..79d1642 > --- /dev/null > +++ b/Documentation/hwmon/occ The kernel is using reStructuredText these days. You should consider following suit: https:

Re: [PATCH linux v7 5/6] hwmon: occ: Add hwmon implementation for the P8 OCC

2017-02-09 Thread Joel Stanley
On Wed, Feb 8, 2017 at 9:40 AM, wrote: > From: "Edward A. James" > > Add code to tie the hwmon sysfs code and the POWER8 OCC code together, as > well as probe the entire driver from the I2C bus. I2C is the communication > method between the BMC and the P8 OCC. > > Signed-off-by: Edward A. James

Re: [PATCH linux v7 3/6] hwmon: occ: Add I2C transport implementation for SCOM operations

2017-02-09 Thread Joel Stanley
On Wed, Feb 8, 2017 at 9:40 AM, wrote: > From: "Edward A. James" > > Add functions to send SCOM operations over I2C bus. The BMC can > communicate with the Power8 host processor over I2C, but needs to use SCOM > operations in order to access the OCC register space. This doesn't need to be separ

Re: [PATCH linux v7 2/6] hwmon: occ: Add sysfs interface

2017-02-09 Thread Joel Stanley
On Wed, Feb 8, 2017 at 9:40 AM, wrote: > From: "Edward A. James" > > Add a generic mechanism to expose the sensors provided by the OCC in > sysfs. > > Signed-off-by: Edward A. James > Signed-off-by: Andrew Jeffery > --- > Documentation/hwmon/occ | 62 +++ > drivers/hwmon/occ/Ma