Re: [PATCH net-next v3 03/14] net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC

2025-02-11 Thread Jie Gan
On 2/11/2025 9:58 PM, Jie Luo wrote: On 2/10/2025 10:12 AM, Jie Gan wrote: +static int ppe_clock_init_and_reset(struct ppe_device *ppe_dev) +{ +    unsigned long ppe_rate = ppe_dev->clk_rate; +    struct device *dev = ppe_dev->dev; +    struct reset_control *rstc; +    struct clk_bul

Re: [PATCH net-next v3 03/14] net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC

2025-02-11 Thread Jie Gan
On 2/11/2025 9:04 PM, Andrew Lunn wrote: +#ifndef __PPE_H__ +#define __PPE_H__ + +#include +#include + +struct device; #include ? +struct regmap; Same with previous one, include it's header file? If the structure is opaque at this level, it is fine to not include the header. There is

Re: [PATCH net-next v3 01/14] dt-bindings: net: Add PPE for Qualcomm IPQ9574 SoC

2025-02-09 Thread Jie Gan
On 2/9/2025 10:29 PM, Luo Jie wrote: The PPE (packet process engine) hardware block is available in Qualcomm IPQ chipsets that support PPE architecture, such as IPQ9574. The PPE in the IPQ9574 SoC includes six ethernet ports (6 GMAC and 6 XGMAC), which are used to connect with external PHY dev

Re: [PATCH net-next v3 03/14] net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC

2025-02-09 Thread Jie Gan
On 2/9/2025 10:29 PM, Luo Jie wrote: The PPE (Packet Process Engine) hardware block is available on Qualcomm IPQ SoC that support PPE architecture, such as IPQ9574. The PPE in IPQ9574 includes six integrated ethernet MAC (for 6 PPE ports), buffer management, queue management and scheduler fun