Re: [PATCH v5 13/14] selftests/digest_cache: Add selftests for the Integrity Digest Cache

2024-09-05 Thread Jeff Johnson
On 9/5/24 08:05, Roberto Sassu wrote: ... > +module_init(digest_cache_test_init); > +module_exit(digest_cache_test_fini); > +MODULE_LICENSE("GPL"); Missing MODULE_DESCRIPTION() Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing"), a module without a MODULE

Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

2024-03-28 Thread Jeff Johnson
On 3/27/2024 7:21 PM, Barry Song wrote: > From: Xining Xu > > If function-like macros do not utilize a parameter, it might result in a > build warning. In our coding style guidelines, we advocate for utilizing > static inline functions to replace such macros. This patch verifies > compliance wi

Re: [PATCH v5 07/17] soc: qcom: minidump: Add pending region registration

2023-09-11 Thread Jeff Johnson
On 9/9/2023 1:16 PM, Mukesh Ojha wrote: +/** + * struct minidump_pregion - Minidump pending region + * @list : Pending region list pointer + * @region : APSS minidump client region does kernel-doc parse this correctly? should not be whitespace between @ID and ":" refer to

Re: [PATCH v5 06/17] soc: qcom: Add Qualcomm APSS minidump kernel driver

2023-09-11 Thread Jeff Johnson
On 9/11/2023 4:07 AM, Krzysztof Kozlowski wrote: On 09/09/2023 22:16, Mukesh Ojha wrote: +/** + * qcom_minidump_region_register() - Register region in APSS Minidump table. + * @region: minidump region. + * + * Return: On success, it returns 0 and negative error value on failure. + */ +int qcom_m