Re: [PATCH bpf v9 4/5] selftests/bpf: fix invalid flag of recv()

2025-01-26 Thread Jakub Sitnicki
On Wed, Jan 22, 2025 at 06:09 PM +08, Jiayuan Chen wrote: > SOCK_NONBLOCK flag is only effective during socket creation, not during > recv. Use MSG_DONTWAIT instead. > > Signed-off-by: Jiayuan Chen > --- Acked-by: Jakub Sitnicki

Re: [PATCH bpf v9 0/5] bpf: fix wrong copied_seq calculation and add tests

2025-01-26 Thread Jakub Sitnicki
t; capabilities compared to sockmap. > > --- > V8 -> v9 > https://lore.kernel.org/bpf/20250121050707.55523-1-mr...@163.com/ > Fixed some issues suggested by Jakub Sitnicki. > > V7 -> V8 > https://lore.kernel.org/bpf/20250116140531.108636-1-mr...@163.com/ > Avoid usin

Re: [PATCH bpf v9 5/5] selftests/bpf: add strparser test for bpf

2025-01-26 Thread Jakub Sitnicki
On Wed, Jan 22, 2025 at 06:09 PM +08, Jiayuan Chen wrote: > Add test cases for bpf + strparser and separated them from > sockmap_basic, as strparser has more encapsulation and parsing > capabilities compared to standard sockmap. > > Signed-off-by: Jiayuan Chen > --- Acked-by: Jakub Sitnicki

Re: [PATCH bpf v9 3/5] bpf: disable non stream socket for strparser

2025-01-26 Thread Jakub Sitnicki
d. > > Moreover, since UDP lacks the concept of streams, we intercept it directly. > > Fixes: 1fa1fe8ff161 ("bpf, sockmap: Test shutdown() correctly exits epoll and > recv()=0") > Signed-off-by: Jiayuan Chen > --- Acked-by: Jakub Sitnicki

Re: [PATCH bpf v9 2/5] bpf: fix wrong copied_seq calculation

2025-01-26 Thread Jakub Sitnicki
alize desc to zero. So, for now, we are directly calling > tcp_read_sock_noack() in tcp_bpf.c. > > [1]: https://lore.kernel.org/bpf/20241218053408.437295-1-mr...@163.com > Fixes: e5c6de5fa025 ("bpf, sockmap: Incorrectly handling copied_seq") > Suggested-by: Jakub Sitnicki > Signed-off-by: Jiayuan Chen > --- I'm happy with how this turned out, but let's run it by Eric. Reviewed-by: Jakub Sitnicki

Re: [PATCH bpf v9 1/5] strparser: add read_sock callback

2025-01-26 Thread Jakub Sitnicki
On Wed, Jan 22, 2025 at 06:09 PM +08, Jiayuan Chen wrote: > Added a new read_sock handler, allowing users to customize read operations > instead of relying on the native socket's read_sock. > > Signed-off-by: Jiayuan Chen > --- Reviewed-by: Jakub Sitnicki

Re: [PATCH bpf v8 5/5] selftests/bpf: add strparser test for bpf

2025-01-21 Thread Jakub Sitnicki
Thanks for expanding tests. On Tue, Jan 21, 2025 at 01:07 PM +08, Jiayuan Chen wrote: > Add test cases for bpf + strparser and separated them from > sockmap_basic, as strparser has more encapsulation and parsing > capabilities compared to sockmap. > > Signed-off-by: Jiayuan Chen > --- > .../self

Re: [PATCH bpf v8 4/5] selftests/bpf: fix invalid flag of recv()

2025-01-21 Thread Jakub Sitnicki
ctly exits epoll and recv()=0") Reviewed-by: Jakub Sitnicki

Re: [PATCH bpf v8 3/5] bpf: disable non stream socket for strparser

2025-01-21 Thread Jakub Sitnicki
UPP; > if (ret) { > write_unlock_bh(&sk->sk_callback_lock); > sk_psock_put(sk, psock); Reviewed-by: Jakub Sitnicki

Re: [PATCH bpf v8 1/5] strparser: add read_sock callback

2025-01-21 Thread Jakub Sitnicki
On Tue, Jan 21, 2025 at 01:07 PM +08, Jiayuan Chen wrote: > Added a new read_sock handler, allowing users to customize read operations > instead of relying on the native socket's read_sock. > > Signed-off-by: Jiayuan Chen > --- Reviewed-by: Jakub Sitnicki

Re: [PATCH bpf v8 2/5] bpf: fix wrong copied_seq calculation

2025-01-21 Thread Jakub Sitnicki
lback for strparser for customized read operation. > > [1]: https://lore.kernel.org/bpf/20241218053408.437295-1-mr...@163.com > Fixes: e5c6de5fa025 ("bpf, sockmap: Incorrectly handling copied_seq") > Suggested-by: Jakub Sitnicki > Signed-off-by: