Re: [PATCH v6] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2017-01-02 Thread Hui Chun Ong
On Thu, 2016-12-29 at 02:09 -0800, Guenter Roeck wrote: > On 12/28/2016 10:56 PM, Hui Chun Ong wrote: > > > > Add support for the watchdog timer on PXI Embedded Controller. > > > > Reviewed-by: Guenter Roeck > > Signed-off-by: Hui Chun Ong > > --- > &g

[PATCH v6] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-28 Thread Hui Chun Ong
Add support for the watchdog timer on PXI Embedded Controller. Reviewed-by: Guenter Roeck Signed-off-by: Hui Chun Ong --- v5: Add Reviewed-by. v4: Remove nic7018_stop() from nic7018_remove(). Lock WDT registers when watchdog_register_device() call failed. v3: Update timeout calculation

[PATCH v5] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-27 Thread Hui Chun Ong
Add support for the watchdog timer on PXI Embedded Controller. Signed-off-by: Hui Chun Ong --- v4: Remove nic7018_stop() from nic7018_remove(). Lock WDT registers when watchdog_register_device() call failed. v3: Update timeout calculation from miliseconds to seconds. Reorder

[PATCH v4] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-15 Thread Hui Chun Ong
Add support for the watchdog timer on PXI Embedded Controller. Signed-off-by: Hui Chun Ong --- v3: Update timeout calculation from miliseconds to seconds. Reorder watchdog_regiser_device() call to prevent potential race condition. v2: Remove mutex lock and platform_device *pdev fields from

Re: [PATCH v3] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-13 Thread Hui Chun Ong
On Sat, 2016-12-10 at 09:22 -0800, Guenter Roeck wrote: > On 12/10/2016 02:25 AM, Hui Chun Ong wrote: > > > > Add support for the watchdog timer on PXI Embedded Controller. > > > > Signed-off-by: Hui Chun Ong > > --- > > v2: Remove mutex lock and p

[PATCH v3] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-10 Thread Hui Chun Ong
Add support for the watchdog timer on PXI Embedded Controller. Signed-off-by: Hui Chun Ong --- v2: Remove mutex lock and platform_device *pdev fields from struct nic7018_wdt. Update config NIC7018_WDT description. Update nic7018_get_config() to never return error. Remove checking for

Re: [PATCH v2] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-08 Thread Hui Chun Ong
On Thu, 2016-12-08 at 06:15 -0800, Guenter Roeck wrote: > On 12/08/2016 01:19 AM, Hui Chun Ong wrote: > > > > On Thu, 2016-11-24 at 11:56 -0800, Guenter Roeck wrote: > > > > > > On 11/15/2016 07:21 PM, Hui Chun Ong wrote: > > > > > > >

Re: [PATCH v2] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-12-08 Thread Hui Chun Ong
On Thu, 2016-11-24 at 11:56 -0800, Guenter Roeck wrote: > On 11/15/2016 07:21 PM, Hui Chun Ong wrote: > > > > Add support for the watchdog timer on PXI Embedded Controller. > > > > Signed-off-by: Hui Chun Ong > > --- > > v1: Remove non-standard attribu

Re: [RESEND PATCH] watchdog: ni7018_wdt: Add NIC7018 watchdog driver

2016-11-15 Thread Hui Chun Ong
0800, Hui Chun Ong wrote: > > > > Add support for the watchdog timer on PXI Embedded Controller. > > > > Signed-off-by: Hui Chun Ong > The problem with your patch are the non-standard attributes it introduces. > > +static WDT_ATTR(enable_reset, WDT_CTRL, WDT_CTRL

[PATCH v2] watchdog: nic7018_wdt: Add NIC7018 watchdog driver

2016-11-15 Thread Hui Chun Ong
Add support for the watchdog timer on PXI Embedded Controller. Signed-off-by: Hui Chun Ong --- v1: Remove non-standard attributes. Change from acpi_driver to platform_driver. Rename driver from ni7018_wdt to nic7018_wdt. --- Documentation/watchdog/watchdog-parameters.txt | 5

[RESEND PATCH] watchdog: ni7018_wdt: Add NIC7018 watchdog driver

2016-10-28 Thread Hui Chun Ong
Add support for the watchdog timer on PXI Embedded Controller. Signed-off-by: Hui Chun Ong --- Documentation/watchdog/watchdog-parameters.txt | 5 + drivers/watchdog/Kconfig | 11 + drivers/watchdog/Makefile | 1 + drivers/watchdog/ni7018_wdt.c